From patchwork Sat Jul 29 07:42:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 128058 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp916862vqg; Sat, 29 Jul 2023 01:31:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlE1FxtkEUpUWKUOModqb2ozL263tdFzvIKL1QMx1peGJJg7o+j3jgtRWDZlyLxa8tIFt4GI X-Received: by 2002:a05:6a20:1010:b0:138:dbff:f0c1 with SMTP id gs16-20020a056a20101000b00138dbfff0c1mr4305802pzc.1.1690619512110; Sat, 29 Jul 2023 01:31:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690619512; cv=none; d=google.com; s=arc-20160816; b=qC4JM/2AQ4YDov1sXRpeb44WAIHoEy2KgWjrpbLsdMXPSjJ8xnKo1KTqIQCOlEFJ/e Ww7FLsQV30n+M5+NvanZCLBFR88OwJZh5Dr4d9WaubYjcn9nfzesyseMRoGm6jggbydZ FMCPyl1oussaJbSFi067m12Z6D/6Zy3EU/evr6FD1//Biady/6JA/8S/kbC5nnK1gacv 7/Br+yL45zSvHwZUvdoKcrWTv/FEcXOkFgl7tIFB7zIuWWQiO4iI+PH9ZtqwlT3b4c3Q ZqaB5l/a3fWCOzE8yK2eYwsRiF0S0mmbFqLKr9SyQUCfmGkvWzUScgGn8ljJ0vRe57Pi xD+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QLKOsRAABiB7bon7JmWs/lzQnfsn47zTN9pubq64/Ek=; fh=+CxMmWgc3roKPr23V0jvvvOGTKj1n7zj8A1PGCoy/HU=; b=YIHBOdYV/JVrGOaqwaZusZv4n0kTWCRGwckzbpLzjk6f70BUmRAgwm3NtYetyPLkuS xT3VIMNwEMxOO/noEQy/1lIJwsqou+TXKjH3F/0h1gZ/QP8iPIPi3ivOY4Kq7jtAds+v BG3beVI4dSDML91xzBaXXq/Tg4Qrw9eBiZVw3UYi+A3bgAk5MlN8E8OsTQ72f/Pwlgwl JF7boNvavYjDi2ApBsTqaVNOWciblndFUROUqwSrLQ/Aw/ZQkG1CZtN1dnSuLL6BQQNT SQRgwJAgTaPI4Lr8qhFIrICRlyU2lTdTBt10a5wz+MXpt86w9/8GTDIWgENwivzzBaTR KTLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oY8WlMg6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j63-20020a638042000000b00563d781913csi4208876pgd.152.2023.07.29.01.31.38; Sat, 29 Jul 2023 01:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oY8WlMg6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbjG2Hmj (ORCPT + 99 others); Sat, 29 Jul 2023 03:42:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbjG2Hmi (ORCPT ); Sat, 29 Jul 2023 03:42:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C8A430FC; Sat, 29 Jul 2023 00:42:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4ADF60691; Sat, 29 Jul 2023 07:42:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20464C433C7; Sat, 29 Jul 2023 07:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690616556; bh=ZKOq4dSq8LU22/XO77L6SVfNnBWbdQNZk2Y0aYMmtrk=; h=From:To:Cc:Subject:Date:From; b=oY8WlMg693/n1jO+IK3qR+BcpBifWVgXBOEoX2C0glibs2FGB4W6Bol3hKkW3axTX 4uSBPz6vxZSPODP6NpXJX2NHZ7opwX3XEIMe07AOkJj74D1aNaKZEoA48pdX/kcNIf cG/vh0rd3JYWxz8X87Hkj9bshjXm/M3Jz978FESyJ8nSuWdTPL1KKfkNwu3eteP/tM /cz1IERe/2fIP+cVP9TOeLeY2nECxDPyuH+uLcaMyo12Vdvvit+8IQGrd/0cnXgy4H 8mLISuJe7lo12xbGYwssti7nBvN9R/AtLWw+iXMCyi0iEzazmCw3RqHEnHR8Uz9guU 1tl4Ox9dG55mg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Chen Gong , Tony Luck Subject: [PATCH] alpha: remove __init annotation from exported page_is_ram() Date: Sat, 29 Jul 2023 16:42:23 +0900 Message-Id: <20230729074223.1457109-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772743045433831499 X-GMAIL-MSGID: 1772743045433831499 EXPORT_SYMBOL and __init is a bad combination because the .init.text section is freed up after the initialization. Commit c5a130325f13 ("ACPI/APEI: Add parameter check before error injection") exported page_is_ram(), hence the __init annotation should be removed. This fixes the modpost warning in ARCH=alpha builds: WARNING: modpost: vmlinux: page_is_ram: EXPORT_SYMBOL used for init symbol. Remove __init or EXPORT_SYMBOL. Fixes: c5a130325f13 ("ACPI/APEI: Add parameter check before error injection") Signed-off-by: Masahiro Yamada Reviewed-by: Randy Dunlap --- arch/alpha/kernel/setup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/alpha/kernel/setup.c b/arch/alpha/kernel/setup.c index b650ff1cb022..3d7473531ab1 100644 --- a/arch/alpha/kernel/setup.c +++ b/arch/alpha/kernel/setup.c @@ -385,8 +385,7 @@ setup_memory(void *kernel_end) #endif /* CONFIG_BLK_DEV_INITRD */ } -int __init -page_is_ram(unsigned long pfn) +int page_is_ram(unsigned long pfn) { struct memclust_struct * cluster; struct memdesc_struct * memdesc;