From patchwork Fri Jul 28 18:39:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 127873 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp698649vqg; Fri, 28 Jul 2023 14:22:07 -0700 (PDT) X-Google-Smtp-Source: APBJJlH8pP4aslvZ2IZqoPULfgxIOufkuTlPFWJdtz941cRlWAKPfsNKmmCWtAF8I0JmWhceDmNl X-Received: by 2002:a05:6512:3286:b0:4fa:6d62:9219 with SMTP id p6-20020a056512328600b004fa6d629219mr2627472lfe.62.1690579327196; Fri, 28 Jul 2023 14:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690579327; cv=none; d=google.com; s=arc-20160816; b=K6J4DOCEv8GZOZEzzv3i+hhTm3e7i+J3h4QUbgRt9B7Gj2l2YkDRx4sLwZkkifCMCk sRc365GtvwkjfT04H0WuiGi1AtsM5mEzfrs/xQwhj05HgT4hlDy6Nl2Y8yUi+2tngxC3 5QWO7LwASLHteBxQH37y5bVMPmL4a9q/f7ip6fK3mi8bUzTzmx1W5QgewvYeLDLnzNFJ MA9GDeq9jZK4CAsHVhTkiuHBoSObmylxQUVOTg6lHFrY/HBCU/JsQTvfhH2ymNUzcFkY x/adRylCPwXHJFKmgWWMyu+4LX929sdon5vjtDTHAmaxio/FiXFxE14w61kHX5E0l12e 2mqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=foeuoRt8vJ86SniyENdT8h2KqQ5V1Yu0TGwWbmhK43g=; fh=6oqRk9p5r5e0nHbCVLZZTssMlGN+jNNRWDs92V29BMc=; b=l+ousDPZgnYZePufcZ6GDIV1NaksTuwqCeDW8MocDjA23aqz+ZSmxg5j7FA/zVfKxv 0ntmyBs11ztH3kTsHE5fHHtfj8O3AmvPItGUbkCtxY6hU4jdR0CVyBTb5Q+qVSUF/vW7 +KT4CWqjN3pEVdja+YBbtGGOxYfPom/fZT7cK0zC1HMThFoqZk3z29VO5CL8zuT3NFGW O04pMVgKoflwb6Qy2fk4IgezFsBUk0pgqY8AB0rPIuTaCE6QfaExhLH0aafPirVxDYdq kVdEzyC+F1V2d63iS1YEliVYiiKJhrED1epwChi+7nzkpsPLrJP1e7DY62jtZ9YMjN27 bXqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b="K/ZxRGs/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n24-20020aa7db58000000b005222252bfafsi3084732edt.547.2023.07.28.14.21.43; Fri, 28 Jul 2023 14:22:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b="K/ZxRGs/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233512AbjG1Skf (ORCPT + 99 others); Fri, 28 Jul 2023 14:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233735AbjG1SkU (ORCPT ); Fri, 28 Jul 2023 14:40:20 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E9414C1D for ; Fri, 28 Jul 2023 11:39:57 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-686e0213c0bso1781889b3a.1 for ; Fri, 28 Jul 2023 11:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1690569596; x=1691174396; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=foeuoRt8vJ86SniyENdT8h2KqQ5V1Yu0TGwWbmhK43g=; b=K/ZxRGs/tS/JeYZryYNK3Nl9jwDjq/KuOjhZrmP6yYKawA7q/oWyXxrvgbiBz4MjFM YW0VJodKuJYtBIGS/+0cOMXJ3Kisu8pqWqtV9bZhrORnob16dwlHRc3LwcCOJ8fnhNGa TsKptP36Cz9ByxQksEfYfXIDXLLWRBhGGkBak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690569596; x=1691174396; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=foeuoRt8vJ86SniyENdT8h2KqQ5V1Yu0TGwWbmhK43g=; b=JM/EVOT+JAvH/r7S0zxB21JaXaE57hX6+0bwPgW3NOSUYpKjoQADuBmYe65OPw9Uo9 jbPStcoLZQ2uFeosNilMv98UTWKwQUL68utH+IfLxMm4qKAYP7U/gG7bUkbdVYi1WQzq 7VKrDYgKTvJj5E/bTzR2+zVJxDsRPqHJqUrnDgeGoHuImp6aGrhrNt5Wv+gXZ1qya6rZ ThS6+SSzm2MubsADB+utIj8oDBXVSos8tqqN82FDJpTEmE+0sAsweKBCD+veOI+ut+jP Ns6Nj8FNbxg4mLUVhmqONbq0pp1eSfIIm3U8FifVzLq9Zh9naG2r8pqhSFt9gtq2n53H IA/Q== X-Gm-Message-State: ABy/qLbX9i+il/OYRcSgaNu4STxQjGw6Hromv+/QHRgsAqALh2YPFwEA 5UIGt3I5aEn55Zsunx1I014aeg== X-Received: by 2002:a05:6a20:3d1e:b0:134:37bb:89be with SMTP id y30-20020a056a203d1e00b0013437bb89bemr2525901pzi.57.1690569596491; Fri, 28 Jul 2023 11:39:56 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id e3-20020aa78243000000b006866a293e58sm3589470pfn.176.2023.07.28.11.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 11:39:56 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Doug Berger , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next] net: bcmgenet: Remove TX ring full logging Date: Fri, 28 Jul 2023 11:39:45 -0700 Message-Id: <20230728183945.760531-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, MIME_BOUND_DIGITS_15,MIME_NO_TEXT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772700908676347163 X-GMAIL-MSGID: 1772700908676347163 There is no need to spam the kernel log with such an indication, remove this message. Signed-off-by: Florian Fainelli Reviewed-by: Simon Horman --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 2b5761ad2f92..24bade875ca6 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -2077,12 +2077,8 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev) spin_lock(&ring->lock); if (ring->free_bds <= (nr_frags + 1)) { - if (!netif_tx_queue_stopped(txq)) { + if (!netif_tx_queue_stopped(txq)) netif_tx_stop_queue(txq); - netdev_err(dev, - "%s: tx ring %d full when queue %d awake\n", - __func__, index, ring->queue); - } ret = NETDEV_TX_BUSY; goto out; }