From patchwork Fri Jul 28 17:10:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 127486 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp316736vqg; Fri, 28 Jul 2023 02:51:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlFQqDM3pnD23f+hS1KH7tj12ylSpmbOniv5sXOldW2MvjZpESxK7OBKu7lPbmO556Wvcejt X-Received: by 2002:a17:902:7d8e:b0:1bb:c5a9:6b26 with SMTP id a14-20020a1709027d8e00b001bbc5a96b26mr1025804plm.5.1690537885413; Fri, 28 Jul 2023 02:51:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690537885; cv=none; d=google.com; s=arc-20160816; b=0Dk069oCJ8SUG9KMjbymesDycKvucfcdjyPoN7/t/JyEEs1CiT0/LQgHUaFCUBKimc jPJ887DZnfkvOa9I+7pCoorfqXKM5j7h295eM0DchiqiFwDchDnxty58WiCFYyEJwk6n e4JheJzOh842Z4isHRGUrhgKgP7yF9FKU/O2lhb0FAh9fW7doBpvugs7vciF9GRkeab2 9zLDdpRQ5Y8NMLMLnmX9YTTtZ6AR5ZAPzhuPgoBesfkQfgQbdNbLkTSp/5HEDTU2Qj9z nWDdRgHHgQpycVjdbaGEpcNWMrpV47F6n90r16LFwD00utm6W0FPWRfTdinpe+mM7Bbd 1vZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=qj0nYBSsAC2wvn2l1Gxd9Hb49uXKy1ml83q/tUvBcI4=; fh=TSUM3bg1l4VMuLzo5+/YZeHv/ZQR+PETNj1d6BtXHQc=; b=i0/yN+SlDtH5HFQ+AyhbqMDvjO83OUFC1ROvOng0MPBuVbd6eAvTh5dRFXRg7i8G+W K80iuqqxCFLvANCaliMfUYrX4vVZXk8zr2+WmqRnehs/VrofaPN2fcE7ILUj41ZIqoSJ YkX/SADDD1qtf0PsW1+ipAjF4zTj4IUp3+9ARkELpN82YXbjLu4rI3AWxkYYG+APJ69u 2Rq0+H/FzJ0eddDSWbG0SGfb4BVXJ0EwtVtBlzQlujQCmL/hkurkZ4J/2M5ufJ3KIulC rMhBX+Z1DpGodzXY+5VziDVbMIagOm/Ahid8N1yyOVy9v8RwKQj650L42bCz3n/AI0vP Msiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n6-20020a170902e54600b001b88ff83e45si2917075plf.571.2023.07.28.02.51.12; Fri, 28 Jul 2023 02:51:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235413AbjG1JNu (ORCPT + 99 others); Fri, 28 Jul 2023 05:13:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234705AbjG1JMk (ORCPT ); Fri, 28 Jul 2023 05:12:40 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B192244BD for ; Fri, 28 Jul 2023 02:10:21 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RC20V3TVdz4f43LB for ; Fri, 28 Jul 2023 17:10:18 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgA3n7L1hcNkCrD+Ow--.32454S10; Fri, 28 Jul 2023 17:10:18 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false Date: Sat, 29 Jul 2023 01:10:37 +0800 Message-Id: <20230728171037.2219226-9-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230728171037.2219226-1-shikemeng@huaweicloud.com> References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgA3n7L1hcNkCrD+Ow--.32454S10 X-Coremail-Antispam: 1UD129KBjvdXoWrtw4ktF1DJF1UKr4fGr17ZFb_yoW3WFc_Jr n2yF4Fyw1Svr93AFn8uw43Cr1kKrWDCr17Wa4kXr1ayrWvya1kX3Z7Xr9xXrn8XFW7W3sx G3ykZF48GFyS9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRKFAPU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772657453918133185 X-GMAIL-MSGID: 1772657453918133185 Keep the same logic as update_pageblock_skip, only set skip if no_set_skip_hint is false which is more reasonable. Signed-off-by: Kemeng Shi Reviewed-by: David Hildenbrand --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 188d610eb3b6..6841c0496223 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1418,7 +1418,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); /* Skip this pageblock in the future as it's full or nearly full */ - if (start_pfn == end_pfn) + if (start_pfn == end_pfn && !cc->no_set_skip_hint) set_pageblock_skip(page); }