Message ID | 20230728171037.2219226-8-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp305358vqg; Fri, 28 Jul 2023 02:24:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlE7696LiyxjZ9+307HCsiGGYKaA/qiH97BhVggxmrjfhBpy+qFGhYRVI4GZ2qXGaZmcsXQf X-Received: by 2002:a17:906:1005:b0:99b:d89c:9dd7 with SMTP id 5-20020a170906100500b0099bd89c9dd7mr1471872ejm.77.1690536283252; Fri, 28 Jul 2023 02:24:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690536283; cv=none; d=google.com; s=arc-20160816; b=q1H0cxutRa7UHhVQpb4seaGlVdWf4wFIyMLw21vzKZ3NO1L76MB59MuYcvFgM7ErMd wiwyGZJpIg3q1D4ow2LAXCyp8/ER+5H/65j83ZiRESxW2eOBDTz6PR3pdazYcQyh/m00 pHED7USeIFsd2uSEAdmNd6LR3DAZKe9u8/rXqInhqTJQhoMDxE5GxM2C+ylMNkdx/cHn ddDDeTUj3+OT3UYuGySJJ8BiG51nMWQ0iA+hXZXcegEPKZy/6qSzXoZitT+mEeuCVAIJ NVs1B0Nw0qfngXvUUTJif4KjhA+2D3wnbxjYo5GE7WuiZxUDHcOqyQMwoka2jM5DpZlT 32Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=aN2rlWqu7BZrnC/zxPsG2DrPNlKyotTO1A51nFjJGlY=; fh=TSUM3bg1l4VMuLzo5+/YZeHv/ZQR+PETNj1d6BtXHQc=; b=c/wgf5hroify3E5kvL63rad+nK4B8UzSDpF01I9aemuRNeafRCzztfO9XRVnpGrw/y wRCWjUMn7gUL7WaETka4wUqQLwTDuKcj7dzB3eEHCaH0CBYaK4iGZbbTxOmbZY1/Ap28 iwLl8K8Fdfg9Ij24PtTRVbS4CXmIpWrODlppSZLrwIwJW6Eqv22CYhSpupQ5JdWumdDS 8STdYp3IQP9HJC7GXDT/sfRiOChpsScoNsqnyZgjifDQTKMHGcxiTR4WeG+/LpH1El7K XHQgcEo2T2N2CG3Z64EiVvyeMtGwCe37d9zqSqtilcOMFiN/aEyVKtUEOYtO3PUBcxNy 6TZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rv23-20020a17090710d700b0099bcc342fc3si2657503ejb.677.2023.07.28.02.24.19; Fri, 28 Jul 2023 02:24:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235335AbjG1JNl (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Fri, 28 Jul 2023 05:13:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234228AbjG1JMj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Jul 2023 05:12:39 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EA3644B5 for <linux-kernel@vger.kernel.org>; Fri, 28 Jul 2023 02:10:21 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RC20V0Wq6z4f43L8 for <linux-kernel@vger.kernel.org>; Fri, 28 Jul 2023 17:10:18 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgA3n7L1hcNkCrD+Ow--.32454S9; Fri, 28 Jul 2023 17:10:18 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com Cc: shikemeng@huaweicloud.com Subject: [PATCH 7/8] mm/compaction: remove unnecessary return for void function Date: Sat, 29 Jul 2023 01:10:36 +0800 Message-Id: <20230728171037.2219226-8-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230728171037.2219226-1-shikemeng@huaweicloud.com> References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgA3n7L1hcNkCrD+Ow--.32454S9 X-Coremail-Antispam: 1UD129KBjvdXoWrtryxtr1Utr4UtF4ruF45Wrg_yoWfCwb_Jr 1SkrWFqw1Yvrn5CFsrCw4SvrykKr4DCr1Yqa1qqF17tr92ya1vvwnrZr13ZrWYqa9rWr9x Kwn5ZFsFkF1avjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRKFAPU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772655773686107570 X-GMAIL-MSGID: 1772655773686107570 |
Series |
Fixes and cleanups to compaction
|
|
Commit Message
Kemeng Shi
July 28, 2023, 5:10 p.m. UTC
Remove unnecessary return for void function
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/compaction.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Comments
On 28.07.23 19:10, Kemeng Shi wrote: > Remove unnecessary return for void function > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > mm/compaction.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 6052cb519de1..188d610eb3b6 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1420,8 +1420,6 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > /* Skip this pageblock in the future as it's full or nearly full */ > if (start_pfn == end_pfn) > set_pageblock_skip(page); > - > - return; > } > > /* Search orders in round-robin fashion */ > @@ -2863,7 +2861,7 @@ int compaction_register_node(struct node *node) > > void compaction_unregister_node(struct node *node) > { > - return device_remove_file(&node->dev, &dev_attr_compact); > + device_remove_file(&node->dev, &dev_attr_compact); > } > #endif /* CONFIG_SYSFS && CONFIG_NUMA */ > Reviewed-by: David Hildenbrand <david@redhat.com>
On 7/29/2023 1:10 AM, Kemeng Shi wrote: > Remove unnecessary return for void function > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> > --- > mm/compaction.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 6052cb519de1..188d610eb3b6 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1420,8 +1420,6 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > /* Skip this pageblock in the future as it's full or nearly full */ > if (start_pfn == end_pfn) > set_pageblock_skip(page); > - > - return; > } > > /* Search orders in round-robin fashion */ > @@ -2863,7 +2861,7 @@ int compaction_register_node(struct node *node) > > void compaction_unregister_node(struct node *node) > { > - return device_remove_file(&node->dev, &dev_attr_compact); > + device_remove_file(&node->dev, &dev_attr_compact); > } > #endif /* CONFIG_SYSFS && CONFIG_NUMA */ >
diff --git a/mm/compaction.c b/mm/compaction.c index 6052cb519de1..188d610eb3b6 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1420,8 +1420,6 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) /* Skip this pageblock in the future as it's full or nearly full */ if (start_pfn == end_pfn) set_pageblock_skip(page); - - return; } /* Search orders in round-robin fashion */ @@ -2863,7 +2861,7 @@ int compaction_register_node(struct node *node) void compaction_unregister_node(struct node *node) { - return device_remove_file(&node->dev, &dev_attr_compact); + device_remove_file(&node->dev, &dev_attr_compact); } #endif /* CONFIG_SYSFS && CONFIG_NUMA */