[v3,03/50] dt-bindings: net: cdns,macb: add sam9x7 ethernet interface

Message ID 20230728102328.265410-1-varshini.rajendran@microchip.com
State New
Headers
Series [v3,01/50] dt-bindings: microchip: atmel,at91rm9200-tcb: add sam9x60, sam9x7 compatible |

Commit Message

Varshini Rajendran July 28, 2023, 10:23 a.m. UTC
  Add documentation for sam9x7 ethernet interface.

Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/cdns,macb.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Krzysztof Kozlowski July 28, 2023, 11:44 a.m. UTC | #1
On 28/07/2023 12:23, Varshini Rajendran wrote:
> Add documentation for sam9x7 ethernet interface.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index bf8894a0257e..c9840a284322 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -59,6 +59,12 @@ properties:
>            - cdns,gem                  # Generic
>            - cdns,macb                 # Generic
>  
> +      - items:
> +          - enum:
> +              - microchip,sam9x7-gem  # Microchip SAM9X7 gigabit ethernet interface
> +          - enum:
> +              - microchip,sama7g5-gem # Microchip SAMA7G5 gigabit ethernet interface

That's entirely different patch than before. Not correct also - drop the
second enum, because it cannot be enum.

Please provide changelogs explaining what happened in the patch. Sending
such huge patchset with changelog only in cover letter with very vague
description of changes is not helping.

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index bf8894a0257e..c9840a284322 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -59,6 +59,12 @@  properties:
           - cdns,gem                  # Generic
           - cdns,macb                 # Generic
 
+      - items:
+          - enum:
+              - microchip,sam9x7-gem  # Microchip SAM9X7 gigabit ethernet interface
+          - enum:
+              - microchip,sama7g5-gem # Microchip SAMA7G5 gigabit ethernet interface
+
   reg:
     minItems: 1
     items: