From patchwork Fri Jul 28 06:19:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tree Davies X-Patchwork-Id: 127366 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp252110vqg; Fri, 28 Jul 2023 00:15:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlEoqheCvgITObk3S6FoXNOMWqD1+VVyH5RxAguaBOpOCWXV73y0z1JqGkw37+5QtE4HJRm4 X-Received: by 2002:a17:907:2cd5:b0:99b:d440:bf0c with SMTP id hg21-20020a1709072cd500b0099bd440bf0cmr1092593ejc.57.1690528503377; Fri, 28 Jul 2023 00:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690528503; cv=none; d=google.com; s=arc-20160816; b=iY9/TcgcGKECS/xenxMxynx3BmNlQ9aauQF9ojKlmFjfNdKTz8UETkaGNCRuiWCCLZ BjAf27iKOT6ZyTzIQa2tP9ObMnX7H0fCOqKYnUd2ic7BMisZPyrpXT2nrJdGzGySiL2k Ned9Hx8l1/hMmNDKcpX75ma6UVaoRjGDE+BVQo/P0qIs01poRKAynGOuoQlUi38ny4nf QJW7TnxD3bNAO3FstX7kQfRrq+61pvO4Rhwlk/h287gVz9SQPEE6nmeezaK4lwVAWb1m 1WmYOm9pw67XpABBgntnemj2AzvOA0Me7Ku+aIMZd1x/LGAcTw69U3xbZYP6Pzlt4GnH d+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=PjE1aMhnHx2bVNCWbPHu6R6szoWfPfCEn/5RnI00mWg=; fh=I5RbcQPTSTvrwt0yqig+bV2C3roPED/NlXe1P2BfE7E=; b=m1+BEsDHdAlYjdCkukmPHOxlub6Of/YKNm4xVq9Ugc9+Kuj6A2+mgTTUS4dyw8Nxu9 w3MSGDiSRg3iP+wrhDS5JF9ovIV7KdumHkZtxI1EFQTNPa34iZrZiArT3YxxM4bChSXR Vbsi1Xdqt9+bDctPRXXpezydE350sfY+kaOJ5jrk+sS6tWmPP6mzIp2bOpj1stwBzbCT Oy7rCItjl3twDwAKjN8GYATpE7wUzSzGKRMPi0C7h9+BkB5Dp6X0kDHiXWKqWBXesJC8 skpwbNU73CJkBbTLJYnCvUo99yE7JM5sYME4bMrQ0w1Iy6I20S3hLsbXRVVFqaIkH0QU l9SA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=cDRh8wIn; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=bse0qP6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id by23-20020a170906a2d700b00993325b159csi2307880ejb.659.2023.07.28.00.14.39; Fri, 28 Jul 2023 00:15:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=cDRh8wIn; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=bse0qP6W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbjG1GTW (ORCPT + 99 others); Fri, 28 Jul 2023 02:19:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233524AbjG1GTT (ORCPT ); Fri, 28 Jul 2023 02:19:19 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0958421C for ; Thu, 27 Jul 2023 23:18:47 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id EBBAC1A8D10; Fri, 28 Jul 2023 02:18:12 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=sasl; bh=JOkJwPjwlZO67IiYuY88Dz2P3 NwcX7o5HkWjwCQM+bw=; b=cDRh8wInbXbxsPkNT2+mgYztC8Hc6RyO7EaLmMzMp NEbAjtOMetf4kdDxmwlKN/C2yKVtqo004EHslgkwewkn9oYBe2Wcc7CA0OY1VMcQ OVY22E4yVCjq3awjw+nNVdGvbL5grRATiY6APKhrjwU4rBon5Acrh7FWvzai1jpB vU= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id E5AB11A8D0F; Fri, 28 Jul 2023 02:18:12 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkphysics.net; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=2019-09.pbsmtp; bh=XUtp31xPUR4KlS3n6K/4849ubr4dJYL/+GyX7zOXVr0=; b=bse0qP6WjvU6EmRKjIFolqBTaMUIqlEjhVzlknpWGO6h11zUSXkHcvXvMdiRcSL+01oPeVbn0zibU+jZ7/wDe8+DMLgSqKcGzVJocDfxQ5bWmWiPig0jUCWd9XCHfDyVFyZnJV9+gxHl6HR5Spxqen3hqmpw2dOfAJTrOGHstAc= Received: from basil.darkphysics (unknown [76.146.178.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id B72811A8D0B; Fri, 28 Jul 2023 02:18:10 -0400 (EDT) (envelope-from tdavies@darkphysics.net) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v4 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry Date: Thu, 27 Jul 2023 23:19:27 -0700 Message-ID: <20230728061930.624540-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230728061930.624540-1-tdavies@darkphysics.net> References: <20230728061930.624540-1-tdavies@darkphysics.net> MIME-Version: 1.0 X-Pobox-Relay-ID: 87A3FEF0-2D0E-11EE-8671-C65BE52EC81B-45285927!pb-smtp1.pobox.com X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772647616244179545 X-GMAIL-MSGID: 1772647616244179545 Rename function DeActivateBAEntry to deactivate_ba_entry in order to Fix checkpatch warning: Avoid CamelCase Signed-off-by: Tree Davies --- v4: Resending. git send-email failed to send patch #5. v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry v2: Sent to mailing list via git send-email, patches are the same. drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 965ffa8b78c2..50362bbbc8dd 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -17,7 +17,7 @@ static void activate_ba_entry(struct ba_record *pBA, u16 Time) mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(Time)); } -static void DeActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA) +static void deactivate_ba_entry(struct rtllib_device *ieee, struct ba_record *pBA) { pBA->b_valid = false; del_timer_sync(&pBA->timer); @@ -30,12 +30,12 @@ static u8 TxTsDeleteBA(struct rtllib_device *ieee, struct tx_ts_record *pTxTs) u8 bSendDELBA = false; if (pPendingBa->b_valid) { - DeActivateBAEntry(ieee, pPendingBa); + deactivate_ba_entry(ieee, pPendingBa); bSendDELBA = true; } if (pAdmittedBa->b_valid) { - DeActivateBAEntry(ieee, pAdmittedBa); + deactivate_ba_entry(ieee, pAdmittedBa); bSendDELBA = true; } return bSendDELBA; @@ -47,7 +47,7 @@ static u8 RxTsDeleteBA(struct rtllib_device *ieee, struct rx_ts_record *pRxTs) u8 bSendDELBA = false; if (pBa->b_valid) { - DeActivateBAEntry(ieee, pBa); + deactivate_ba_entry(ieee, pBa); bSendDELBA = true; } @@ -270,7 +270,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) rtllib_FlushRxTsPendingPkts(ieee, pTS); - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); pBA->dialog_token = *pDialogToken; pBA->ba_param_set = *pBaParamSet; pBA->ba_timeout_value = *pBaTimeoutVal; @@ -363,13 +363,13 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) netdev_dbg(ieee->dev, "%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n", __func__, *pStatusCode); - DeActivateBAEntry(ieee, pPendingBA); + deactivate_ba_entry(ieee, pPendingBA); } if (*pStatusCode == ADDBA_STATUS_SUCCESS) { if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) { pTS->bAddBaReqDelayed = true; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); ReasonCode = DELBA_REASON_END_BA; goto OnADDBARsp_Reject; } @@ -378,7 +378,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) pAdmittedBA->ba_timeout_value = *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl = pPendingBA->ba_start_seq_ctrl; pAdmittedBA->ba_param_set = *pBaParamSet; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); } else { pTS->bAddBaReqDelayed = true; @@ -469,7 +469,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS, if (pBA->b_valid && !bOverwritePending) return; - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); pBA->dialog_token++; pBA->ba_param_set.field.amsdu_support = 0;