From patchwork Fri Jul 28 06:19:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tree Davies X-Patchwork-Id: 127368 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp252444vqg; Fri, 28 Jul 2023 00:15:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlGv7zvh0oki1GOO8FzdLZXD+LYvAjKy6yVmO3j7GM/1fsSfTX4SY8yYExuzqn0Q2yoWVtu4 X-Received: by 2002:a05:6a21:47c6:b0:12b:fe14:907e with SMTP id as6-20020a056a2147c600b0012bfe14907emr1045325pzc.20.1690528553789; Fri, 28 Jul 2023 00:15:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690528553; cv=none; d=google.com; s=arc-20160816; b=D0hgMsL4JIiGt9U5YFh47kyDLGkMmPKctoO/VTCgXaZuOTBG2MyaZP7k3Awy01zjTS wubZzo8yV9Cz/pge0+IUDIX9oeTgXD/v4pkpRkxPr6cYxzxK1u4reNA/yyHfcF9uUXtg 1lYVGuAn4oDZ7Dw37ESeRlgIeMWX8tQfYilN03sKTQB3tSKf3BXJd0zkX9jt0K4nSLEo VdsSr/FtY+Qs08SVSTFuhd4W5iGA3nz3vO1HIeBQyVLRKaI6cIoK+pISXZtGdO0rD9wH M4afJrZESPsPqyfi5VDdR6W2SwIZu0wQc57P2cyW2tsvYxgbab5Wvd6komCYvgGxVKgN D1iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=WvQZZRcKrY9s9Lxyt2h80HK3bt+pUGZkezks5DeVgB4=; fh=I5RbcQPTSTvrwt0yqig+bV2C3roPED/NlXe1P2BfE7E=; b=aAKX1JI4R+7nI6A+3FZtvd11dsHyzUfaXevE5LucyPBa0sB/tP58tr+/EAZmKeNcLg pEiAO05g+ofWCk0LXx2zydHIqu0xuu32HgfyOjDot12U1nNU88N6+4uCTWCGZ8KqlsX7 tGpkMRN8xrYoa8vYHaZ3SouFEnCUuQpgZLr2CgNSXGDgQ8/Jasjl2jDd6UCa+CHen4a3 cdXsqy41L1/t/y/1A8VTvwGoOIasulJ5Si7tOy+n/r3ggxtZvf/Moxfe3ak6trL0E7ke 9hlNkR8NpIlqyJCd2NBSow77zJPR0vtw3kNJxCRWF41IvXGKBQ6BUww8laCbyWia+lBZ xACw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=nqJ7r5iG; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=kzBcCHGK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l66-20020a633e45000000b005428f25f67bsi2541334pga.784.2023.07.28.00.15.40; Fri, 28 Jul 2023 00:15:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=nqJ7r5iG; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=kzBcCHGK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233488AbjG1GTO (ORCPT + 99 others); Fri, 28 Jul 2023 02:19:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233497AbjG1GTK (ORCPT ); Fri, 28 Jul 2023 02:19:10 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E543B3ABD for ; Thu, 27 Jul 2023 23:18:41 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C7D0B1A8D0D; Fri, 28 Jul 2023 02:18:10 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=sasl; bh=6DozYcWGpai+70tN92/WhExeB h8ebB3Bn6oBjVQK1T4=; b=nqJ7r5iGgh1f+ScCotRcI2AYfEH1lDOqAtOR5bvr8 RcFtuVIOd8HhG7hC8GvvOXO2sNK382xruF9HzxuIcwQkx+nLj7LMg3Uv8+bn2P/4 L/8MFdm23+eHd3UZewOCHYz5exSWwoytsWivmSXyjsr8QEyok5+TSylm+tqheJbw 4g= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C0FD21A8D0C; Fri, 28 Jul 2023 02:18:10 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkphysics.net; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=2019-09.pbsmtp; bh=gLP+8ekI4uyWYNGCTV5ZuJN04h5oF4Jz1y/73M9N2t4=; b=kzBcCHGK4YMq9dSe3LQ5S2KLPvfpB4WIqKnv5MC+iUlXwoVky5Rb5pwQzF63OCDFrA4zlDCQdCh4FAlpji5qhWpsig3h6ZQwMvHQ0Z9bgChr4r87eqTTd6mMU+TI7sfQSmJI8T3Og+hge18l8C0qegqWY0q9o16sNTC/41TGi3Y= Received: from basil.darkphysics (unknown [76.146.178.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 273111A8D08; Fri, 28 Jul 2023 02:18:08 -0400 (EDT) (envelope-from tdavies@darkphysics.net) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v4 1/5] Staging: rtl8192e: Rename function ActivateBAEntry Date: Thu, 27 Jul 2023 23:19:26 -0700 Message-ID: <20230728061930.624540-2-tdavies@darkphysics.net> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230728061930.624540-1-tdavies@darkphysics.net> References: <20230728061930.624540-1-tdavies@darkphysics.net> MIME-Version: 1.0 X-Pobox-Relay-ID: 8624FAD4-2D0E-11EE-90E5-C65BE52EC81B-45285927!pb-smtp1.pobox.com X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772647668559890171 X-GMAIL-MSGID: 1772647668559890171 Rename function ActivateBAEntry to activate_ba_entry in order to Fix checkpatch warning: Avoid CamelCase Signed-off-by: Tree Davies --- v4: Resending. git send-email failed to send patch #5. v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry v2: Sent to mailing list via git send-email, patches are the same. drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index acc19514bca6..965ffa8b78c2 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -10,7 +10,7 @@ #include "rtllib.h" #include "rtl819x_BA.h" -static void ActivateBAEntry(struct ba_record *pBA, u16 Time) +static void activate_ba_entry(struct ba_record *pBA, u16 Time) { pBA->b_valid = true; if (Time != 0) @@ -282,7 +282,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) else pBA->ba_param_set.field.buffer_size = 32; - ActivateBAEntry(pBA, 0); + activate_ba_entry(pBA, 0); rtllib_send_ADDBARsp(ieee, dst, pBA, ADDBA_STATUS_SUCCESS); return 0; @@ -379,7 +379,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) pAdmittedBA->ba_start_seq_ctrl = pPendingBA->ba_start_seq_ctrl; pAdmittedBA->ba_param_set = *pBaParamSet; DeActivateBAEntry(ieee, pAdmittedBA); - ActivateBAEntry(pAdmittedBA, *pBaTimeoutVal); + activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); } else { pTS->bAddBaReqDelayed = true; pTS->bDisable_AddBa = true; @@ -479,7 +479,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS, pBA->ba_timeout_value = 0; pBA->ba_start_seq_ctrl.field.seq_num = (pTS->TxCurSeq + 3) % 4096; - ActivateBAEntry(pBA, BA_SETUP_TIMEOUT); + activate_ba_entry(pBA, BA_SETUP_TIMEOUT); rtllib_send_ADDBAReq(ieee, pTS->TsCommonInfo.Addr, pBA); }