From patchwork Thu Jul 27 20:46:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 127188 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp19188vqg; Thu, 27 Jul 2023 14:23:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlFT52uMRIhrkoXi1KGRtOmr5sxvsRGh0Znaa3uhkbgIlVJXGqFYeMPAEvnZ8CXpNFSWW2wJ X-Received: by 2002:a17:902:c406:b0:1b9:f7f4:5687 with SMTP id k6-20020a170902c40600b001b9f7f45687mr683246plk.24.1690493026025; Thu, 27 Jul 2023 14:23:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690493026; cv=none; d=google.com; s=arc-20160816; b=tRGqWN9i99tSeDLT2OHQMqq0D9o2BX0rqFnX7HV4tRw5pAt4IUbmFWl+/oSGySUjsm L4kFfcpwsvnkzHrDQeDe6VIYGF1mizrNTwu7D6gwz4OPTHI5lsVS/Stit2msbHp3LTnC 2pKunQ9ceYafuDdalBR2s73lUaFrBC9FNQn+IMhrgTXD4pm0wIvM7u4N4d7vaK5/cplv m2y6aXEfCvfgnkvCAbZVby/AhhcfOvoUoiWMEK2oj2HRRTNPxIposIZLT5YSyD0p36SC +AF7hxDnV7OPFqAPbijN3goZ43eYU0+WjkDvAuE9OSP8t+T7oYjKu3rnfPq/wcyK9HIc 0TGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VUFHsk/m/GY1eTNfZx8Py//rj4lEwu1OMjpML8i4XiA=; fh=6ywE3cadAEHt3CqWKbi2najT+v0c7si89uhbZ0SfPzA=; b=HdiYP6KiL1xh2qPQlIesGWUGnCbUG0yRpWQQJ7jO+Xft9+3MG72iBHmc744byLuUnD Ew/TB9JdgphibUBv9DMz5BJ7HvU9PswHeYWQsPcGuoPWHvWffYzwb+mkSIU6zh9QftSo GAfVrKg8WEUNRhFMRTv2RrWPcOHpeNlwrxmyh9NP4NBP5/HJtkCoKatAL5PUQjJy68BP fqPi/4JZGd7AK7+FGaKtftCzUlWqaEnNtLuXutxh266Z9m3pYF4nZNyg2k0YwVoh4DbV xR6GfJGjLVDPAuTveoU5xIKzDzncs/eZ3b3yJXCewMNYyian2dn6H3GzitsP8HF8uTcf 00tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=ZZUlyW4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lb14-20020a170902fa4e00b001b896f8ae83si1756607plb.110.2023.07.27.14.23.32; Thu, 27 Jul 2023 14:23:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=ZZUlyW4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231219AbjG0Uqh (ORCPT + 99 others); Thu, 27 Jul 2023 16:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjG0Uqf (ORCPT ); Thu, 27 Jul 2023 16:46:35 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 923272D45 for ; Thu, 27 Jul 2023 13:46:34 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3176a439606so1400731f8f.3 for ; Thu, 27 Jul 2023 13:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690490793; x=1691095593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VUFHsk/m/GY1eTNfZx8Py//rj4lEwu1OMjpML8i4XiA=; b=ZZUlyW4YzysoCHAYMp2/sA6YrKmTeac3t3azsTg4jDgno5140SsxzboZ2DX+sYyTar QBt4NCcbIwVqU6ECOkAxzfNVYTJSA4UoAO9vNAzRgOzSciNduCZzg6hsTy30yZygE/FX Y3IhdC9ei8B4xOpa33YxJ+rAYbRMQmfBhHWbkpR2MzbCVvhFxC5cl2XdP9qY+d1bHhgd lqfn5I8dfHTphHuAk/OGTexXituKKGFsXZtEGV8Pe+xS2H+P9mt/hFkl6RI2Q/3BRFmT 8QbfWy8NIL5JwByXBCIWXDjISwNspvj4RcypyTUIR9HRGShbKOG5H+xfqxUKSelybJ2e i7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690490793; x=1691095593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VUFHsk/m/GY1eTNfZx8Py//rj4lEwu1OMjpML8i4XiA=; b=XGLUlnn1iD+NYgCwrKBTGtwffgNr6WkRbv0VflyZIkqC9iSxHp+mrMKa+L1mFJketw mVA5rEGN6XBAUqxuHxI4b5AjZcVXWXP33T9FmONwd10gEkGiZw+iSfyEq52HZUgvAkx6 1O7hJGnbD90U4ybeRe5UTHPNzBmtYZoW/++QWNLKsYq3bkJOEXQA+4ZyLFi0YNpbweXR xalkJP/GY7OyWKxIKb49CzfvMMuV6xMV61lCVTOfDiP/dS6r6nw4ldDZb73l9sgEupck RfGE36Q5qRBSYLcvdmzbKyfkwhwPCHDpM0N3PUy5ov4O39Y7QBVx2mc6cD+5YJ9HVG1e 7WdA== X-Gm-Message-State: ABy/qLbliNXnrAtc00L9SaqcPaiRNlWyHXfTxAtIxjsiyMVGRo2blJ1M jQJMhG7V1eLcN6MH2gwPWYlEdA== X-Received: by 2002:adf:ef4f:0:b0:314:32b6:af3 with SMTP id c15-20020adfef4f000000b0031432b60af3mr204498wrp.5.1690490792997; Thu, 27 Jul 2023 13:46:32 -0700 (PDT) Received: from localhost.localdomain ([2a02:6b6a:b465:0:7e3e:db9e:70fa:9ccb]) by smtp.gmail.com with ESMTPSA id k1-20020a7bc401000000b003fc06169abdsm2701400wmi.2.2023.07.27.13.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 13:46:32 -0700 (PDT) From: Usama Arif To: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, rppt@kernel.org Cc: linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com, Usama Arif Subject: [v1 2/6] mm: hugetlb_vmemmap: Use nid of the head page to reallocate it Date: Thu, 27 Jul 2023 21:46:20 +0100 Message-Id: <20230727204624.1942372-3-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230727204624.1942372-1-usama.arif@bytedance.com> References: <20230727204624.1942372-1-usama.arif@bytedance.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772610415530992773 X-GMAIL-MSGID: 1772610415530992773 If tail page prep and initialization is skipped, then the "start" page will not contain the correct nid. Use the nid from first vmemap page. Signed-off-by: Usama Arif --- mm/hugetlb_vmemmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index b721e87de2b3..bdf750a4786b 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -324,7 +324,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, .reuse_addr = reuse, .vmemmap_pages = &vmemmap_pages, }; - int nid = page_to_nid((struct page *)start); + int nid = page_to_nid((struct page *)reuse); gfp_t gfp_mask = GFP_KERNEL | __GFP_THISNODE | __GFP_NORETRY | __GFP_NOWARN;