From patchwork Thu Jul 27 18:05:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sohil Mehta X-Patchwork-Id: 127116 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp1314748vqo; Thu, 27 Jul 2023 12:20:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGXuzCvz1sreLAT70MGn8TL44Pgsk0ZqOnzU63LCpaZ62Hfjawlt+RWx2AuixKOeAHuDkwR X-Received: by 2002:a17:906:cc4b:b0:992:33ba:2eb4 with SMTP id mm11-20020a170906cc4b00b0099233ba2eb4mr104715ejb.71.1690485641988; Thu, 27 Jul 2023 12:20:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690485641; cv=none; d=google.com; s=arc-20160816; b=ZGLG+2yTfdgsZJe2QFJ7ZqbkzJ5GcA2zCXDyZsGz/s4RaAgRmZHiHrSmzjD9oxz2Ye qYFpPkfST293gXjr+vsVbGNwGtbC/52+ysYshSydnVlWgTlzAvAnW9OSRGMbGuerlAaF hLZMvqX1nqvhrC6XC7drneb1tat6BrMJHx904Tl1deKXKvLosYXOMMycLw0BtRSlwY3s qDSoRzanfIeOlZhCRA+yugask9UDf/SREUHwFnWcu98v+hNcWwS3IUZDVDP8PRr0cBp/ lkrDhjrsN3do+iAH28LUxEEwNKx3tqrvvGL9bjHSGw6XFwQs0UZH8A894MhjszFqlVly 61SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=93E33ZKfAl5JJkvyPzORYbXlY6B7AsRtnJA2pSsZ5Ec=; fh=+HHxJj+jtdJUKsrKMnpt0SoOHEFfnZ3HUVGrTHJPU+Y=; b=Y+pJpUTW06RWXtr/12xUddvRSefeMqAdDXOebiJWU6rvGRpWxIkgwUTSGIcaRFT8k2 oCQrf0FnZQJEv73gP7r2/i1YsasR81zTpaeILxPwW4p5t6j+1CfG31REN5fDDkHT6vrQ ev7bIPwGAYWDtxm68AmZQKyzkMbz8ZLnM1GKkdWm8/CUTUNy8uMvsnGPIlCfICvVAnlh Pq1eZnz7U8TFnHKEajcfak42DBSFCRMnif+jxoAtUUfRhc2xJlHCDaySWtaSXiDevDuo 0dDppgWqm0TkSTEUqgLXWsMXkT3QxHWVyBmEjQfMAHvXzolE69OonFedM0/pmJ1fSvka lIWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gb9JxKAL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y5-20020a170906558500b0099bc8f939b8si1514840ejp.265.2023.07.27.12.20.16; Thu, 27 Jul 2023 12:20:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gb9JxKAL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbjG0SGt (ORCPT + 99 others); Thu, 27 Jul 2023 14:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbjG0SGr (ORCPT ); Thu, 27 Jul 2023 14:06:47 -0400 Received: from mgamail.intel.com (unknown [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07652D5B for ; Thu, 27 Jul 2023 11:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690481206; x=1722017206; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pNajP0H5SUJ9f+Q1Onyg09lY/pVe/W2pk6K32ziRX90=; b=gb9JxKALS1REZGkMaAFDjgpsW3NvfF0YzytTfFV/dkO+q2XV8cFVZcZE 1lvy/+uRP6S9AKLAM8gvQRp+MkAW7jx/6Nryy6cStYMqYoRdBpQ7DV8ke xd+N610z0p9MQsQQcX+aNWQg6sFMzMJqiXg0Zs3ZTNzg+3SUSzxsg+QZm sO51Dkq+C89cMvBErz2BrWwbDy9F8gaCPVBNDVoHedcFG7Ig2tKMeqMwe bEyalnvN97A5lwgBEdfhT7+ny3X4pghX99e//+/b2ZvcTqTyBc+B1H8FD td/dNMvd0DWWy/4r7rkd2OeaOpc29nMmyPe7YO1X/KmqL7g0057UV1gLE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454760087" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="454760087" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:06:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870523921" Received: from sohilmeh.sc.intel.com ([172.25.103.65]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 11:06:47 -0700 From: Sohil Mehta To: x86@kernel.org, Thomas Gleixner , Peter Zijlstra Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Tony Luck , Sohil Mehta , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] x86/smpboot: Remove a stray comment about CPU hotplug Date: Thu, 27 Jul 2023 18:05:31 +0000 Message-Id: <20230727180533.3119660-2-sohil.mehta@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230727180533.3119660-1-sohil.mehta@intel.com> References: <20230727180533.3119660-1-sohil.mehta@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772602672358442687 X-GMAIL-MSGID: 1772602672358442687 This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it. Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait. Signed-off-by: Sohil Mehta --- arch/x86/kernel/smpboot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd7734b..6a09a021b534 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); }