From patchwork Thu Jul 27 04:19:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Rothwell X-Patchwork-Id: 126626 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp846638vqo; Wed, 26 Jul 2023 21:48:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlHh1FYY7wmweAB5yywkgtToX7dGaKLW5vgHdc9qp4axzVJ96lz0fcjqnZfQH1C7a8oHsUNy X-Received: by 2002:a17:906:cc4f:b0:99b:4210:cc75 with SMTP id mm15-20020a170906cc4f00b0099b4210cc75mr891528ejb.40.1690433332977; Wed, 26 Jul 2023 21:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690433332; cv=none; d=google.com; s=arc-20160816; b=rytbqbJwltwaaEz69qNsJZnO59NP1i2TAk7Tx/f1OtuVVbqOuw8vIMh2pwLTdwmpom aNAhO7JYspr0ysoha91WgyzXJWG4ZDOH2av1fcw686m/UOFg0eOWt1QoWVBZknV8Fzqv qwQhUffd6qaCenOKmoJe37XKmM+urnoRuTjaUjhH+ApycNl0kMirDP50rEqsMo3pTeQx KA6hhzTYat+0iMo1fJ+BNqBcQ8uqPZll77TZUXcPb7KDwaaSz8K3yTQMxzVV1XBGqMXn vpugadpN/fGJrk2f75YJ8SUvqtkxiUQ3aUz8uMXLHSWGz3b/3tueWiTYSnK0+HmeOSy8 yGEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=rI80oRT9KLOdefr5McbBoz22mLySxa8Y2O77k8IeNCw=; fh=wg6AvpX/rdlPs0ZCtObjndBZA5vOg1cZqepDbxFWKNU=; b=ZYRkdnBvyJ2pzYJZEhpA1EnqpfeaxRPmeRlVymxvPWuKflvlYR76dTlBzwCQP+iE83 6Y5mepJDSAl7oqqRB4/7gcP3gEfjMm6y4UvrT+pRqDnOBXUi4awRglhC//FC4sCIYN1x zgCrlDXJRDbMtAjxqTBCXYGqodh9Gqz0Miae7PgcWJguIZkBFNoSaYrlvZ67EOd9dELZ 1wAC2pOo/DOy4zRibvALBOrUmWGr0FEysnAwM729LXaa8PA+HEWwUe+cE11OZb2Ew1f3 aAUHFNqPjk8r8iBXD33a1AHD5cmUbl05ASykLn0z+tlLeBmXoDHsH7HmnuUwfvOBN94N ZHbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=eFvK+QvK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga6-20020a170906b84600b0099280a7eeeasi395527ejb.526.2023.07.26.21.48.29; Wed, 26 Jul 2023 21:48:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=eFvK+QvK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canb.auug.org.au Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbjG0ETk (ORCPT + 99 others); Thu, 27 Jul 2023 00:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbjG0ETh (ORCPT ); Thu, 27 Jul 2023 00:19:37 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30AC62701; Wed, 26 Jul 2023 21:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1690431573; bh=rI80oRT9KLOdefr5McbBoz22mLySxa8Y2O77k8IeNCw=; h=Date:From:To:Cc:Subject:From; b=eFvK+QvKQUleYx0glPPi4wYbOdayXpqK9fZRhis2aII+mtCBc2dtO++eQPmD3Uy/d EOiJthmkNE71HY9YlYA0IJNqJ469ZkI3fhcQSPGh71p2nL2A4KDAP0dZDLuTczhymL PIPgnFLkfdSdrWTlVb79CRg0vLj8gckDfcgA5H5HFPhyPHPNZsh2NL0yMffn4XZWA0 NKakq/ktw5DivQlQmKAFS9wnnIfqq9LQLTls7IHAW9yDQ7xSeTwXveBFriYRb1Nsbz D5QxdTTtk8CZHh8OdcdLtsUIqH04MU98Wv1TnQL2WfsPS0EcTp2D+u7WCdP7Z6IG9e u+OIJdjRwPF4g== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RBHbT08VXz4wbP; Thu, 27 Jul 2023 14:19:32 +1000 (AEST) Date: Thu, 27 Jul 2023 14:19:30 +1000 From: Stephen Rothwell To: "Paul E. McKenney" Cc: Arnd Bergmann , Linux Kernel Mailing List , Linux Next Mailing List Subject: linux-next: build failure after merge of the rcu tree Message-ID: <20230727141930.0b5a3c40@canb.auug.org.au> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772547822546870320 X-GMAIL-MSGID: 1772547822546870320 Hi all, After merging the rcu tree, today's linux-next build (arm64 defconfig) failed like this: In file included from arch/arm64/include/asm/alternative.h:9, from arch/arm64/include/asm/lse.h:14, from arch/arm64/include/asm/cmpxchg.h:14, from arch/arm64/include/asm/atomic.h:16, from include/linux/atomic.h:7, from include/asm-generic/bitops/atomic.h:5, from arch/arm64/include/asm/bitops.h:25, from include/linux/bitops.h:68, from arch/arm64/include/asm/cache.h:40, from include/linux/cache.h:6, from include/linux/slab.h:15, from include/linux/resource_ext.h:11, from include/linux/acpi.h:13, from include/acpi/apei.h:9, from include/acpi/ghes.h:5, from include/linux/arm_sdei.h:8, from arch/arm64/kernel/asm-offsets.c:10: include/linux/init.h:149:33: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__ro_after_init' 149 | extern char boot_command_line[] __ro_after_init; | ^~~~~~~~~~~~~~~ Caused by commit de2f542cfbec ("fs/proc: Add /proc/cmdline_load for boot loader arguments") I have applied the following fix up (I have a faint memory that the section setting attributes are only needed on the definition, not the declaration): From 9f56e539ed7d9c402caa85d4f5f3f8cec8373b2f Mon Sep 17 00:00:00 2001 From: Stephen Rothwell Date: Thu, 27 Jul 2023 13:26:08 +1000 Subject: [PATCH] fix up for "fs/proc: Add /proc/cmdline_load for boot loader arguments" Signed-off-by: Stephen Rothwell --- include/linux/init.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/init.h b/include/linux/init.h index e3ce68988e1b..c075983c5015 100644 --- a/include/linux/init.h +++ b/include/linux/init.h @@ -113,8 +113,6 @@ #ifndef __ASSEMBLY__ -#include - /* * Used for initialization calls.. */ @@ -146,7 +144,7 @@ struct file_system_type; /* Defined in init/main.c */ extern int do_one_initcall(initcall_t fn); -extern char boot_command_line[] __ro_after_init; +extern char boot_command_line[]; extern char *saved_command_line; extern unsigned int saved_command_line_len; extern unsigned int reset_devices;