From patchwork Thu Jul 27 07:00:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126722 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp918947vqo; Thu, 27 Jul 2023 00:32:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlGON/0gNW6ai/d00+WX0/Wro/ybfflpBWQMb7HK+kXq6Y9s5hF2SWA/eP36m+NEv5w620jp X-Received: by 2002:a05:6a21:7741:b0:133:2a73:fdd5 with SMTP id bc1-20020a056a21774100b001332a73fdd5mr3719277pzc.32.1690443145153; Thu, 27 Jul 2023 00:32:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690443145; cv=pass; d=google.com; s=arc-20160816; b=HR6AT3C8CGmHtCJC3R7sQvwm4+5fWEUDQX1MSUwWeHmSpTnMpUMXYCDgrrGIoU9tpW jEm9i06kmwEaiF6fNUsAj4vcq3zvlqY/ny0hm4OYJY01lT0fpOJ5SNZKu96a8DzMLyXV krh7nlMQqzZ3B5jCzb1DcO0Ll8gTo7vcSHRuDVOlMf45Nnm/b1Xg56EEkAIBwYrOCTif zCYDRmcW9Dmu+JDrzRg04sB5HuA6+0/lN21y0zHNIKPdMsuru6TuhnGifBwrn4mgZcgW am3CnwdQABk4rGTShti8WWnIxu7Vd4vg+4kKtng11nAANhWWrT2eu78eZR2+CspDB0x9 Z10g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FXZpNO+3dmb0lnQ8WXsQM3rNh0ZF61gf7J5F6UfMTHc=; fh=DltQIqE9+pGXrPR5WLFAdWiPosppoWjSKQ/zZl2z5K8=; b=E0DYxNEeFEyfO4PBeuOn2GuYPv8cMD9CEp/KrZFIHfKaG5O4s70vEd6kGZbBRcRFql j2IwzqTJYiZdfDgmerGhNLTAGIMCVVAsCi8yLAnflf6blOaBi0HvixXSgxlwT17FpSWj Wl8TT3zDyN1J39cGZetWg/iZqTYT/za/ah8m11tyO8t4A4btDxUPp/hUvSytpushUWPz LgaRssWChmAwe7dURy7lKk9bbyYGLLTyqLviXoa6wdOxpE4YSX27GusBStRRTP29GsgF Fw1oqKKPfBhk4vNFTgGi7MCDfzVgtUizb7FvjKRbpy6vSGWAupYSXj4VWhddAyj09Jzz 1Cag== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=jB7EGA3+; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n127-20020a632785000000b005634b43d2e6si898801pgn.627.2023.07.27.00.32.11; Thu, 27 Jul 2023 00:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=jB7EGA3+; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232384AbjG0HGA (ORCPT + 99 others); Thu, 27 Jul 2023 03:06:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233050AbjG0HEv (ORCPT ); Thu, 27 Jul 2023 03:04:51 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20725.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::725]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F8923AA5; Thu, 27 Jul 2023 00:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQYhB4tsjPc9HPdaHuHpmIx6o0x10O/8xvLIiC0xJMs951rX6v0+shLqXL+IjyQLmBryHGG51fZYnGVprYXVybVsarmCtlLnt8DAvK7G/Jngtere3n0tS6DwDMTp0n64J7aZC/FYXQ65+b+f2yxJjrbsKBO+yJ7JD6XvnFKuGoDc1I2JyezYHBUZYPZhe/m6/fww91cc8Pd2yspNegfek4jCnuz5Xpe5CGUox/4k95Ge3Zv518rT22lyR/kvABhjc9P1CajKa3WBPxB1DLZyhlv2TXalCjB6MPbBFlhEpFdk+8qEgcGiKO0vwP5x9pCg4y9B97itaTyJMGGgCFm3jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FXZpNO+3dmb0lnQ8WXsQM3rNh0ZF61gf7J5F6UfMTHc=; b=Mm1hh4DG49UzQGFE5yPO6cUP0WuUqvtmswJWwzHecWIKzQ1vUDcQTu8CL6jzvFbczd5ttiWyuWfhhbixA1sVBMuym0iPxp+cJAmGnWKLk/prVjWfBy6/U26oOIgXsaBD8Yd0k7g+RC3Mhn3dHQ4taM9WWnhLBU6hi2GbjbHgfWT9HqBOJESaMWRbrIeFe6jT0t0olioP/jtHRs6W7jjNWJuooQ19AuIb+ODtX29A3H4QC5Ux/zjFFe7dSOG0zZ3DO/4ItlqB7ebbSBpT1y41PlM7mFbxRdRRDbFOiwIThwfWsYrvaOwDgMGEorxGFtLPoUErjuz04fKClgF8xPrQTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FXZpNO+3dmb0lnQ8WXsQM3rNh0ZF61gf7J5F6UfMTHc=; b=jB7EGA3+6DdO+UuEIO+yCElpuv1WdFo4D6AkgNZUH+7GgjDSrmQpYYgW5V9rk3lQd020qjulIo1S3THzyF/sZ9FlOY+rWSqVFpyfECAcSPtgDv2l4B/dCIU52cd+/Goo4AZ2BQ7GH3RPYaWpjx1v2c+Kra4l3xN4dzYN4OEPyhn9gdxFoUDACj+iYiud+CHtAZ12Vir4jwHuC3tN93rlYHhVKEjESuFEQrNKrbOqmcW9jQEW4ZBoRmPrJoLr0jWBFbyKdTVeanMciiIZkec4xJcOlXEPuVnScSb99lki+Tu8SNLa9drxmjGrTl7FnhFPCAMzYpSMao6NaCPBo/NmLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB6644.apcprd06.prod.outlook.com (2603:1096:101:181::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 07:02:43 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:43 +0000 From: Yangtao Li To: Tony Huang , Li-hao Kuo , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 49/62] mmc: sunplus-mmc: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:38 +0800 Message-Id: <20230727070051.17778-49-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: 28f76511-c70a-4270-2938-08db8e6f6ea1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m9XUME3szuqM09seQbNp5zr18IQqDqJKjwRN4mCSfFmXd1vDNQsFvF01Cg1VJJsgse9xFp/RWrolBJrIBzdYlFvJ2GvHlr69pc732zqWYSFCBgogpv7G5JGQmKnHcoHsBcJkEtmxbc6OudclXWF6Dv27m8HwdifVIhLnvF6ANSBMbG99mX1w0S/JD70UWiGpTwfaxV5JEzPcv85dVyaAPuW8Upq+eRgcgTiqck62/Dy6WV0wbHqeNvz9ra/73Z6nrwCZgk6+5rDn2fauAHXBPYI8c4uUrueaDmebUJTdKWbLoRO+7R3Bn3BMiVOTyftWmfQoLCgMOrqOWhboc2y92oznxDDudDVhwzc3jCa/3fYonHV0Rw1SmfW4WXQ+fajnHs2A/jeCi5Ry2PUDrpgUKTtz3oFdHW1PKziAPHobPOVgefYzkMaEfY+gVRGgjODWgEu1ldU/BchgDmttm3EWFKT9Ndr4dIPE1tCwCMefo4yIQ9kF38UBgWGr1AQzkQ1bSBoBW3C3EuO1j9tX1bF3BH8fiw3hkI0mvm0jljlESMEhh1TmNMLd1ENnRCtAn093S5uJR0QXugTYuce1P0dz8MX8sWmpQHPD66lnwnrjT9YhPY1VticvALS2C+xhtI5V X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(6506007)(1076003)(26005)(186003)(54906003)(478600001)(6666004)(110136005)(6486002)(6512007)(52116002)(36756003)(83380400001)(2616005)(66574015)(66946007)(8676002)(2906002)(5660300002)(8936002)(38350700002)(66476007)(4326008)(86362001)(66556008)(316002)(38100700002)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?w+tJF83Q9q7dMxx/3uZKC6bTEpFs?= =?utf-8?q?P4HgitphH8PkEMKO7wp83Vu7qbhv2K+Fot35w5tl0+cXxQoUqoLPV1axkAYxyzA37?= =?utf-8?q?rrmEyUcVILpuwIIMsDD05fHS0i/zoa4OyelmwHVLGAZ1HklBrSGyztA5EVSt0u+fX?= =?utf-8?q?zUJqcX91BarebLa+f8Putn85rX1wGeEhbA6mk7Pi5WN6+JFQ8o64GAGjsAu+PulId?= =?utf-8?q?sF5LaFr/OgRqn3jxXbo9NO3OYQkyy6IMbmjXPCTHddK98V2YCVGvmTNLTRfwEmjHv?= =?utf-8?q?99exPH840BYNHUOHR9+7pzh3g0VPVLN0+cRj55QnIU2w2FSq4Ps5T1d7TPnLIfkDb?= =?utf-8?q?/a+WVLJhRQezeAJn2On9FVcwAGcaTaKM0/TX3fVvACOrCMf9I8rRC4VP9v1HCdx2a?= =?utf-8?q?NYN+StI4NpzqdLdD7IFd7j874M10z1a48QIGXpKoNGrtJxANPHwZGwLM5gnFoazPn?= =?utf-8?q?TTvOYHy+F+yQUJMBipfve/y7T9l1AbWsG9eWztfFicYKXc5q7ecNvh0TIrEQZpF91?= =?utf-8?q?iZ1jjLO0bBBszSr5QJSeaifs9hWsFyr0Nn4sdYYU0bVbtswIhZEmNuhpll8+LQm3r?= =?utf-8?q?Az8tgO1mWRsIkXk/HA9fa+sNwOzncUpoIKeebr3x/RniXjUVyZndqoQfBO8NCXXPP?= =?utf-8?q?c0UExUS6AMMCRN7aTMadX8AId/YRC7bO255hl5mtFqa93QUrg2J4RGKShG/dzZUYt?= =?utf-8?q?4Z9Q/OORzZCgjtpBKa+MTz10OdJzOkteIQ1Ez8Poj5mgqqrilF/38uAQJIZqpzm8g?= =?utf-8?q?MqNsi3LMxizX+VRQv/dq50J+9mILhwk9ks/5bM/Ai0GDYwUnzQ0O8CRpbzDTgfmWQ?= =?utf-8?q?LBESl4TIm/cY6cF2CzbSbSdULpUK2uOnr/Blz9b7wES17zWazudQxir43HTSJo4WU?= =?utf-8?q?LFTk3FQgGQ+d7FCRs5w8/M3R1GbDCzkNJCrDEcqo6qqUjeYbUEfd8h9jA89ghcdTL?= =?utf-8?q?r1SGwm5GM0J7eAJAPMnvmKoeAfdVowiiZ/QAjj/0AJQvENM9+Fv8E17u45KW7Ssnx?= =?utf-8?q?Qcn93d1AUTRUniEJVWTZUvO+QzSlWFSvsGwD3qYmRRhk3mIMYngEzC+GwbhHh4WlV?= =?utf-8?q?11BrEij0CB7PchV0D2nYk1XxMc3SkhL04drGOs4/JelFQ5csbrvtIFNaOzxR34b5y?= =?utf-8?q?WeXmrFD2jxJvkN+7cu7WYYzUh9jPmNxHecHAdXAJGV6yc23Q2FwoDaCw25kqMuD56?= =?utf-8?q?jPrcsUkqBD+qiVmNzXCOLCV/kMMVi31hVRBozor1x5nokH31zauLSsXfhjldm8KlK?= =?utf-8?q?gYlmXIJw2ZZhs4nufIxxtybJwFQpWZcapGyDeLt4x3UXg7AB+lXJt0W9iWF/0e9hC?= =?utf-8?q?aC9lbvAsB4zXINLBC2kBHdtUQY/ACCGPmflwtIm7XWGvEcveqGW0KwylrNIAUhnY1?= =?utf-8?q?ZPXALnrkBY8PL5mKOKclHuYn72mteYHVUsKVIdm7baRFWBbg4cRVJ4eW3bzR/mUcs?= =?utf-8?q?ouT/bwHjnoxDMiviaRF68SPACmrd4EAuJsCeSC2Sjc9AIaJj3bwBHiP/8wZfbi9YA?= =?utf-8?q?QEp5C9tI+0wN?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28f76511-c70a-4270-2938-08db8e6f6ea1 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:25.2964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jE0FBfdW1sZ9P3UAMt92hos8nO00lyTGfn5acWmdggWgK16/3peod/ZMGQyXc0W4DQseexsX5+vWCmgZKQ411A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6644 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772558111048216056 X-GMAIL-MSGID: 1772558111048216056 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sunplus-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sunplus-mmc.c b/drivers/mmc/host/sunplus-mmc.c index a55a87f64d2a..2f30a683a17f 100644 --- a/drivers/mmc/host/sunplus-mmc.c +++ b/drivers/mmc/host/sunplus-mmc.c @@ -946,7 +946,7 @@ static int spmmc_drv_probe(struct platform_device *pdev) return ret; } -static int spmmc_drv_remove(struct platform_device *dev) +static void spmmc_drv_remove(struct platform_device *dev) { struct spmmc_host *host = platform_get_drvdata(dev); @@ -957,8 +957,6 @@ static int spmmc_drv_remove(struct platform_device *dev) pm_runtime_disable(&dev->dev); platform_set_drvdata(dev, NULL); mmc_free_host(host->mmc); - - return 0; } static int spmmc_pm_runtime_suspend(struct device *dev) @@ -993,7 +991,7 @@ MODULE_DEVICE_TABLE(of, spmmc_of_table); static struct platform_driver spmmc_driver = { .probe = spmmc_drv_probe, - .remove = spmmc_drv_remove, + .remove_new = spmmc_drv_remove, .driver = { .name = "spmmc", .pm = pm_ptr(&spmmc_pm_ops),