From patchwork Thu Jul 27 06:59:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126721 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp918109vqo; Thu, 27 Jul 2023 00:30:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlF5Q1zyDWe4DC9jz7Ir695QHQ8v3ATC6IvP7gvZEahcVCN4PUUm/2TVgPlj8qy7RbomPriV X-Received: by 2002:a05:6808:b08:b0:3a3:c64f:342a with SMTP id s8-20020a0568080b0800b003a3c64f342amr1935397oij.34.1690443037596; Thu, 27 Jul 2023 00:30:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690443037; cv=pass; d=google.com; s=arc-20160816; b=q2AVxF3heK9I+iUYmyOOklaFIrAuZEcQgQHuONOQjFOcvC/2G0cnw8RQHdNwPU2wje M950ewSa6PkwL11npdlUPwK4aZZ+1LTUWJOFbSy1s5oQIvLZd3jaSJEgmlkw48osKgJR Oj4n/3xkXjVqmB7CYQaGLzgbq8WJKWyf2rdaPiwupyHWMRm/bMelVPPvhBvMQ21gKOv8 VS+G/nP/YiiaBoljnZRqWIEj2/jBZBlV2wbPB7/30KjbEIW24pZKEbPzgTkYbDDACpCv RpITow423D9yqY4UWGqkvOF2N4De2FBFlQa/6chiT+mXpFn80Y0xpNz3RuqE3jI76GYM sLCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vqxSuEFdgd7k42jXTQq9t2x1NA379+lBETFrgOHf+Eg=; fh=RRst69AylAmQjTenUg5G1MIx2YhIHWYClupGBxgNKIA=; b=hexWvn2b2VSwPA80qYCulzbAMyWY2cCmRNTxG0bxS8IAQrdsO777SRDluR8T3GLz2j 0KpU69OSMYqSEenDoDw5ZwqWC8R++G02fyoL6HlUCYs4PZIzO45Q/4ULeODyXW10oZmT 2hAFqUThWpnCgrpnxwgFValHJTBpf7SCRQ4Nght8d4CqsGQNhKeQU+hAXY/kvjSScRdW vIxDAiUiITmRtXluiqFL8ItwabP2+FnSBZT7kvbv7f1UalnSURf33csdBitY4El04kej 5/otQjVOjRaIWnfLvJSEO7nqhy3StmelYO7ejitl0Anh3z47uh1gW/+ea1ZhWrRD7WmO ybXA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LWifzvir; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f13-20020a170902684d00b001bbd0358ef7si892035pln.518.2023.07.27.00.30.24; Thu, 27 Jul 2023 00:30:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LWifzvir; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231822AbjG0HBZ (ORCPT + 99 others); Thu, 27 Jul 2023 03:01:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232797AbjG0HBO (ORCPT ); Thu, 27 Jul 2023 03:01:14 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2093.outbound.protection.outlook.com [40.107.117.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F08026A6; Thu, 27 Jul 2023 00:01:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N06pxx7IxGzgOyjWQ8Ls3LPOc5iRlJprQup8supgKT12d/Rk5Of+HG0+TIL/3kOHxK/PzwVY6HSc/WZW1t4CdT3qUHbiAXIps/uS9VJXKwttLa/2nUu/D86wAZ3iMQXmpt0/2X2PjsF1qQbAAykDyYwMDBGrwFlZ90QWleueBCa/d/PYhd66b4GY80u3nqaEx1W9RU75RkVEGd/MwTts/XOfWP/GGen3po05K7NFwV3pPRVDOCXhsV8Cx6mLwDESZiNbgam70CNTFywYC72qQoh0mkWPm6MlkuCXrPN9HlrZ/6sxxs7/FgSqrHkiODdzlS9IcvxslBngDtMkHrOhVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vqxSuEFdgd7k42jXTQq9t2x1NA379+lBETFrgOHf+Eg=; b=FmIM5DcUzWCeqpzCET8H623NyFUs2QQlzuwIyCPYgNTjip5shu/z2A0ZwYZKNTZXNhGwepEYCLNAje1Dt8W4CYxW7U/SrDk8wn9KBY96jztJR/xgbsENRKRlshCyamkqCSzga0RxLBzctfXwGMuhTN+Mae45VZ6NIEHayuy6gMsMEBdlOq2XueTRaZnSDqW8VY8Q4ZpLSFj91NOhsKPF3Khya/3vgnD8bLfYHoCkw14Eu6piZbWDA8AuPTtQc8wzIj+YASkVY9NfZXjKAskEF9cPcD2Ns5W73al63nLC1G1KUwOE5v/FwhxClQA9lIQpnQhha18blsrjcISdoP824g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vqxSuEFdgd7k42jXTQq9t2x1NA379+lBETFrgOHf+Eg=; b=LWifzvir0n9+J2mou7SRy6nFjthnQjsLYbB8sdXek0945UT1afppTJ1wcQ+oSVhbdD2NYhkvTu2WkTp4WCJntfR2OqnLLRP47OK+BtnhS/PtI24xTmbVF+9MW/WBYd1G/TSAJz9dJVQbz2IUKKN9u2TaacfM1iMkMeuahQLPdB/z1/QcPIqITKG604pLR6RfMljVHQ9MdbmKjW1hAKp0mBoPJ9PJpFMS2Q7Mv4BIz8NdWatI6/U9I5mnL12CDhY+Jc+qaYuV5yB20iaDOKZZa090ndZ9RqY20mnG3q92xWCvrYjZfT6XnpOZCg6e/xK6dBKknsryMynrcBvKLNF0fw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:07 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:07 +0000 From: Yangtao Li To: Paul Cercueil , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 03/62] mmc: jz4740: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 14:59:52 +0800 Message-Id: <20230727070051.17778-3-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: e1b92eca-30d9-45fd-22e0-08db8e6f4023 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RRVeuUsH71GFGQW8I9Up1WJLAboej8bJ7BQDZa095tgDwq0K2huYX9aCQPsPRpaJsdGjg8VZcM+7zZk/Pfqre0KtpTxybjHNL3p+T3b2n+/mOS4A3XhYbSeH+0Ou75OrTcAcaOmOWrSIfT6g3dNCU9QXjti/ASRLUYnCQIWbjzVUmn/qWAGK2/kUHqpWInQ4j5QJ6ik/bOjlMk3+ftIlMqSU3p+o14xkfiVLIsZ9Kl7MNERg04YNVbbke7ZVHY3HE73BiBt6SPTs7OfRkas85liWQ7RxiNruugYaVIttwfsivmPnfTvhbeYSljWXgOwqP0elBsbjg4EdVN9G6ZcS/g97Kc2OiUFjct9fNbH9Gv82b22lcODrM8F+CdY+/3KKkuQjwZDmBBqh0/GipWhpwZe9ZShk433FlZNuowSEto2ASl9LjQWSSPtUeNDj/uEtLdcFmz3hEYagIVMQioJ+USjMb64oJEV8ZeyAyU2Wj2wUd41gcD5qubwyRTqTlwyJBQUtFv0r8Ka/kF2jjJCZWvZBeoVbEGrWmOLL4hm2MnjuAPVd366nW3Cq6t9Pq5YbBk7+Pzi1+HdxfoSVEKUlU04G+yXUzID+AflxGwuOpPr+/oNl2vYh0fLrGUb2OmWr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(66574015)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?31cpRyNIZA3qhEXJAMwE34BdXuAO?= =?utf-8?q?uQtxHmj58GBm8I97FLdboB7KKkU+i5/vGjab15NX8tmYUX7SvX8OwEQlYVR22fmgf?= =?utf-8?q?xM9eSPvLxY1/7B79x5ODImCa3IWnv+4yXq78ZATK7KY7qaSlN+EW9+wbKNYDSmtN2?= =?utf-8?q?XuSeER+/4CbHlrVktG1qHHs/IAz6AFoX5E9EE3OAgsswVBsLfns+l7pGUSZK9Y45W?= =?utf-8?q?+ifuMs8MnsTl5Wol/S7L5/tNNEmYCXOEilRRtgjhHiZTBeKKcLumKahNa5QpDmEPA?= =?utf-8?q?85PnfzJgqp5eEgzNoEiTiaNelcTEIJPVvNImjsSyjXKDloPlDbRWCTWUC3JU3l41p?= =?utf-8?q?p6WqeYu/dernUSk7y788yxHYQsN9c6+wQCrskQi/AHCCTZK5QygQ/K8Nz2HwC0prc?= =?utf-8?q?JMDSnCf+32PqtTQBwjW4EwuGFYdTzhRNLRNJlqnOAsZEZQMhkYmSNJ06Vfy366PyW?= =?utf-8?q?QnjCn75PUeAYhl+ZVVmddVbyNGzdPbTzrQ7CNx53UvKGbUQXZBxYt7Trzj2RMFe7+?= =?utf-8?q?QA9e8worQEOXstqd0pJobPRC5hACgEfzdhj+HgtwrKWq/K9nk11dd/zhtoQEIUzlR?= =?utf-8?q?CH5Xkx5+mmKt00kopkUiWs2XsKMl0FA1lqfD9nTXshaWt9HDtLNGKH+9uzheBp/Ng?= =?utf-8?q?FNiRlJ1ev/RMaRDbtFUfgb+xn3QrNbMS3B5C0+2A60INAQI+y6aqlzf7jJocSNwwW?= =?utf-8?q?v42+hSOnQbeC1fFN0NuEFTT05oVqWQoP17l888t7Pn6UCvzN5kOq9+Dyz/rxlOikl?= =?utf-8?q?IZui/7XpkD0zBbTUy9Tk8P0jJho/F9AEaOC78/DmW78S5UP6VamKxZAZZnKpau3Xe?= =?utf-8?q?ih5UaWSLGsr0xIVITPnPHsdbEl1IOF8No2dY6rMOGq8fxGkcMGq7kycmidtBH4iRF?= =?utf-8?q?uma/5iI+8WV4/puExxTOsTywwCK5/CgrR0BV1avTa1GBn6v8YhAwheyUWDbOzmPal?= =?utf-8?q?Q97GqVwBR4T/f0+o8wD5NKavZsMScjn8ggN4ZrsBUDTErnqu/rUVTI6EwT7Uri1Zx?= =?utf-8?q?igbU7HWcL/AE5KdKNQz5Hc+pPxIvzz80gjUtr6K1gxdsPT9N0xmhDaSmQSh9y/YmN?= =?utf-8?q?e0rXqjkYyoNXnyEzexo8wwWqavjc3DhXTecKKvozLyHhOEk0MDWFNCsEJCAe9Ghu+?= =?utf-8?q?JtJcNU3vcKMERzNkXYNSLlEEC8kbS68izKOBBMDxHO6Qmw4AWB1q4yBCOdQoWkaKD?= =?utf-8?q?gGKxjS4A/RZRDbISBhYXL04IQIk0rXrBaPO073K/LH9fx2pEkQc5Owh9Ubif0zpM6?= =?utf-8?q?OFsoV8B/rrVEzarOMiSUzVyqtuqia562jiQMmfMgbbYiHIQj3QEFvCP3fdsZBVItJ?= =?utf-8?q?HDJ19OQntvXkMOExQ/u2iDsrEFk9fXJrxRz6hZNzsRGiVgBZf8OG8QPJqA2T2/BsD?= =?utf-8?q?IUNp0BDul6KiOS4TvYwlks+cWN68cuP+AD9wL+ExT8nWyDLicmTaDWMOKcP2SKTgs?= =?utf-8?q?tJOvwEN+82Ylnq7gf4XJTJ9Z/1Me1cnFHtJgQwc+8k2rSnMQ/rppT44IVOfPikqGR?= =?utf-8?q?7ph0J4SsUPdk?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1b92eca-30d9-45fd-22e0-08db8e6f4023 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:07.3067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AusrcPFAqoJlZ9y+FNCuL6cPLCQPXPTLhouFrvOxIcE7lFmvP8iEGV78MusOqIIeJc9TLxrm4NUc7Q7IMJddMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772557998610712578 X-GMAIL-MSGID: 1772557998610712578 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Reviewed-by: Paul Cercueil --- drivers/mmc/host/jz4740_mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c index 1846a05210e3..f379ce5b582d 100644 --- a/drivers/mmc/host/jz4740_mmc.c +++ b/drivers/mmc/host/jz4740_mmc.c @@ -1163,7 +1163,7 @@ static int jz4740_mmc_probe(struct platform_device* pdev) return ret; } -static int jz4740_mmc_remove(struct platform_device *pdev) +static void jz4740_mmc_remove(struct platform_device *pdev) { struct jz4740_mmc_host *host = platform_get_drvdata(pdev); @@ -1179,8 +1179,6 @@ static int jz4740_mmc_remove(struct platform_device *pdev) jz4740_mmc_release_dma_channels(host); mmc_free_host(host->mmc); - - return 0; } static int jz4740_mmc_suspend(struct device *dev) @@ -1198,7 +1196,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(jz4740_mmc_pm_ops, jz4740_mmc_suspend, static struct platform_driver jz4740_mmc_driver = { .probe = jz4740_mmc_probe, - .remove = jz4740_mmc_remove, + .remove_new = jz4740_mmc_remove, .driver = { .name = "jz4740-mmc", .probe_type = PROBE_PREFER_ASYNCHRONOUS,