From patchwork Thu Jul 27 07:00:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126750 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp922315vqo; Thu, 27 Jul 2023 00:39:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlF2hUr9LGysrFaqchLQKvylv+vOwUY5txM95AWCpVSRaI1ITeTZh7q1P1nH1ObbhgHODuj8 X-Received: by 2002:a05:6358:9219:b0:135:4003:784a with SMTP id d25-20020a056358921900b001354003784amr1829999rwb.19.1690443584649; Thu, 27 Jul 2023 00:39:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690443584; cv=pass; d=google.com; s=arc-20160816; b=jLLIMszO/DNG5icefUbY5YZ1rqbcxNVN07XIaDww7GbO+g5xmk6Tq8slwKNNtA/bEe 4HmOcctIN/o+LbJlPDOfWk/fqdnCkSMddX44r0luI/DJRqxU7edzLtCEoMD9+Osgr53r lAe2l+Ztcqu1yHUCmMfHRwHuTBeMXqIkk9aKLGRjoBPI906T6xXU2Q3wOgk6JXZUHpFJ Wz0cL7CH5/E1q4tm59RhqkEQ4b7rW2xlSjR453penMEQHjMEwFqa6aNDZUvpF6g7L57O oWsgXboDBkoqAX+7ioUmxEUDbOmwvt7KPnAWBi2xdKzj8sl6xQEAgX4MSRF2bxAK40Tt QO8A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YnEm4eeaXUww5eDuPQKSh3EIaMee7cr4msQcxUd2bqk=; fh=KaHw6wvoY0nORQNloGxgAdG9EQoKCtLTTxL7ZTkIt8Q=; b=smtesYu2ie4/zYlgs2qLT7IRvMnUhoeVbuXJFo4zmgD+Ok62pqxD+TXGiPBcmKXzzN yY0uInpZddLv1ksyFM9mbqwrFjfmv9f/pdRhX+aCkI3pAzwj54nn0gt9OB16q9MoLB2V z4VF0jYoj3ZVQiEncicjGtI3Hv+vlZMDDxU3+AMGej424mBGJuceVkSgW/LwSBSofEWs 2YTud5wZ7IfgeK9arCGVnjA55osae7kqy3uncCiXtACDo//Zsn1BCyn8j3S9p7/nVRyf F/5isLAijuyrTewNW8dCIPOCbPtBRf9qmFFpKbJk7C5toOCCcnLo6iFpHN2aL4Tl0O9I 0Edw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=WD5kf8K1; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a656944000000b00563d4e61773si834064pgq.812.2023.07.27.00.39.30; Thu, 27 Jul 2023 00:39:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=WD5kf8K1; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232787AbjG0HD2 (ORCPT + 99 others); Thu, 27 Jul 2023 03:03:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232133AbjG0HCv (ORCPT ); Thu, 27 Jul 2023 03:02:51 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2104.outbound.protection.outlook.com [40.107.117.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82CA426AE; Thu, 27 Jul 2023 00:01:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Maf8scFMRz58zsHamLKIVJ1UHN7aAfec4z7+lCdxfNAoYK5ceYF4c6W3//mP+eR6INrPK8WxnOpreC0eZXoSDFdLVJ8cE74cxiN+SBSJ+heIAGhplFezBlM07gHwFDYMOU14x6hbgE5il1590KzDUAf5ywo1KeDndOo392xTCPCk2ZKN9x34QLNuihaQ3B/Iu8V3ilz5znP99ThnXGPcnbJqZhWTOLcygmNX5Lhw304AH4XiV7TT8kK7gVvx+vYBIdlNrz9xajTNw+rn0Yvw1bVQltHkhl0lx6p0w+p/z91f23GDeIJf1ryuFeXcurz2CWiYtY5fBISeNmuxR1dv4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YnEm4eeaXUww5eDuPQKSh3EIaMee7cr4msQcxUd2bqk=; b=mCBl3vwlixRtymJsJAGNcylwF66NTobmJEtffE4OQWnHBLr1tHmgf2aY1WkaTn9BhO+46AZfYEb2PDA1kw160N/azZtCoq3l5CRm+d47olVvtvbRAfMGYNGIsmDJkRufBwdIiWIvXclkO3F7IGzxzqARo1WylINNM/PcHrazoZvoT5BvihSs5Zw0hka6kxa1GNg8o60y3Me6ZsbZE/MY7WGdw7HxYG/+5aN61LTnt75z5lwG4YBigArNCnfK0RSjD7IoC8ALxNFTscRFMVTeWqbMorPBVNcCqL7Xdj0TqRHPj774VtFaklog/hAqNIXnWJpvOkz6mvRRkezb4aEvyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YnEm4eeaXUww5eDuPQKSh3EIaMee7cr4msQcxUd2bqk=; b=WD5kf8K13FJaMws5FU7HZ5YfNmRj658WPEtPVif/AyB74R8nk3+l5Rce92yhiepQ98fNib2lmwgKZIz1YOcuGCvTR6T/tlMrSXtkw2Q5K7sNaJ6BVRr1pZGuCDPzPoQzOxQ51VayIKGGmyvsDW1e761wgKEAP1Qs07HR5wGdmdgVPcu8NqH+L6fdc3VC+0vsG0ZzkSDoRrQCYbFg/0SL56jkr4wbEsksoVVvIP4BJQHuscSvApv3mpbmTg3ZCG0iDq3mYygXEDWamA4Dwi8v8VFiDwi8dtX9R+18cXks5RIUv1ctU36o2e0dFziQInc+WIXQx13tqqJhBXvLd6ANTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:47 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:47 +0000 From: Yangtao Li To: Manuel Lauss , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 27/62] mmc: au1xmmc: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:16 +0800 Message-Id: <20230727070051.17778-27-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e47b5ab-dcd2-46ca-2537-08db8e6f57d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23zHms9rPzA/krfBl5bpxKzIMgYbE6zRgrxK/WASAddevcYdp087pvdQo6B8EncpA1WmTU1DSE+sRfnOElAxiJ0bBOZtyW8/3SL7EN1TGqLKUCJP+iyMfeGjYBWAlX2MC7OhO+e/VdeFSwlILOZbV87fvXyPlqpZOxJ5j1nt5zBu2k45HHrUNh15yYxd1ZGcygJQjl2iXNJu6wX8GLK+ldQj60eCaC1J2nt6fyC8/14VpAus54EThZxtOByrrIniGTYaVFDlFpcFTqm9mbLBc/jUjTqaROI0m2HktaD+oz8qs4kosmLUatDfW6Te+qYEsYbJ2Fj+gdcrXl1HsOLLZ57OVbz3GNZgTMbHXBp1tDg43wCsJ6I4GubSm8jwKlWfc85HkXBPjaLdf82BQ/4GHCSGX3WPBwE1XbzuVdgQLiaSCT3UPX7U4pxMj8lHWCctzjhLuMf1VTS0hQU/iaIk5jdgyT1lH4oCbPn51Dl/KP0vLJlqLxrikqty+/o0QURMvtYmGviIrjvydSnhokYwV+qgBtomG4/8eIfgi32weGD3NiWDX9FF17bDV3EOAieWRuoGGMU5v7Jq195qXZZ9n/qheg0RQ+ffJzJiJ/AwuWWpLJ74usZifWnt7FgSmLf3g87hKynhtLu2x4RnXgRvCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(66574015)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003)(32563001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?MXCgiP8zuicrmU4VCBWxken18kcE?= =?utf-8?q?43/rqdRw41gYe7KDDvvG2R+x3MEyirD/f+oGDWnQxkU40oRl/s01JvFxQEw1Gb/R1?= =?utf-8?q?nAgI6gWGDDdQbnaKujgT3hA78tmBwR0+BeW5TYnXQ3NEiYzR+WldA3kmbn0o4Fltv?= =?utf-8?q?1f/SRAo503rL2086b9d3tscxFnVrIUHncYutag243HYixYCg00UMgCdD06gVfRK9f?= =?utf-8?q?hiRxR8awcJy3SiPi6mwqAly9+ywrXx2wV7Df8krPJ310GDeGECyX3LOLT33E1DmfK?= =?utf-8?q?NIxVn7HpnbOmrW3CHtI/9END0anY4O7yw3QDJk68jrxDPfTUJUB7LHHiJxcZVDB7Z?= =?utf-8?q?CJvFOc66RwGQ36SheUQ9hysu0v3NGV9PW/Ri6n3ozjEUyy+IPmM5myDLFbTg2Joh6?= =?utf-8?q?7Y6RE6E+b2czCQJT+1CFqAQ9kW9Gv06K0m6/6RFHqt8eoYZSDBKy1DfMwH+psRP9q?= =?utf-8?q?ZDpWIR7rARg6z8HS8vXlfld3Ce6IyqWeY7u3kMZ2GHuDUpB/RTJTPmGlCrXmgse5B?= =?utf-8?q?J4W/8wp8q0f7iW7s0uqPdgSEBBCSMEsXPFNFfZ3+jIaBHkP9xQ49jx2KhBiz4cSN9?= =?utf-8?q?wBmoODWzwD29h+6SiA//Mk98Fnox7AguQraznwp/ppYnYpJEjxmgMkWjwxehFpFid?= =?utf-8?q?N0kHU2N2opmEmbiki4bholfICEtKOmCkIS73L44L6t3HuVaTiM8rJjHi5/2jfNpui?= =?utf-8?q?0thXZipHw1crroqy1Jnwcr88eKq/e8Lgikd8FlTmOYtweLXrZUz5YyRi45meXcIbn?= =?utf-8?q?K0NHhDGEsrtZ+RAfqTFtt3OHOV0JIe1Yag2+AZtCKVR+wcR23UJ00+2nhoSt7CpgB?= =?utf-8?q?P05PA1YWEcceNjkn4Khh1PvLQfX3J8NKQWzDQ5ZYGXUZVjKR5e+7+mbOJZgSpTU5g?= =?utf-8?q?i0B07I2zTBq/pDQ+7uyrUlq+ym/52KY2SK1DhlVN2hDs7Xc4zU8v1jWAU/1rKOYBf?= =?utf-8?q?pwbTZVhySyKOxqX72tHKCVUiIvkad66f10gWcIQSO33Uu2nFvijLPNbrBiAADmsKw?= =?utf-8?q?kzAevoQVzkmBtbtgeqIRMtzkgCB5tCJST694yHv6/WN6xstRG1qNtZwWBEfJLbYNf?= =?utf-8?q?Tqx8VWW0qav3ehFK/PKS8/S17LpNJArzyHlDxDxbCRq7Bae3baEnAiahAJp/Aw3l0?= =?utf-8?q?f7RLnnEOBpk58iAVPCR5qu7LyvjvLBuuz0x2x7sPy7Ql5tKlnZwjipkQumq1RhfXI?= =?utf-8?q?8SDemwBs7dNh6Qs7XVW8TBWLPSsLClOeRPHNTY1Nx2DYMQDVDJKOxKXmy4BQ/0vVT?= =?utf-8?q?fYoPDIf3kioj5w/gkh3kg/eMx175zKwPhRdxLX29pVE3/J/I8K08HAWPUG0lrz4gv?= =?utf-8?q?+9qrwlG68Ossz+uA5setjy7DI+ApfjF9Y/bQZ3/J+QmTllEBZHglEIcTKTwbr7Ke7?= =?utf-8?q?4YqWsYRw89jTcJmZ+sWkMbBTowE8Hw/FqQLX5VMgdMLFlnzwGtd6PgFS0xwyqDF0k?= =?utf-8?q?Gt0EfPXscAF1dJ+bzZdqosJrTlCc9Cbt/ntORxvo/20ObxYDpoCf2lRp5Gb+kuGPI?= =?utf-8?q?2wbmEEApYo1A?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e47b5ab-dcd2-46ca-2537-08db8e6f57d8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:47.0576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e3zkVkISmWyteOi2ZjdkfAqAL7oVwhEpHmFVv8GlBs9UEcKPCeeCEUwbDiAA1PH44JuinlS5VhsOi4LEw0C/zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772558572233622661 X-GMAIL-MSGID: 1772558572233622661 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/au1xmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c index 82dd0ae40305..b5a5c6a2fe8b 100644 --- a/drivers/mmc/host/au1xmmc.c +++ b/drivers/mmc/host/au1xmmc.c @@ -1114,7 +1114,7 @@ static int au1xmmc_probe(struct platform_device *pdev) return ret; } -static int au1xmmc_remove(struct platform_device *pdev) +static void au1xmmc_remove(struct platform_device *pdev) { struct au1xmmc_host *host = platform_get_drvdata(pdev); @@ -1153,7 +1153,6 @@ static int au1xmmc_remove(struct platform_device *pdev) mmc_free_host(host->mmc); } - return 0; } #ifdef CONFIG_PM @@ -1185,7 +1184,7 @@ static int au1xmmc_resume(struct platform_device *pdev) static struct platform_driver au1xmmc_driver = { .probe = au1xmmc_probe, - .remove = au1xmmc_remove, + .remove_new = au1xmmc_remove, .suspend = au1xmmc_suspend, .resume = au1xmmc_resume, .driver = {