From patchwork Thu Jul 27 07:00:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126791 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp940697vqo; Thu, 27 Jul 2023 01:21:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlFPhmUJQ9HFBk5pIZRNNcWhpT9NGTE4LxqTcKG34U7Xm63cyHlwjC8S4TEJE88UivCIXwcX X-Received: by 2002:a17:902:d2cd:b0:1b8:b564:b531 with SMTP id n13-20020a170902d2cd00b001b8b564b531mr4280725plc.60.1690446061721; Thu, 27 Jul 2023 01:21:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690446061; cv=pass; d=google.com; s=arc-20160816; b=Tk5X9vWfZI6XPUt6xVOwB0c7xLrly1iwQJzagWwxo1p+lEb5Gfvf81xp8L+xvIAVKX xOhNdQn8xPF1sx3gzW3qrH3QPaxw6ERnLUFzpCkQgC0hQ9Vk+auS4OCRd/mrlMo4lcYb wJ7o97NjOt+lo1qxenR/VIM9yW6dUPWz6qFQC2//XeflOFJyQdGdrjIwBaN/XDQr9ywF MXlRzGkrjBB+OOm15ZlQ42a/saUyMHnct3qlJrIArblgeIM9aHtHeQjcSADy0blmJA3u oYaDVYw0JAouBCZLT0IlFq2zpm3prIeXMxHpa12gsJX/GMvjE+2p0ramlrhy6Eyrl4CY /ofw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NwbBGaxbfpdU7ahifnwy37RYBYAlU62pqhLf97cjF/M=; fh=asOA/2SFqtoNY+Q8P0womv0lDtiAw4HOrb9T11e0REQ=; b=MIS6x3k5oZvUAWYwacaHtlM6nBUS5x8DD9KGFEoZdU+uwBfxB9XhbtJA8e8Cy/88Sq Z4lsNcCmUQwRgLZZ2IjZPqPwwUWjRA5G7LIDLmWj+8XL424px8tVMVCqKvgsZV+wPoj5 pAlWHYxNGEeSGBprnGna5twon3ZL1jrIwyih25M6hEL8TvkWfd8fi6Fk+/jJrnBz+VUD X+5i622nUnpAcoqfoJGYyRECuhd2ODt5lT8goWCKbtT/vNJTj41v1AdET665buGhE0jv cAWgOQ9EXDUlY9YxDc4r3UhLeKwpFeEqqGtVlP2cGI8fB+ACIiVtxdmtejFuVZhC1qNh fRUg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b="YnWL/TYB"; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d9-20020a170902f14900b001b554fbd66bsi886934plb.472.2023.07.27.01.20.48; Thu, 27 Jul 2023 01:21:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b="YnWL/TYB"; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233046AbjG0HEa (ORCPT + 99 others); Thu, 27 Jul 2023 03:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232956AbjG0HDv (ORCPT ); Thu, 27 Jul 2023 03:03:51 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E18E30DF; Thu, 27 Jul 2023 00:02:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=El5GI/FID4kj13Lqs37Mvf8hdiXhowWrjHmbvK3ibwFnGHBsSETzZ3mRKqaYWknZwTnLRFkvMpCEko2ssU4+0qoyRIrh9f1FsjoBLfzyAjoxHjPTUMU2/j7Wp9geSCwZDcHfy4EHyvbnmKPDMZSXWIN8p/xpQR3BjnIBWESpY+kwr42csJNRkRtR8DB/XcdB9xV6M75XQkWWov1NXuRDPYUuuThOYvx0g4BSnslPGiiWBrwHuHZWKy/CClSlYdBB8sPbctZYDVgHTJhNlThIfH6PsVSs8MeLJNS6U4lBvx40uGZTIGxivkvgXxC0+GpyA69YjwATCiE0lF1Wu06Rvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NwbBGaxbfpdU7ahifnwy37RYBYAlU62pqhLf97cjF/M=; b=lzcELnG9he/7mNylmxp2wmDugoIjVtsrBZxVB7oERMnY0HBFI5zpPmZW7h4SkVhhicCBJDoVJb4X4rl38nD4kXForciv0MaShS6qf3wDRJQkIdxdINiNScHUHfRc1dCLiPbcMFbE2MvNgxBfRQYTBZvEv0i0Kewe3bXxbWue+SQ8vuwblr66SHHGLPcL/0T7quG8ufqAn6mExh5H4+7o9bAPG38unzY+uB4EP9AOxGS6iixJluPMXkMlKn2N8ouJOHjnWAI5jberrWy6gTMMeyyogO0u1nFuidiiXfXTGJD0eiEHD9eggEjJOpxVYc67AKn+xu8BEkYiVQTidOyucA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NwbBGaxbfpdU7ahifnwy37RYBYAlU62pqhLf97cjF/M=; b=YnWL/TYB2On/rht9+tfrIsLdY/HiRqlOz8MbhgsWu5HQh89MfDLu+Gan8OYTstTOF8G2Ja4AZCO+jCqkn+HYqrTLb2seTsB2gKmTiBqH2mJYJKw4IUeBt5lqDPGK/FUPl9yyWVLE19lPEK1mr3ew/gA4imEXoyKDGWv3fNekHLemzrqi+fxCpubdHsdoIC2Z7hl2rldpxoIk4ZetCHg/b67h81eUcGJIEtnRRCClqqPyMC05HUp18yKR1JEbBJOXtwWx1nwZw0gE9vnXDx7JBmf53TPISsGvxUfa+iVWlVY5GrhHacHeWIQ8jLD0WGpnesMrpcX8ZjlWnRhBI56O2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:36 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:36 +0000 From: Yangtao Li To: Adrian Hunter , Ben Dooks , Jaehoon Chung , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Andi Shyti , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 21/62] mmc: sdhci-s3c: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:10 +0800 Message-Id: <20230727070051.17778-21-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a5957d9-1f5e-429f-7df9-08db8e6f51b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ya2dLncvJs0eWmm2AK7SbhpT93Vk23AZuvnI+BwuSloLOqxsGZpEbWiPYYcJDCRujU6gWCZvVsBq5A25sCP1ua+OWcvfUlLlOpLnmqUbDgMK/ZlXD7tJtpK2+VAHv9ENYLhRZ5ALdFpTwbl0uhCQK5HcIhVurMymrgPvFejyZdWtHMYbm7OfLfnwJeuH+OfU0hfghEcNAz9aEI7zPzoOxNtWIcQX9CTyl4BvT2s/TzzuxM2UiFwr250bxhB4jE668356m3HYKqvNgVb7+aOdxcTBoJIdVkt4uoc8D33WfkYm+TP+Jv/vnqBZLycXlbwSr4ibdZ9mtbdsuWCHJdiibhCu1hdOzTMtbLnzZDXltysvDQMjrF7NDiqwednK0F28560bU6d0E0tN6Ck16IRDCqfNwGa8jmNhNT7lnGBNHrL+ts/br7WQk+69YbdQXwq5stGbqRD/XFyYz/Si0NpI/4+cU0o0GWcx1bPbPahIGECKP0s/+Xz1OsDpv9R3fW6GePYlKSKg0bXXbWsrpwBMqknHTbEPuhKwU69Qi7RhFYikb5dfM6117WjlT8F0YjKcwccb781ErlGzg8FbkSXZeHAfQQRrTihRgqZeMKJ+9AlPG5KZuHObRg7GUlZl4/W4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?lJGojUduazbE8mxlk6ZMcfCW+l0F?= =?utf-8?q?/hbxHRLzEje4tQK9Sg1h3pnAbwsiVGYxe50xCd9ro3kJT/2EfapCW4RGn8KFfvs3O?= =?utf-8?q?jQ5DV5jWM1Cwev8C31TyHkNKW98vOu4LXV4HESkRPweUmhrL5bXXCjDd1/cAmIGzQ?= =?utf-8?q?2QIoMeXh3BkiaR5R+0qM4n5MoT3TVZPKVxPJIcobhE9hmsQ+gfmOupMrI59itNVfx?= =?utf-8?q?TW9r8+woRk5LKqLleoFD89PIlPwvfA+83mRoKYZgKyniTb0tixh76YXCz+BLlIRyK?= =?utf-8?q?4qLrEdGWrrN0/x7mdZUiiojTXBTA0GD2tPvTXcKkhLIDuCOW7GErGE8uA7+QOI0fq?= =?utf-8?q?JOFl+qdVJ2xHh1k8A+un67Il+A85Jq1N4aDbKU2Z0MPKgeOl9AwnvidW1WGCPMZzc?= =?utf-8?q?28JlQp4xhYTsTxNIaCcJ2EaMaN70vIP97FPnF84Ziqq4Onk0b4/8YixmDdaRo+2c+?= =?utf-8?q?F5XcK+6Qmrv90uq6IAGWrT2kKKVDz/Uy8dO3az4VnIqmOGQuruHHlN8sJwXp27q9N?= =?utf-8?q?v/Koi1Mm06zhsywpwzUAf3QJdVVPhM3yMWCw1Z5U/TDF21KBEq5WC2IuYtbbUPcO7?= =?utf-8?q?1KpcYOaOJBMffCW4VpQa6p0FwouugPC0q+vq1i+QJt7T+WHDMIBrFmFIg0KrMf/sR?= =?utf-8?q?MRhlrTrnF7dK6MUxVhCqsnkY2HcU6qFJeUGVSxOqqYSJAGxbiV4XpByT1SXPUvN7J?= =?utf-8?q?H30zxGeTKpmFjI+oY64V0vzaqbJzjzmGhmR9xTffmJVLqq09j0KnKI5UmWeWzqAiM?= =?utf-8?q?ooYBWGegCJyzYaVsngfe0RrYglUd6m7rz8tpTJhR2eURaHgAuc2cQBI1gb+zqW7R9?= =?utf-8?q?iBN1yiZC5mUQOtYdrvcjxK4d7QAMC369ctQHl+kYEylxBHeaKpvydEZom1dhCJYsH?= =?utf-8?q?QonFpOWN0+RgmhlldYTSa4BXmc4hWjBdtAy7wpLxT74sho2ynOKWN6diW9Tq7I62k?= =?utf-8?q?ZwrG+2uPBHp4ihoqdWfusKLFlprX2EyOrHqp+nA+k7kl+St07EFh0O7rnnOcRFGyh?= =?utf-8?q?JK95I5Dr/zw4xMDQKynBRNia8tEw8CJ77pG1BGnvwanRBIMRjGMRhIoeEPdVBCHGO?= =?utf-8?q?G6lXWBTkeYhxv3//nfmwiJpGDcznARPPvxa5EY+UEiNJ0twpFKNxDFG1B8ulHFqVy?= =?utf-8?q?Y2JPbqXMW5YMT0XRauzUkkzPzHGlkU7wfLjzgiwEefv/0w4gY45cdiSMvWdT0knTq?= =?utf-8?q?tTmJjDWPeb5oLgVN9Rb/ePcLxb8/8hVuJ8KPSyweoPhaNRDIBtL5PK/bRYTiGurew?= =?utf-8?q?3iixqSAp4a2z80wH/JiB6BEEniRL3rI1jvaHDsxs69sEBHhHyMSSeX5UduZynV2d0?= =?utf-8?q?maq6UUyaZvC8RahoozBay9ejNAxdguc4Zn9chLQIUz4LYCH0BJV1doFK0dDqY/Q4o?= =?utf-8?q?U+UvmRymm3IgYny/7UAmJVi4B7Of8lY4Tyzuz/2ZDMcObtro/mjASK5r8WmI2erEF?= =?utf-8?q?OrGZ8NL8K7PSY4GnvBodN3XTGYdJPW5ckkj0hgTfcZUmleD/W6LQ5fsh65ALHfhIT?= =?utf-8?q?lv/RWnerWmIW?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5957d9-1f5e-429f-7df9-08db8e6f51b0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:36.7446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tteKqgKH7X7tIiNEa4vTYfbcyU83SIu+5k4JYYh4/KlWYxkB2z/kIwcCphXd57a7PZK5N0rMai/sLmMUBgvjBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772561169762208263 X-GMAIL-MSGID: 1772561169762208263 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter Reviewed-by: Andi Shyti --- drivers/mmc/host/sdhci-s3c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 504015e84308..b61f12d328e0 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -668,7 +668,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) return ret; } -static int sdhci_s3c_remove(struct platform_device *pdev) +static void sdhci_s3c_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_s3c *sc = sdhci_priv(host); @@ -688,8 +688,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev) clk_disable_unprepare(sc->clk_io); sdhci_free_host(host); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -776,7 +774,7 @@ MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match); static struct platform_driver sdhci_s3c_driver = { .probe = sdhci_s3c_probe, - .remove = sdhci_s3c_remove, + .remove_new = sdhci_s3c_remove, .id_table = sdhci_s3c_driver_ids, .driver = { .name = "s3c-sdhci",