From patchwork Thu Jul 27 06:59:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126748 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp922064vqo; Thu, 27 Jul 2023 00:39:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlHmtrWQziUdAwkR4DVeAGqfBY2jr7fMNlCmfgPPFvbiHHQlhQpNvRpPPOaYxsfLeTl8iBbn X-Received: by 2002:a05:6402:517a:b0:522:1d23:a1f8 with SMTP id d26-20020a056402517a00b005221d23a1f8mr997019ede.26.1690443552922; Thu, 27 Jul 2023 00:39:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690443552; cv=pass; d=google.com; s=arc-20160816; b=LBiqXEf9S87pyBXcro7Dcis/WJRc8vt0I4BLC+h7j80dq4g4QPEPNndkOedNXyPAIx zjpwvR5auzi15dQzQls9bgLDXRqZDJPlowEas93T37AXerGMLDb9jqlBWD/YfgEZRar2 h/CH0kvPlx3+CyI7CMGmTP+5LkUJNcqOd8oZYAJAbmqDarNJgrTMlwB8Fier0ZsAzCgC /QrUI7OM1zQnXXYFfwbsVAjXOREx9fgB5iF3M5qE81QsiNwjL4T1cxssYGSDzKhzMezB I0ViER0epVuPvyJ0OaaxQt6ltYL+u9jzHXl7QtjP63Bsv2gTZ8SUACPDVJMcTXyJksWG OFuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=3BDV2gitE9ZgnfS93zzj6+ruXHPsGkYOE2qo/yJJ5Ek=; fh=Obr7MIEUOpnq0pB6zulldJnRaWUMQlXEdPVcMkgQvIc=; b=jIPy7CpjFNlddMt4Jin8eKXe0k9r8WRzliMePSg4fmgE1+Js52Lc1zc4YjCAVmL6MD f8QL/tcmxFS3CMq1G/pYeI0uOCLH/WsSXJDt2MRUKDMC+XnRo8ktfQMDOGFoJ4BNC2EL H+RUQmTPmqepf7P7pBikHDF36fVnk5qrktPpifOz+ameiAhZHeMxHTo2nHmMwu5PVYK/ nBsdDztinveayl8fHpWoXZm1mfZaObQAk+nhJFJQHHuHiaKls3dcwcOB+Cf/p7PQhWzp PCbZL93rY/mCx7yjQ37D6tpm1hcO+g5zA6XiHbsfpo340x3EfzsuphcklTqwsWTNNn7i P5qg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=Vy3j+10+; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j6-20020aa7c0c6000000b0052280c939fasi569786edp.481.2023.07.27.00.38.49; Thu, 27 Jul 2023 00:39:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=Vy3j+10+; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232802AbjG0HBS (ORCPT + 99 others); Thu, 27 Jul 2023 03:01:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232774AbjG0HBM (ORCPT ); Thu, 27 Jul 2023 03:01:12 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2093.outbound.protection.outlook.com [40.107.117.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E1B3272D; Thu, 27 Jul 2023 00:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SeBCEBloFsZoNS+5J1sO5KnjP56xeRnO3/XX4lEYgNV7foyxuX6xYd1cEY0kua82Vyi1zjBpdCKvsQUTbbDltxauR4mdiihDPGTYa2x1TK+l1xQW5dgVykwhvpvcL6GYVkZXwFvSnjNyilZwXriLPICeJaUKctotx/kO/11KE+g1YxLXYo4vydrZipys3dOxArVMQW21R4wx6ASz92Fp3w1naHo9/QlWPKhewFgBQvhJejN4y9Woli3zZySQ5n9yzpY7+1ncKv4xfTryPdAQce6dmYNXD1CXbWgIgJwTHvPUd8VRGPPcOlmgAuLvZ5oPIRnMUyCr5Qm9WixfPWK/Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3BDV2gitE9ZgnfS93zzj6+ruXHPsGkYOE2qo/yJJ5Ek=; b=APvguC5UvVDVSiIVz5eyTxR+aAZ1p8xqrBcuppT4ocqq95GW+J3SwEpRofbjBjVrQPQvM+GT/Wk4TKOnq6SmemyrzjYUjt7FO/ou1gORpq6od8mojZRcal6jeio+yJQZjVB5QE6ep6hsHzUIGWkxmOfo32FAULqcNDJPKeoQgEaMNBt6PNeGbvYEL7tH9c8qsc2PgyO8NHchLvtHD0S8hxb5SX46ELWE004/FA6Z/gkm3WUnZ9UV3UuZiCfMdv9h3kVX9PEBel3udNyGwjauWZV0oe7P3XwyLPhzeJ+/y2wHFd0xGFfKf3XlU/U2WTWTayrjAoH8VrE7/8eLrXTpXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3BDV2gitE9ZgnfS93zzj6+ruXHPsGkYOE2qo/yJJ5Ek=; b=Vy3j+10+n2IeLbIykOj5ObhTpgPSlbR5var1iqWV2gsCdxETsXiSXeZTMB/9HRUd9XrARXeStiVxbbxlupkdNV2F26C/NPriwUiyimdn4t9/wU/QPdQ7OwQOjy0b8AFYLA+vFx9MBWK2RKOcIXJ9TzeGTQVnnclwb5Ngduc6vVQQeUelr2YfbVUndfSEGM47Sv2vRvO1016ixd/hcq+9C0oBiBt7K1bVbSwJb7KgJqKAuCCyuMmj+ShuTsuz2rKWLEUnISPNKYS/YkzP0ACGEyaDm7q7WMJjQ0tKIzJNtt4pbFlNP47T6Opvo2Ab9qbzY8Kp5xeVJh4o/DBeFTi6pQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:04 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:03 +0000 From: Yangtao Li To: Ulf Hansson , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 01/62] mmc: sunxi: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 14:59:50 +0800 Message-Id: <20230727070051.17778-1-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 447573a4-1197-46fc-4553-08db8e6f3de2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5x5QEOI3W1Mtsz7E+kTSWli66UZKWJarrbbcYCYIC5sDLUstFY+23H4a5CDZWjplFJv1LNMFIMRK2jREZ8wz+cTXcRdTsI8/1lYUIkkDsm64+CTTOo0A5L2IFvfV+pcs0e9M5SUgHA061bmK0pknLkF7mbYfAQp3/dy/z1eRK5Bn4EiovffEmXTh3mZeGzh05GoXzs+QqCJo+QUJmZFsm9CtsVp3zH5w0l0itjOO6QsS1gNXXqqytenNE98R7mXhjKY98cwyeDGVOZ+Ms0h0txXXI1rH4XHVmD97Z1kROK76PXLm9UAa6JDFQiUkxIeDlE/o5qrtBcT93Kt20WHNZ4vnzRwH4+ocDdWQeH5Ay+JLMVNgsxKWzCliaEAqtvuvQrNiHjNADGYUQcvF95WNa7QkikzFyg0KVoGlXYIHl2uxLQkjyB491npV1VjM3La9YWhebxtLCABjLZfxq3ThNufQtfxg51HVELJtFgXvaHW5hBozGFzTFe2DguM7SK55mcjI5bV0T0m2N+zI2Hx7kHbcaO7mXNDpeqMoFdqfdXBaMDFhSeMfjgjTsmN4EY30H+muoQiIwGwyH7is7EEa5tm6fKItXhJ4fkshTfijsXalqOEig+Cb73LV5sF9GpNa X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?p2/wOS5ZrRE5TqymHtY/ZvvUG5Kf?= =?utf-8?q?cxeF0a/GkOF/NRSKDQxgB41b+/EGZmU2c434xSMQ1nBp3dwv5u8KaQLFoHktayVd9?= =?utf-8?q?2nSMmAAjFLn78CfOAA9A6oX+V2tPplDTcCPKJQuzWvnSqW4mcOFmkO+u8Tya+zcp2?= =?utf-8?q?uINkPQQNexYBzIY8CeAV9F2x3yNNrYYNhptCqI4zwHfOQVGoW/ZOtTNYyx1toYurm?= =?utf-8?q?0YMTZRyCkmxFsox7BNDLhtIEi/zb5Tkq+sUkfyXkE8Ryvdtxk9i6MMdjmMiEm5+XI?= =?utf-8?q?5Rk+PHg1fLSMVVydcRF2bT4XqeWXPfXtL8860OXhZSfQkwPAZQawH126PKrfdoZbC?= =?utf-8?q?wJL2dJncFFE3XilA9AIQHvStaffeJ3Y0IXITXmNzWaPbDUEtODZYvn/fKNbwxWATn?= =?utf-8?q?0XyDBEiMF4M6kwwZB5JiE3cjJ47HV+C2xkeFxJYpzCm/vCI0vHYtpUvwzXHiMhDV3?= =?utf-8?q?hPte/7mzrLYlztdvj97/o3fgNT4NuaCMFAgOhep0vZ1RBKk1EYsfCRkxglmODrqV0?= =?utf-8?q?DtzlYb62l30eY9u8u8E3JpIT7rjf5b7eHVkb+qqsm209j1cAYkjSxrZfeSVtqi8XU?= =?utf-8?q?LdaPn2qUy+CNgGTFZA70IHhHQ1D0zdeLtCUfUd/do4IFwIf7X1A1mTPJcSvoW4rp6?= =?utf-8?q?/kF4jIt7mPTPPbi3A7CKF8EIioFiMS+4NXkCo1JuIvOFzaCOntLBMry3QI9dEmUFx?= =?utf-8?q?mPjGmXLz1xk0DOFYFHpM9Abv9awXswFdRR1nUfZZLgIzMmB903h+K364vAWeXEfGc?= =?utf-8?q?mW+qCctiMDZDhkTyCXcwbt1ttikARYgBxgDvRE8gsoo0VTw4VBNTWxeLaorssG3GX?= =?utf-8?q?ei39ULSYtPJzGW8PNAKffP+rkMABtsQKUg3Er63DR1EC7wBogGhj4WAAEUjf+H5hb?= =?utf-8?q?X487uVP/ou8f6/Pl6tipjMqZsysvGqz6OI/tB1TaTfbpMTG5d7ZrUIZtHZize5QHF?= =?utf-8?q?6D6ZCEcYbbOFhDi6oHk9FAMwSg6L4Yza23ZZak5U8X8s3p3dfVnUi+LUH/kIUdRF4?= =?utf-8?q?hqrmjqCcWbeAaFL+yD560UuUso3kQBPlwnXk7ryFFiOITvSDNRviE0Sg/Nvnq5IGR?= =?utf-8?q?z/okx03n9OO0Zse+Jk4NxIynik1y2f+er/rW82E8ELdL/EInDcoe6zXGwUf0ljpgd?= =?utf-8?q?MjGS91D39FikfN+klaN2wcIAEhKs9rZtUPey27fxlaKD1mJP8WMkK7m5se2AigmTl?= =?utf-8?q?XJ7UsfO5Vmu1ULUxFDGRX7wCi7wIi/Z7tpsXEOkonG+YV9nY+SBS1oUxn86sLAxJG?= =?utf-8?q?hQIhivN3snxOVkZlU9Keo9IvVLg2C0Uyo9x6FOKfzhQVXvZTdzSdFCBn2nKIuQZxw?= =?utf-8?q?F8xzU76LB0HcgiPrnLBiThAYh4FCDw380Wrh4zJiRCCFRO8qZm5+Wah6fAAD+h7dw?= =?utf-8?q?0TclDpSDCibaL0G9fyUAI/Fzj5ItLWB1eKzFOpeEMHdT9odZVI4un1Hx7lE87aN6n?= =?utf-8?q?XYvhCkqWpgwU8XPDIiEcZsF6mGA4CJetMK3hNf1+BltJM/JJ73H1r3FT7iCh1EGmh?= =?utf-8?q?DDEOk0Ok8o2E?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 447573a4-1197-46fc-4553-08db8e6f3de2 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:03.6262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ez8EhYmmXmBQLB79mjaF/JzcIaO+mmCOYAH4sxOYAzOrgNSh9+iv0xQC0JuY6rSAkqFi9zv7OCmJd5OPtL/dkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772558538845659239 X-GMAIL-MSGID: 1772558538845659239 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Jernej Skrabec --- drivers/mmc/host/sunxi-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c index 69dcb8805e05..d3bd0ac99ec4 100644 --- a/drivers/mmc/host/sunxi-mmc.c +++ b/drivers/mmc/host/sunxi-mmc.c @@ -1486,7 +1486,7 @@ static int sunxi_mmc_probe(struct platform_device *pdev) return ret; } -static int sunxi_mmc_remove(struct platform_device *pdev) +static void sunxi_mmc_remove(struct platform_device *pdev) { struct mmc_host *mmc = platform_get_drvdata(pdev); struct sunxi_mmc_host *host = mmc_priv(mmc); @@ -1499,8 +1499,6 @@ static int sunxi_mmc_remove(struct platform_device *pdev) } dma_free_coherent(&pdev->dev, PAGE_SIZE, host->sg_cpu, host->sg_dma); mmc_free_host(mmc); - - return 0; } #ifdef CONFIG_PM @@ -1556,7 +1554,7 @@ static struct platform_driver sunxi_mmc_driver = { .pm = &sunxi_mmc_pm_ops, }, .probe = sunxi_mmc_probe, - .remove = sunxi_mmc_remove, + .remove_new = sunxi_mmc_remove, }; module_platform_driver(sunxi_mmc_driver);