From patchwork Thu Jul 27 06:19:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tree Davies X-Patchwork-Id: 126739 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp921076vqo; Thu, 27 Jul 2023 00:36:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlHxqZqf4gs4t3euhi0L/w7WAv7em/f96nOBGZc9Hn7wHCKBR1DcHCZlb8Rli1uO8EysMd5g X-Received: by 2002:aa7:88c7:0:b0:67a:72d5:3365 with SMTP id k7-20020aa788c7000000b0067a72d53365mr2774520pff.6.1690443413313; Thu, 27 Jul 2023 00:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690443413; cv=none; d=google.com; s=arc-20160816; b=fXr5Tsp3NroV3XmR95Yz7ANAbwn4u00pohW42il/BP6czwGtevUQnTsrjfKuDNBAZh Bzm/Yicz1usWwKpbNNrEH+BGv/+JPiVtBoIOtn1MiTBARxNQAuErUS6N/sltgxbQRsBc DkUqfd2waKgNldYju8vKTb1zfZV1Gd+b6npJv9Laz7Gu2urUDLxbxO+0KEMrc0doBhhx p5O6z4OuEHmVm/o0zobBokaScOVlHhLxClHy6vKGJQORPPEhW52NOlxXNaR1UUtcNSdh OQ50cMf2vyhCmf+2k3YJrWRifV4EmZp/N70I+5bCZRU9e7qadwSp3PdxtODEOlcRhxir ijsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=GCK206rxmRk8X9Ht7QXuyqdPQH09ILG/o/K1GADjRno=; fh=I5RbcQPTSTvrwt0yqig+bV2C3roPED/NlXe1P2BfE7E=; b=k0SPlcjKewt96kgcIdt6SbTCbOqdpOMLBbYBGMYgUWSHoVJBD4zWq3ybsURVqFruJd eKkzIfsF+yMulFJJrg3GB6HwUqnzzlDR5PzEMSzabO6r+v59dCli4P35bHHRB2h2b9Bi aBh1L4EpUz3C4q6IPtrkEZSahthVK2/vNIKCLMbfeL2QcfPjtdcbuPESnTkfsen9Fok5 bczlC/pboFgfTc72UMlcqw70LI7zN7jG4sN9CzPnxnoLyRyrGKVvcoaak5kDsauggPJQ AnfZ+e2HtGkD4IriiJ8k/n+JHDgGBwnew9B50HUWqVayuvU+kLM+62hH5H7KO/IvDvj6 n+tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=IzNx7yNd; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=N2cegFqc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e8-20020a056a001a8800b0064d28b68d8fsi1021385pfv.94.2023.07.27.00.36.40; Thu, 27 Jul 2023 00:36:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@pobox.com header.s=sasl header.b=IzNx7yNd; dkim=neutral (body hash did not verify) header.i=@darkphysics.net header.s=2019-09.pbsmtp header.b=N2cegFqc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231624AbjG0GSu (ORCPT + 99 others); Thu, 27 Jul 2023 02:18:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232733AbjG0GSq (ORCPT ); Thu, 27 Jul 2023 02:18:46 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C6BE1990 for ; Wed, 26 Jul 2023 23:18:45 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 3B3A72B78B; Thu, 27 Jul 2023 02:18:45 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=sasl; bh=anF2Q/E3YliC1TJLo8573SGmv SXnXLFplvRBwi1kuZQ=; b=IzNx7yNdHpmu9IGROV8LXsHjgAsPmnfsEaNb2JAm/ 4QvOpZ4UurqqsWVEM9uinT1MsdIHCrBSNYXcFDBmls9sKg1sIXOBO665t7kJFl1a ayIma5NezUHwrcjFGBjRzRkIpp0nHwfzuYO+JSRp568GqqwV4YBO1H9cmBibbq7r /o= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 33DE82B78A; Thu, 27 Jul 2023 02:18:45 -0400 (EDT) (envelope-from tdavies@darkphysics.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkphysics.net; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=2019-09.pbsmtp; bh=OYbg2N402MZIOZTWV80ogeQ3GrQ1F3pvilpeh4bbDy8=; b=N2cegFqcjaPW3lWRE7RywAJ4LwCQithMlx3yolAdl85W/Yb+RP5ofESPmSDEwS7SIKUe8K9py86HGLZCj2dYfDRhn+wr8jikgAR415PfepGkia/yKWMhNl0PMR925TiKM3wAo75r0tF4FU+YHgmFhNyBuvUjRMGZAOXsh8WjM6A= Received: from basil.darkphysics (unknown [76.146.178.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 60A852B785; Thu, 27 Jul 2023 02:18:40 -0400 (EDT) (envelope-from tdavies@darkphysics.net) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca, error27@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry Date: Wed, 26 Jul 2023 23:19:45 -0700 Message-ID: <20230727061948.579480-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230727061948.579480-1-tdavies@darkphysics.net> References: <20230727061948.579480-1-tdavies@darkphysics.net> MIME-Version: 1.0 X-Pobox-Relay-ID: 6E97C26C-2C45-11EE-B009-B31D44D1D7AA-45285927!pb-smtp21.pobox.com X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NO_DNS_FOR_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772558392369233307 X-GMAIL-MSGID: 1772558392369233307 Rename function DeActivateBAEntry to deactivate_ba_entry in order to Fix checkpatch warning: Avoid CamelCase Signed-off-by: Tree Davies --- v2: Sent with git send-email drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 965ffa8b78c2..50362bbbc8dd 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -17,7 +17,7 @@ static void activate_ba_entry(struct ba_record *pBA, u16 Time) mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(Time)); } -static void DeActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA) +static void deactivate_ba_entry(struct rtllib_device *ieee, struct ba_record *pBA) { pBA->b_valid = false; del_timer_sync(&pBA->timer); @@ -30,12 +30,12 @@ static u8 TxTsDeleteBA(struct rtllib_device *ieee, struct tx_ts_record *pTxTs) u8 bSendDELBA = false; if (pPendingBa->b_valid) { - DeActivateBAEntry(ieee, pPendingBa); + deactivate_ba_entry(ieee, pPendingBa); bSendDELBA = true; } if (pAdmittedBa->b_valid) { - DeActivateBAEntry(ieee, pAdmittedBa); + deactivate_ba_entry(ieee, pAdmittedBa); bSendDELBA = true; } return bSendDELBA; @@ -47,7 +47,7 @@ static u8 RxTsDeleteBA(struct rtllib_device *ieee, struct rx_ts_record *pRxTs) u8 bSendDELBA = false; if (pBa->b_valid) { - DeActivateBAEntry(ieee, pBa); + deactivate_ba_entry(ieee, pBa); bSendDELBA = true; } @@ -270,7 +270,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) rtllib_FlushRxTsPendingPkts(ieee, pTS); - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); pBA->dialog_token = *pDialogToken; pBA->ba_param_set = *pBaParamSet; pBA->ba_timeout_value = *pBaTimeoutVal; @@ -363,13 +363,13 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) netdev_dbg(ieee->dev, "%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n", __func__, *pStatusCode); - DeActivateBAEntry(ieee, pPendingBA); + deactivate_ba_entry(ieee, pPendingBA); } if (*pStatusCode == ADDBA_STATUS_SUCCESS) { if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) { pTS->bAddBaReqDelayed = true; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); ReasonCode = DELBA_REASON_END_BA; goto OnADDBARsp_Reject; } @@ -378,7 +378,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) pAdmittedBA->ba_timeout_value = *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl = pPendingBA->ba_start_seq_ctrl; pAdmittedBA->ba_param_set = *pBaParamSet; - DeActivateBAEntry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, pAdmittedBA); activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); } else { pTS->bAddBaReqDelayed = true; @@ -469,7 +469,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS, if (pBA->b_valid && !bOverwritePending) return; - DeActivateBAEntry(ieee, pBA); + deactivate_ba_entry(ieee, pBA); pBA->dialog_token++; pBA->ba_param_set.field.amsdu_support = 0;