From patchwork Thu Jul 27 02:02:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yury Norov X-Patchwork-Id: 126591 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp788008vqo; Wed, 26 Jul 2023 19:06:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlFihohgSsC8tMUAyHPXiXkyD4omY+JjjZOBFe7+giT+X1qaZtshs2GU/p/NYXGe6puJc94M X-Received: by 2002:a17:902:b593:b0:1b8:9002:c9ee with SMTP id a19-20020a170902b59300b001b89002c9eemr2803111pls.1.1690423580203; Wed, 26 Jul 2023 19:06:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690423580; cv=none; d=google.com; s=arc-20160816; b=BrJggkJgulMz6ENBUqjOclkPYlshsdHi1ZbtNgxdQ8UHW20SHJwiLc8EJuIsz6q/+V ZwVFbvByY4nSSQvJX5hO0+9dV3fIQAYOhV09JQB2ZR4knTgbc9Tn5FZcjkXClz17FDAl eINZLdoOXQ4g6QUmBhiow/KBcvukYz3xmwmgLUUOLkTv/8FUplmabqsPlDb5CcKGP2wB CM3vot3W23XWAx3ZiE+j9lJiFFWfiWk50PJMwFUj8WEFfMmmPs4nbftSlbgJiIYOcucJ smDyN92ZO6iHZrTN5Rd0KMmbXVrZlETdJWijxXJ8ZYS90B3577irk9CpGJvAzEu1PLiA 8FYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7JvH6fCyOwmUpJlih9kGPQ82FswQKyJELuqHpVpnDY4=; fh=cHPIS0B0xryN499NBDnMx1rX5txKNt2FKl+u/VWHhrg=; b=dl+iEcTjnpyeBG7vF8FteL8ZaMcMnQjwtwQWYmW9/zU7k67bhOQnweA0UrX8cYg8zB 0k0zLNV3Jlu2fgl1NBe5TlLc0VMtkBSd9Y2gyPZTHH4ulvZHKcunRZ9YZdqVf4b+Smlx MK7+ZSt0+VDFPIegEKYc6nK1JblbbiVEmQzD5nSfXfBALRwtxDkS4rwJYgJcuia9XZg7 x3JRfyYepTdG8X4s806JEHZdyqliBaVrU/yCMnM0EnUVQFgj6yKqfFrirxDYEVCGHSee HVfi6CoyK9CFR80f64eO3Oy1VqljH17NIPVMqcOLd4CXTlbiTg2MQVOLsixqOoxrjW6F tU5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=i7gBSpnq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10-20020a170902c7ca00b001b8c40214f6si337511pla.252.2023.07.26.19.06.06; Wed, 26 Jul 2023 19:06:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=i7gBSpnq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbjG0CC0 (ORCPT + 99 others); Wed, 26 Jul 2023 22:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229982AbjG0CCV (ORCPT ); Wed, 26 Jul 2023 22:02:21 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDD8CCE for ; Wed, 26 Jul 2023 19:02:16 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1b8b2886364so2893565ad.0 for ; Wed, 26 Jul 2023 19:02:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690423336; x=1691028136; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7JvH6fCyOwmUpJlih9kGPQ82FswQKyJELuqHpVpnDY4=; b=i7gBSpnqZQMeQLBB3IgdhZMBG7JEgU+m3wyIXdUHG3iCYDl66WvgCrSqmUpC5Njy3W dY+PJkHGbPQDbcb24H/c4beeMOYfCENgG3YPBbnTEeW4ru+hluahmqoSBW/28IsDhh4p 4e5sbagKQJDa0OmqfHfRqb2hm8iVcZAfUi6zvIsB+nIpI5wSwBzb9KZ+OP+izfp1SAaO otpMwFXFToqJa96GG006XR0IvD+ZrQv2lY7mFv4AVHUdMeVcaicJ6A5/HvNi3Qt4uUHl TCwg1x3lWUb/uJUxKqhy2EyFqe6wpkiOEbFmvCJpeDCiq4aTPYD8omlkGE4DRKAqv9Td DOZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690423336; x=1691028136; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7JvH6fCyOwmUpJlih9kGPQ82FswQKyJELuqHpVpnDY4=; b=OYiZnSWcNYEVhz4yexGIX5nJBg/YM3tKqG7OHU//GpBpoQxnwuPIBvhx9ohJQTQAFg IzcCmYVf+Q0sZdqlPwnBuOYOk2QWw2aqRokUhXJvb3deCabLQo8/QjYQP+dAO/9FnfaW ZZ0ns0CR2k3u4KPlcl713gz5gnKlaeXBC+Upu4i7T4IN/fFf98eVnWDWxnpirTDr6oR+ CHksjheej++gAVJuFwOeOmAB7tUN4AGAZZSt8xzLerhLXPQ9pbggCwWmgbkJ8vQPMlst rm7vzJKZezMq8WuUsiQWDVk/q9NO2/4AH9ZaO9xsr7MIf/0FLiYdQF76pYB/DGmKi0jU Fjdg== X-Gm-Message-State: ABy/qLahFDuXG3WL5WOxNVkWgm/FGLqy/wyJDlbiIdQhvFxYD7zyoaoB a9xZBSdxetKdh7P2qS4LSsO0cvHbmi9BSg== X-Received: by 2002:a17:902:7616:b0:1b9:f7dc:b4f6 with SMTP id k22-20020a170902761600b001b9f7dcb4f6mr2750054pll.44.1690423335906; Wed, 26 Jul 2023 19:02:15 -0700 (PDT) Received: from localhost ([216.228.127.130]) by smtp.gmail.com with ESMTPSA id u6-20020a17090282c600b001a1b66af22fsm234921plz.62.2023.07.26.19.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 19:02:15 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, Andy Shevchenko , Rasmus Villemoes Cc: Yury Norov Subject: [PATCH 1/6] bitmap: fix opencoded bitmap_allocate_region() Date: Wed, 26 Jul 2023 19:02:02 -0700 Message-Id: <20230727020207.36314-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230727020207.36314-1-yury.norov@gmail.com> References: <20230727020207.36314-1-yury.norov@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772537596050440542 X-GMAIL-MSGID: 1772537596050440542 bitmap_find_region() opencodes bitmap_allocate_region(). Fix it. Signed-off-by: Yury Norov --- lib/bitmap.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/bitmap.c b/lib/bitmap.c index ddb31015e38a..0bed9d943d96 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c @@ -1314,12 +1314,10 @@ int bitmap_find_free_region(unsigned long *bitmap, unsigned int bits, int order) { unsigned int pos, end; /* scans bitmap by regions of size order */ - for (pos = 0 ; (end = pos + (1U << order)) <= bits; pos = end) { - if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE)) - continue; - __reg_op(bitmap, pos, order, REG_OP_ALLOC); - return pos; - } + for (pos = 0 ; (end = pos + (1U << order)) <= bits; pos = end) + if (!bitmap_allocate_region(bitmap, pos, order)) + return pos; + return -ENOMEM; } EXPORT_SYMBOL(bitmap_find_free_region);