Message ID | 20230726192740.1383740-2-iwona.winiarska@intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp631097vqo; Wed, 26 Jul 2023 12:56:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlHferhw9hGP3mY9TeLEoy/U0GGNBsY6jOGO69B7MEn1WbQ3ibWIJgzNHpvdEvcI9mAfmhst X-Received: by 2002:aa7:d0d4:0:b0:51d:e4b6:ff6b with SMTP id u20-20020aa7d0d4000000b0051de4b6ff6bmr111617edo.33.1690401375432; Wed, 26 Jul 2023 12:56:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690401375; cv=none; d=google.com; s=arc-20160816; b=y0rHQoVX3dRE/DigrpjJ/sv8TinBr1AUcHrVQJ702IwQIvT3GlLSBAPQC3fnIzB9Zv 7HS/IRG7cV83jQObTwhC2M7OdkJdONHH53wDaxEaF9OTk+2oU9sm3z6i8y7whOKApDKj oBYFLoWy4BCme6yr8owFOh/lVSYL9nY2GVbkXj41KaJknGNfyEZZCU7V6M4geYGOZ2fL /b9BCCN5UoOyVKCbQmXDmJl1LW7WZgv1+14tg/rlrtPTjwYozBIrIVxzehLUngq3Qeyh bIjM91/8/hCc+Y9diylgtFgFBXEEi2DLPJ3wo9sqn5xz+NGl/bEx4vuiXrW7Js+BJ60y NxhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W3Q41JDOBNbvbT2YyycnNgKpJwfdD3iQ8rgzyI4woqE=; fh=KxwBhlaQRjw0lYAK1lzKO0tgbLEu32439pmmXrGMCHA=; b=OxfvF3OKMuhQ+PmLcCAwmfDIqnVni5OydCFecOCoz65RLhliC3aGOM59kkaiS/NZqb bvQpcl+xP4xc4vsr8RWlAnI2nITDJFf6/ASXnwp8CIYK4fqJNctzluGIjo2tvMYyQKOO 5grOA7hkH4st8wZSX+BZwBYk5Wm2mU7sHcdJEPEBYLzEq6XyjOMtO3bs2aaXhUGI2fDB UJffZJcg9MwLltr18bV/pWijUp9MHMe5slRL4AsTMTsjlenk6lKynjQsD86xcVbXjbOH bS6mB3+Y7uVynTh2Q6rNT6lXQrlhqOqSCinlkK72Mdz7c36FE9PawzueBqxMhxx/0hPS buzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="TZ/QLu/5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020aa7ce10000000b005221fc3b76bsi6298803edv.126.2023.07.26.12.55.50; Wed, 26 Jul 2023 12:56:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="TZ/QLu/5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232046AbjGZT2x (ORCPT <rfc822;kloczko.tomasz@gmail.com> + 99 others); Wed, 26 Jul 2023 15:28:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231857AbjGZT2v (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Jul 2023 15:28:51 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D703AE4F; Wed, 26 Jul 2023 12:28:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690399729; x=1721935729; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1fcZpoD7pysu21pr96a3/oNgTjK6roya1B0HquHldxI=; b=TZ/QLu/5Ys7QEuPm0MRgJpKNjQKXTpFPcDfG8aUv+wjc7lvWtHifqPML 37NkCQyKzdTTgrTMbXZaLRp96Uvz/WxJLvt9lA2QogfaG6F1AH8GZL/73 lsfy7d3PLcs0V1++tfmg+1VuNX60hzDpQEFYRVQl+i5g4MoR+mJlPYyBK F6FqCR61qYPh8RTqDGkAK8FSqc7zUzfSY4bjEmCrf5ZV93zrAWJC0SFFm RWjpewj0g8MsjqWb0/TAzs1icLbvCRluCqTNg3BfLEWJxRLmAIS7wMa1s trOPIAoMcmvehnppugLGrGFzHPm5niV/Msh/Pr2ycEqpg6yFdn51ism76 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="358110169" X-IronPort-AV: E=Sophos;i="6.01,232,1684825200"; d="scan'208";a="358110169" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 12:28:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="726661966" X-IronPort-AV: E=Sophos;i="6.01,232,1684825200"; d="scan'208";a="726661966" Received: from wfryca-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.133.1]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 12:28:45 -0700 From: Iwona Winiarska <iwona.winiarska@intel.com> To: openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>, Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>, Tyrone Ting <warp5tw@gmail.com>, Iwona Winiarska <iwona.winiarska@intel.com> Subject: [PATCH v2 1/4] dt-bindings: Add bindings for peci-npcm Date: Wed, 26 Jul 2023 21:27:37 +0200 Message-Id: <20230726192740.1383740-2-iwona.winiarska@intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230726192740.1383740-1-iwona.winiarska@intel.com> References: <20230726192740.1383740-1-iwona.winiarska@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772514312960080983 X-GMAIL-MSGID: 1772514312960080983 |
Series |
Add support for PECI Nuvoton
|
|
Commit Message
Winiarska, Iwona
July 26, 2023, 7:27 p.m. UTC
From: Tomer Maimon <tmaimon77@gmail.com> Add device tree bindings for the peci-npcm controller driver. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> Signed-off-by: Tyrone Ting <warp5tw@gmail.com> Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> --- Changes v1 -> v2: * Renamed binding filename to match compatible (Krzysztof) --- .../bindings/peci/nuvoton,npcm-peci.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml
Comments
On 26/07/2023 21:27, Iwona Winiarska wrote: > From: Tomer Maimon <tmaimon77@gmail.com> > > Add device tree bindings for the peci-npcm controller driver. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > --- > Changes v1 -> v2: > > * Renamed binding filename to match compatible (Krzysztof) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 26 Jul 2023 21:27:37 +0200, Iwona Winiarska wrote: > From: Tomer Maimon <tmaimon77@gmail.com> > > Add device tree bindings for the peci-npcm controller driver. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > --- > Changes v1 -> v2: > > * Renamed binding filename to match compatible (Krzysztof) > --- > .../bindings/peci/nuvoton,npcm-peci.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/peci/peci-npcm.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230726192740.1383740-2-iwona.winiarska@intel.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 26/07/2023 21:39, Krzysztof Kozlowski wrote: > On 26/07/2023 21:27, Iwona Winiarska wrote: >> From: Tomer Maimon <tmaimon77@gmail.com> >> >> Add device tree bindings for the peci-npcm controller driver. >> >> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> >> Signed-off-by: Tyrone Ting <warp5tw@gmail.com> >> Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> >> Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> >> --- >> Changes v1 -> v2: >> >> * Renamed binding filename to match compatible (Krzysztof) > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Un-reviewed. Why testing the code before sending to LKML? Obviously not needed. Best regards, Krzysztof
On Wed, 2023-07-26 at 14:14 -0600, Rob Herring wrote: > > On Wed, 26 Jul 2023 21:27:37 +0200, Iwona Winiarska wrote: > > From: Tomer Maimon <tmaimon77@gmail.com> > > > > Add device tree bindings for the peci-npcm controller driver. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > --- > > Changes v1 -> v2: > > > > * Renamed binding filename to match compatible (Krzysztof) > > --- > > .../bindings/peci/nuvoton,npcm-peci.yaml | 56 +++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm- > > peci.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml: $id: > Cannot determine base path from $id, relative path/filename doesn't match > actual path or filename > $id: http://devicetree.org/schemas/peci/peci-npcm.yaml > file: /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml Oops, sorry about that - I'll send v3. Thanks -Iwona > > doc reference errors (make refcheckdocs): > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230726192740.1383740-2-iwona.winiarska@intel.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
diff --git a/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml b/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml new file mode 100644 index 000000000000..6eafa9ccaa54 --- /dev/null +++ b/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/peci/peci-npcm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton PECI Bus + +maintainers: + - Tomer Maimon <tmaimon77@gmail.com> + +allOf: + - $ref: peci-controller.yaml# + +properties: + compatible: + enum: + - nuvoton,npcm750-peci + - nuvoton,npcm845-peci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + description: + Clock source for PECI controller. Should reference the APB clock. + maxItems: 1 + + cmd-timeout-ms: + minimum: 1 + maximum: 1000 + default: 1000 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + peci-controller@f0100000 { + compatible = "nuvoton,npcm750-peci"; + reg = <0xf0100000 0x200>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk NPCM7XX_CLK_APB3>; + cmd-timeout-ms = <1000>; + }; +...