From patchwork Wed Jul 26 18:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 126252 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp303324vqo; Wed, 26 Jul 2023 03:28:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlFAK26QV4qaQJ5HJi/XZKEz+IsPK1SDT7gG1ctEdd+4ZjXTsaEaPtNBaoVolUyP1Xk3KLR6 X-Received: by 2002:a05:6a21:7746:b0:132:8620:8d21 with SMTP id bc6-20020a056a21774600b0013286208d21mr1684793pzc.58.1690367282579; Wed, 26 Jul 2023 03:28:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690367282; cv=none; d=google.com; s=arc-20160816; b=ABNGS76xASISeGJv1fjylT8S2PZPDOsDxyE4AQtieoI9bdiUyXolBtNoq0PbZQFa7E SEX6Ln5ILA1YCDXO2IhmDH39NQTcD1bo0xmyeDa3dRxpU4XS3GDy8VkquXiCPzGvOXgc 7f8/MXucsP9yyi8ACJhXmx11cIfL/H2RfoT1YSs+LSwyynrZ2H5SvczNRrezZ6muEK3i N5gvG/EiDJ+6h9jyafrCPR4VdCM4bYuBhN4UL7waeww+HVuSj5tp6uNJ0QRVU87mivkb Lsx+m68ZHwLXe4470+HLR3kq5AA6zWgqWkTkKiYB1UoyFwfj7LvRJ9wD6k0nAXHQYMSi Buzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EC8lxJCiIwlMWdUciMSvltfiU+9EB9rnaz6NRgFiFqk=; fh=Tg66vRFRAY1b6Au3bhKuhGCi/RzmMcfK0faRev1TJiI=; b=X7L19QpwIQ8RBFEBPelurUD5/QGKAUu396iFcRrkGE1ORLyQMq8MEjwiMV7xBWAw52 9VO+P3g4XxLIjeAXhT314kHgqMrfSlb3sxlRNaxIEqbsnGKuYaAk8jKES0iDd+GuMpl4 OuOh7tVBPlBJkyRJn0uXIU1VG+48LiOH+TRO3plbYrSw0BUhsUrjK25GYQKG0y5laAr0 zcCTckgNP254UnTgtdK9tLGxHJT2yqmhUTbkjRgl+0oiqVYtQ6Ww+3Nu413RdmAT/CLd q5ei+6SXyOYN/m7qSERVNkRigbDC0fT5foKU5VuN+0F/kHjdPL+SMYa8k8F3uBL6Kyl0 aGmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r22-20020a638f56000000b00563c54dfb6esi4061110pgn.205.2023.07.26.03.27.48; Wed, 26 Jul 2023 03:28:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233324AbjGZKGo (ORCPT + 99 others); Wed, 26 Jul 2023 06:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233134AbjGZKGe (ORCPT ); Wed, 26 Jul 2023 06:06:34 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B9841FFC for ; Wed, 26 Jul 2023 03:06:28 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4R9qHB3k95zLnhH; Wed, 26 Jul 2023 18:03:50 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 26 Jul 2023 18:06:25 +0800 From: Ruan Jinjie To: , , CC: Subject: [PATCH v2 -next] misc: hi6421-spmi-pmic: Remove redundant dev_err() Date: Wed, 26 Jul 2023 18:07:07 +0000 Message-ID: <20230726180707.2486808-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772473853560019112 X-GMAIL-MSGID: 1772478563621484156 There is no need to call the dev_err() function directly to print a custom message when handling an error from the platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie --- v2: - fix the coding style errors --- drivers/misc/hi6421v600-irq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c index caa3de37698b..b075d803a2c2 100644 --- a/drivers/misc/hi6421v600-irq.c +++ b/drivers/misc/hi6421v600-irq.c @@ -244,10 +244,8 @@ static int hi6421v600_irq_probe(struct platform_device *pdev) pmic_pdev = container_of(pmic_dev, struct platform_device, dev); priv->irq = platform_get_irq(pmic_pdev, 0); - if (priv->irq < 0) { - dev_err(dev, "Error %d when getting IRQs\n", priv->irq); + if (priv->irq < 0) return priv->irq; - } platform_set_drvdata(pdev, priv);