Message ID | 20230726180035.14511-1-tiwai@suse.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp592396vqo; Wed, 26 Jul 2023 11:40:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlEe7IZPRNbP91CYcqJ+pICvIdV5WTKYI3WXO2kwoYgj9TpU92OJJdXudGfw8m9qdr6t0it/ X-Received: by 2002:a05:6358:a088:b0:138:3b4f:7b87 with SMTP id u8-20020a056358a08800b001383b4f7b87mr3339890rwn.8.1690396856574; Wed, 26 Jul 2023 11:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690396856; cv=none; d=google.com; s=arc-20160816; b=CeDKbLpcfxGhkECrc4SnqTIUU7NdNXKbAicjPLUcbFiUq/7XiVluirrT/k95PDcV19 cXbT2QMNWgZHYAIklXyu3GyHYmvwMBxd+m4DCzeI8FK4lRKPJKpJPUFV9cq2Wb0HJXP+ MWxIik7TVHdE5JvSbOOjjfTVCbfVp6TD3DnN/7om8pHg7/7s2ZXtKVwzaSmyUYOSw0D/ 7j/Bi/GothgHWOPhZe5wOWa2dUANFVoQGKIJHkR+ixj4nNDOEmpvY8/VyvGs4Fy0x/Mv l5mABF+lQrA+V09UhmMyHntu4ATmfsMEmQDGpxhnFqzgfZ5m2YFes5WpeWpUxUvdMVbh LLmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=TqlDrc5/V+1K3oBFV9SbyP3zzx8dsHJ2zSPzAn31Vhk=; fh=RuF1cbOorgPadfDPuYUevUxt8BI25/qN2wnjpDuB0Qc=; b=ynF0HwQklRKdYJC7l6FYhRUg89DLR13sqQbnbGrwK0kIp4SUGjRQYujAiDToQB5No/ sCn3/xpAa7SBK8l2em5wQzSLbLcmXMS6DWcvfVhDaFDe/qOSkkIroWUR8hYcVE7DXq4O O1XC7q1Veruvr7yq34scbbX/nKPFYda9wbo/ivWiej49ovdXIb1RCUXvwj/6+5ocby5d gGy+lvLcZ6wMnKkiAcfmQtNew2donFuzsxo+vMRQdnrXwieyvMgIukkqsjPfR7UMUpwE gz4SXEAvXeXL3/vHIWKLrbb6dZZu5J4NQBafz8DWJ0TxDvbSBse5OKUvTlCeIQEyfp1p VvzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XvIRLju9; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e25-20020a633719000000b00563e5fce0e3si1362925pga.541.2023.07.26.11.40.43; Wed, 26 Jul 2023 11:40:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=XvIRLju9; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbjGZSAp (ORCPT <rfc822;kloczko.tomasz@gmail.com> + 99 others); Wed, 26 Jul 2023 14:00:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231213AbjGZSAm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Jul 2023 14:00:42 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 739B1269E; Wed, 26 Jul 2023 11:00:41 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3120B1F74D; Wed, 26 Jul 2023 18:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690394440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TqlDrc5/V+1K3oBFV9SbyP3zzx8dsHJ2zSPzAn31Vhk=; b=XvIRLju9S7fZKtnKyeQhJqFxHqmNrE9C01YY14wyR3N63wGOPB5yD3lu1pnexwHCo6F+D9 2aLbyUGLXIgUrL/lduMFAavRjDQpLZMieCWVUVFDEgOPo7+85+LjeNbbdEhA0iFcqgb1pm TDEsz+r74BUK/HZxx2hRfmxM4u+l0iE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690394440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TqlDrc5/V+1K3oBFV9SbyP3zzx8dsHJ2zSPzAn31Vhk=; b=IfsSdckhp8yxUmpOvDZZZKR8c2m/xpPGGQ/0716R2Ccu31/Q9+reEi8vOF02CIQ1gWVX1S 1VHphGH7xvi4bOCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F1E78139BD; Wed, 26 Jul 2023 18:00:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gCEBOkdfwWQGcQAAMHmgww (envelope-from <tiwai@suse.de>); Wed, 26 Jul 2023 18:00:39 +0000 From: Takashi Iwai <tiwai@suse.de> To: Peter Huewe <peterhuewe@gmx.de>, Jarkko Sakkinen <jarkko@kernel.org> Cc: Jason Gunthorpe <jgg@ziepe.ca>, Lino Sanfilippo <l.sanfilippo@kunbus.com>, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7 Date: Wed, 26 Jul 2023 20:00:35 +0200 Message-Id: <20230726180035.14511-1-tiwai@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772509574507402698 X-GMAIL-MSGID: 1772509574507402698 |
Series |
tpm/tpm_tis: Disable interrupts for TUXEDO InfinityBook S 15/17 Gen7
|
|
Commit Message
Takashi Iwai
July 26, 2023, 6 p.m. UTC
TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on
tpm_tis like a few other laptops. Add an entry for the workaround.
Cc: stable@vger.kernel.org
Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/char/tpm/tpm_tis.c | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote: > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on > tpm_tis like a few other laptops. Add an entry for the workaround. > > Cc: stable@vger.kernel.org > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645 > Signed-off-by: Takashi Iwai <tiwai@suse.de> > --- > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index cc42cf3de960..a98773ac2e55 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > }, > }, > + { > + .callback = tpm_tis_disable_irq, > + .ident = "TUXEDO InfinityBook S 15/17 Gen7", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"), > + }, > + }, > { > .callback = tpm_tis_disable_irq, > .ident = "UPX-TGL", > -- > 2.35.3 Hi does this occur with the latest linux-next and/or v6.5-rc3? BR, Jarkko
On Fri, 28 Jul 2023 21:24:30 +0200, Jarkko Sakkinen wrote: > > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote: > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on > > tpm_tis like a few other laptops. Add an entry for the workaround. > > > > Cc: stable@vger.kernel.org > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645 > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > > --- > > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > > index cc42cf3de960..a98773ac2e55 100644 > > --- a/drivers/char/tpm/tpm_tis.c > > +++ b/drivers/char/tpm/tpm_tis.c > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > > }, > > }, > > + { > > + .callback = tpm_tis_disable_irq, > > + .ident = "TUXEDO InfinityBook S 15/17 Gen7", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"), > > + }, > > + }, > > { > > .callback = tpm_tis_disable_irq, > > .ident = "UPX-TGL", > > -- > > 2.35.3 > > Hi does this occur with the latest linux-next and/or v6.5-rc3? Not tested yet, but do you have any relevant fix except for the commit 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled IRQs")? That commit was already tested, at least. thanks, Takashi
On Sat, 29 Jul 2023 09:06:26 +0200, Takashi Iwai wrote: > > On Fri, 28 Jul 2023 21:24:30 +0200, > Jarkko Sakkinen wrote: > > > > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote: > > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on > > > tpm_tis like a few other laptops. Add an entry for the workaround. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645 > > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > > > --- > > > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > > > index cc42cf3de960..a98773ac2e55 100644 > > > --- a/drivers/char/tpm/tpm_tis.c > > > +++ b/drivers/char/tpm/tpm_tis.c > > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > > > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > > > }, > > > }, > > > + { > > > + .callback = tpm_tis_disable_irq, > > > + .ident = "TUXEDO InfinityBook S 15/17 Gen7", > > > + .matches = { > > > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"), > > > + }, > > > + }, > > > { > > > .callback = tpm_tis_disable_irq, > > > .ident = "UPX-TGL", > > > -- > > > 2.35.3 > > > > Hi does this occur with the latest linux-next and/or v6.5-rc3? > > Not tested yet, but do you have any relevant fix except for the commit > 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled > IRQs")? That commit was already tested, at least. And now it's confirmed that the problem persists with 6.5-rc3. thanks, Takashi
On Sat Jul 29, 2023 at 7:06 AM UTC, Takashi Iwai wrote: > On Fri, 28 Jul 2023 21:24:30 +0200, > Jarkko Sakkinen wrote: > > > > On Wed Jul 26, 2023 at 6:00 PM UTC, Takashi Iwai wrote: > > > TUXEDO InfinityBook S 15/17 Gen7 suffers from an IRQ problem on > > > tpm_tis like a few other laptops. Add an entry for the workaround. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1213645 > > > Signed-off-by: Takashi Iwai <tiwai@suse.de> > > > --- > > > drivers/char/tpm/tpm_tis.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > > > index cc42cf3de960..a98773ac2e55 100644 > > > --- a/drivers/char/tpm/tpm_tis.c > > > +++ b/drivers/char/tpm/tpm_tis.c > > > @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > > > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > > > }, > > > }, > > > + { > > > + .callback = tpm_tis_disable_irq, > > > + .ident = "TUXEDO InfinityBook S 15/17 Gen7", > > > + .matches = { > > > + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"), > > > + }, > > > + }, > > > { > > > .callback = tpm_tis_disable_irq, > > > .ident = "UPX-TGL", > > > -- > > > 2.35.3 > > > > Hi does this occur with the latest linux-next and/or v6.5-rc3? > > Not tested yet, but do you have any relevant fix except for the commit > 481c2d14627d ("tpm,tpm_tis: Disable interrupts after 1000 unhandled > IRQs")? That commit was already tested, at least. OK, I will pick this, thank you. Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index cc42cf3de960..a98773ac2e55 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -162,6 +162,14 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), }, }, + { + .callback = tpm_tis_disable_irq, + .ident = "TUXEDO InfinityBook S 15/17 Gen7", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), + DMI_MATCH(DMI_PRODUCT_NAME, "TUXEDO InfinityBook S 15/17 Gen7"), + }, + }, { .callback = tpm_tis_disable_irq, .ident = "UPX-TGL",