diff mbox series

[next] net: ethernet: slicoss: remove redundant increment of pointer data

Message ID 20230726164522.369206-1-colin.i.king@gmail.com
State New
Headers
Series [next] net: ethernet: slicoss: remove redundant increment of pointer data |

Commit Message

Colin Ian King July 26, 2023, 4:45 p.m. UTC 
  The pointer data is being incremented but this change to the pointer
is not used afterwards. The increment is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/net/ethernet/alacritech/slicoss.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Lino Sanfilippo July 26, 2023, 7:16 p.m. UTC | #1 
Hi,

On 26.07.23 18:45, Colin Ian King wrote:
> The pointer data is being incremented but this change to the pointer
> is not used afterwards. The increment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index a30d0f172986..78231c85234d 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -1520,10 +1520,8 @@ static void slic_get_ethtool_stats(struct net_device *dev,
>
>  static void slic_get_strings(struct net_device *dev, u32 stringset, u8 *data)
>  {
> -	if (stringset == ETH_SS_STATS) {
> +	if (stringset == ETH_SS_STATS)
>  		memcpy(data, slic_stats_strings, sizeof(slic_stats_strings));
> -		data += sizeof(slic_stats_strings);
> -	}
>  }
>
>  static void slic_get_drvinfo(struct net_device *dev,

FWIW
Acked-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>

Best Regards,
Lino
Colin Ian King July 27, 2023, 5:15 p.m. UTC | #2 
On 26/07/2023 21:05, Markus Elfring wrote:
>> The pointer data is being incremented but this change to the pointer
>> is not used afterwards. The increment is redundant and can be removed.
> 
> Are imperative change descriptions still preferred?

Hrm, I've used this style of commit message for a few thousand commits, 
I hope it's still fine.

> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94
> 
> Regards,
> Markus
patchwork-bot+netdevbpf@kernel.org July 28, 2023, 11:30 p.m. UTC | #3 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 26 Jul 2023 17:45:22 +0100 you wrote:
> The pointer data is being incremented but this change to the pointer
> is not used afterwards. The increment is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
  - [next] net: ethernet: slicoss: remove redundant increment of pointer data
    https://git.kernel.org/netdev/net-next/c/3bdd85e2e350

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index a30d0f172986..78231c85234d 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -1520,10 +1520,8 @@  static void slic_get_ethtool_stats(struct net_device *dev,
 
 static void slic_get_strings(struct net_device *dev, u32 stringset, u8 *data)
 {
-	if (stringset == ETH_SS_STATS) {
+	if (stringset == ETH_SS_STATS)
 		memcpy(data, slic_stats_strings, sizeof(slic_stats_strings));
-		data += sizeof(slic_stats_strings);
-	}
 }
 
 static void slic_get_drvinfo(struct net_device *dev,