From patchwork Wed Jul 26 15:02:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herve Codina X-Patchwork-Id: 126444 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp478496vqo; Wed, 26 Jul 2023 08:25:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlHnlViugfvI2Uqv91rjDYch5Klw4VbFEwMtpkgYSAlJjDZDWlFJGG+EGlkVCreuVccTy0MI X-Received: by 2002:a17:903:2586:b0:1bb:a6db:3fd0 with SMTP id jb6-20020a170903258600b001bba6db3fd0mr1968193plb.69.1690385125908; Wed, 26 Jul 2023 08:25:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690385125; cv=none; d=google.com; s=arc-20160816; b=jkdU7jpW790pcc8fchqpMy4zOz5JaL6J24MovzmziqfaRA+hNFkZw1lKCvr09uLg+V rO7BUeYeG3kklmFpVipgq4Jnf9mQbmUW0C5FyexzQjjGS9x/Q/ons5CePIcqZ676tI0C qpsf3wVio79eQQcvIoax20zYxz7YDdFvBdWSsTY0zZXqZwNSr7eVIbi1IZ0WkOj5sTOY 4o0L+yYyBVJ+e2Ci7B4cxlv4TYZpAtNn1iKvmYwOuFTSDuKv6pFkL8JsIiN6a+wmodav kneJZ1uquzBUTumDxa8mfXElgrs7jkT0l1bGINkPbaPIYXNvkJMOubOE15WqnT7OVffY sSVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TM7wd8IvbKAXtTToSFnkMUqrf+VfWQDZSu7O62nFJwU=; fh=OtJVFpZ5Y8/ND7g8QcUIbRSFhG4LznwcYYtG4zWKevM=; b=dQWpnebQTOOvQha3gDTIu9grgG3Cgu2Vngze0pWYzUfL6qS8dDOEeMjDbzxc6z/qNR 4eqvZmm9D3PRTtmNiD/sfUICb936VBI4oRfGEXi/dx+VcXNrTIs5OHiaWVs2U+x5q2Im pJpbQvm33RYOQxjLBXpzVM59VA7O/v3jk4NIuuUg9tdKHUcvYEt8X8a9R0TpHH3X/tKP wIivAGEQansdPFmHJyrA2G03ho9qG/pBNpu5/ZHCc2dl93BS2Xg9YGinYOLQVhrJhKPd NhZAP6dFNgrSBznu50sTWUiV+AmyiU8qSQfJ9+jJ9IOdi7W1E59kzW1ma1VqAQL56CYH i/7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QJxVFyM1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n18-20020a170902e55200b001b5fc11ea09si14370516plf.94.2023.07.26.08.25.11; Wed, 26 Jul 2023 08:25:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=QJxVFyM1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234722AbjGZPFR (ORCPT + 99 others); Wed, 26 Jul 2023 11:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234654AbjGZPE4 (ORCPT ); Wed, 26 Jul 2023 11:04:56 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EE072D4D; Wed, 26 Jul 2023 08:04:22 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPA id E09541C0009; Wed, 26 Jul 2023 15:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690383820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TM7wd8IvbKAXtTToSFnkMUqrf+VfWQDZSu7O62nFJwU=; b=QJxVFyM1IQWxyDV+BnoV2NIni9kGpe/z8VXoIga7m8CTfcKkgpfnI4doAdyMbz/pM6Tt0v 6caJaSUt056a5ABQ8OKaxDMtcIqhR8amPCBqdiGWUqTyO0Peeogdc8706KVt+/PTvWi6Pq d0XTm4+W8kKlHuaapAz9axDp2EOhyrao7fZSvoe6ydtVTqOuxFFSZXxSOIJibdQv/IDdff aBNmB9e0uBw1mALX7r7jdcno+23qjCndgVYYo/2cJJgK9UQ4pYuasmEtZRujtvMRgPyZRg I0zC4ONkrn71Nl5Rf/6j9eB1JDq9Yj82fMosgf0bYH67j+vTggJkpNMZLEsZSA== From: Herve Codina To: Herve Codina , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: [PATCH v2 17/28] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Date: Wed, 26 Jul 2023 17:02:13 +0200 Message-ID: <20230726150225.483464-18-herve.codina@bootlin.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230726150225.483464-1-herve.codina@bootlin.com> References: <20230726150225.483464-1-herve.codina@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772497273694656101 X-GMAIL-MSGID: 1772497273694656101 Timeslots setting is done at channel start() and stop(). There is no more need to do that during setup_chan(). Simply remove timeslot setting from setup_chan(). Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy --- drivers/soc/fsl/qe/qmc.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index 258a34641551..b1883b9d2bae 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -723,30 +723,6 @@ static int qmc_chan_setup_tsa_rx(struct qmc_chan *chan, bool enable) return qmc_chan_setup_tsa_32rx(chan, &info, enable); } -static int qmc_chan_setup_tsa(struct qmc_chan *chan, bool enable) -{ - struct tsa_serial_info info; - int ret; - - /* Retrieve info from the TSA related serial */ - ret = tsa_serial_get_info(chan->qmc->tsa_serial, &info); - if (ret) - return ret; - - /* - * Setup one common 64 entries table or two 32 entries (one for Tx - * and one for Tx) according to assigned TS numbers. - */ - if (chan->qmc->is_tsa_64rxtx) - return qmc_chan_setup_tsa_64rxtx(chan, &info, enable); - - ret = qmc_chan_setup_tsa_32rx(chan, &info, enable); - if (ret) - return ret; - - return qmc_chan_setup_tsa_32tx(chan, &info, enable); -} - static int qmc_chan_command(struct qmc_chan *chan, u8 qmc_opcode) { return cpm_command(chan->id << 2, (qmc_opcode << 4) | 0x0E); @@ -1323,10 +1299,6 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan) chan->qmc = qmc; - ret = qmc_chan_setup_tsa(chan, true); - if (ret) - return ret; - /* Set channel specific parameter base address */ chan->s_param = qmc->dpram + (chan->id * 64); /* 16 bd per channel (8 rx and 8 tx) */