Message ID | 20230726140635.2059334-10-j.granados@samsung.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp448803vqo; Wed, 26 Jul 2023 07:39:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlERRPqxKGHycMhjsjs8pwhvBZvZY1Tfx9pCuDG9BHGByTHXQIYefArceTe2IP/DGw1Xh/Rk X-Received: by 2002:a17:902:bb81:b0:1b9:d38d:efb1 with SMTP id m1-20020a170902bb8100b001b9d38defb1mr2541803pls.8.1690382342901; Wed, 26 Jul 2023 07:39:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690382342; cv=none; d=google.com; s=arc-20160816; b=NQcQhQ05fd/UEkux4w+kyHlhxTFbPCDlKA79mSLGoKwg3i7vua3BhsU6Zd/NVYIsyu m3bHVwIMOaICxmR8mv+4QLIK5BzA9ahOiHKUF6yJfc3Oj25agzPtc5eM86V/qIxFKylW 3k+e6xqbdLFn3Wr1cAgFdxW4yYq8+bmZWPKpwutKPlSPz0NmqivJT2wzhKYKwsk8f55N e4UewM+OGInlzCmbyQAce3RS7dPbyI+2Mz7ntVk6ctf5k5kdZCeAloEWKzhyJblO2/lu rYHSO2yCmMXo3XQfC2tldxh/L9w/FqINwP5vXkXXTbm78hf+efqoPftAQ66XL7yntF1M d9wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:cms-type:content-transfer-encoding :mime-version:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=Nj7Ghn+kSOTETzoJsaSu9wi1agkqgAyigWTwaRVhj0w=; fh=OVeYfnBxXlDox63uqyeWn9qKIoQLYDkugtl2zbRbeNw=; b=pVbZRWsZ81caEI50PnpBIHseFuIY9McB+fndDWY0bJCETf4pIaocUH0FUF2nTyLLJm zkxXb2nagF+RKkbziJxJp3b92828L6BPRbI3uFpGo+y7oE6xP/DHuwISRQXkP0lhTeS1 Nilt1V/Wayv5xwKdBRQmb2AxQlqvxyp21a144GmR2CoLICQnnhm17HqmRNHscfsb8S+g K49MWWIWJHmNpGQUN8Sy8TeRiu9QVqoqqvOpvidf/E+ANtpEOVhMEArLVFOTqF2w8/WI 2G/LDXxlWK5HF3vIytFXCApfbrH5ARQwFJB9QaNVe8NUHB4vOomodKG38dJC586sYGtp fxBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="HbnW/01M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l13-20020a170903120d00b001b04741042csi14045358plh.93.2023.07.26.07.38.47; Wed, 26 Jul 2023 07:39:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="HbnW/01M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234393AbjGZOIX (ORCPT <rfc822;kloczko.tomasz@gmail.com> + 99 others); Wed, 26 Jul 2023 10:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234084AbjGZOHZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Jul 2023 10:07:25 -0400 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B59D62D5D for <linux-kernel@vger.kernel.org>; Wed, 26 Jul 2023 07:07:05 -0700 (PDT) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230726140704euoutp02786645ca45e9512efadf0fd3cc8bfa5c~1cApBt-Ft1608116081euoutp02J for <linux-kernel@vger.kernel.org>; Wed, 26 Jul 2023 14:07:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230726140704euoutp02786645ca45e9512efadf0fd3cc8bfa5c~1cApBt-Ft1608116081euoutp02J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1690380424; bh=Nj7Ghn+kSOTETzoJsaSu9wi1agkqgAyigWTwaRVhj0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HbnW/01MMcRCUhrsw3LYP6YjvDlXVP1MYApY5uoZdJmbfsrwN26OoN2OHYPgCiOBd 0YucJmFEG67aChRlzsG8aquq5auZfYYNphVIxMK/01giXLTjURJ+6zxGk4TpO7tvCt 6xZXQkBs3Kfs5pzrNM3yGS9pXvThzX9I2zh5pxks= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230726140704eucas1p100b74ffbb75f5a4cb26bcfdedf619471~1cAornRKb2261122611eucas1p1p; Wed, 26 Jul 2023 14:07:04 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 8B.F6.11320.78821C46; Wed, 26 Jul 2023 15:07:04 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230726140703eucas1p2786577bcc67d5ae434671dac11870c60~1cAn-_eJa0080000800eucas1p2s; Wed, 26 Jul 2023 14:07:03 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230726140703eusmtrp262155482faef2d00243300fa4bb51762~1cAn-O03L2063520635eusmtrp2F; Wed, 26 Jul 2023 14:07:03 +0000 (GMT) X-AuditID: cbfec7f4-993ff70000022c38-43-64c128872c53 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 87.57.14344.78821C46; Wed, 26 Jul 2023 15:07:03 +0100 (BST) Received: from localhost (unknown [106.210.248.223]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230726140703eusmtip2325884d0d96c3ee20ec7922d060314b9~1cAn01PTT2007220072eusmtip2H; Wed, 26 Jul 2023 14:07:03 +0000 (GMT) From: Joel Granados <j.granados@samsung.com> To: mcgrof@kernel.org, Joerg Reuter <jreuter@yaina.de>, Ralf Baechle <ralf@linux-mips.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com> Cc: willy@infradead.org, keescook@chromium.org, josh@joshtriplett.org, Joel Granados <j.granados@samsung.com>, linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/14] ax.25: Update to register_net_sysctl_sz Date: Wed, 26 Jul 2023 16:06:29 +0200 Message-Id: <20230726140635.2059334-10-j.granados@samsung.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230726140635.2059334-1-j.granados@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLKsWRmVeSWpSXmKPExsWy7djP87odGgdTDM58ZbSYc76FxeLpsUfs Fkv3P2S0+L8g3+JnH7fFme5ciwvb+lgtrm2/y2RxedccNosbE54yWhxbIGbx7fQbRotLe1Qs fv+Yw+bA5zG74SKLx5aVN5k8Fmwq9di8Qsvj1mtbj02rOtk8jq5cy+Txft9VNo++LasYPT5v kvN4M+01UwB3FJdNSmpOZllqkb5dAlfG4buT2ArWsVf8+fmYvYFxJlsXIyeHhICJxPGJd9i7 GLk4hARWMEr83PiEGcL5wigx6W8PI0iVkMBnRomN621gOs49OQtVtJxRYu3X14wQzktGiYm3 Z4DNZRPQkTj/5g5YlYjAB0aJ9qcHwKqYBQ4zSnz92cUOUiUsYCfxaPlLsA4WAVWJpXfnsIDY vEDxnqutUBfKS7Rdnw52BydQfOXa76wQNYISJ2c+AatnBqpp3jobbJuEQDenxJ+fF1khml0k tsz9xw5hC0u8Or4FypaR+L9zPhNEw2RGif3/PrBDOKsZJZY1fmWCqLKWaLnyBCjBAbRCU2L9 Ln2IsKPEmZ4drCBhCQE+iRtvBSGO4JOYtG06M0SYV6KjTQiiWkWib+kUFghbSuL65Z1Qf3lI PL55jXkCo+IsJO/MQvLOLIS9CxiZVzGKp5YW56anFhvlpZbrFSfmFpfmpesl5+duYgSmuNP/ jn/Zwbj81Ue9Q4xMHIyHGCU4mJVEeA1j9qUI8aYkVlalFuXHF5XmpBYfYpTmYFES59W2PZks JJCeWJKanZpakFoEk2Xi4JRqYBL5U/1x+uHj86pZQ1YLRyxPyOfcuOfUvLVrBTTPbLpfeG2X ztITO26oL/L0qL114OoG9zJO1Umt/5782/66MVW1oEEs6dE+zdNf/0UYKRieY5uYqyLu8HFF kOLBep9Uq6V9vN4isZqn3D4/6d8RYvyhY+/v1oqWy1qTdxTe2XrnY5LJksq7b/02u/0W/j2r ZVqn7zqunRaCKTWXthzaoVD77uXHzAVv9W0Ct/7bt0rr1t6VOl9Lv7Js38u27pWX6a1Hzu/i dc6Kvuoz3HKd58YVr/4pU0UeH3I71rHww6f6x+9L9+VX18TUft55PCL954Fg7YkdV4rWnb6t NKH7bZHk1rC1n1vr4pdVvvnB/6/ynBJLcUaioRZzUXEiACR2UqXgAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsVy+t/xe7rtGgdTDNbfFLaYc76FxeLpsUfs Fkv3P2S0+L8g3+JnH7fFme5ciwvb+lgtrm2/y2RxedccNosbE54yWhxbIGbx7fQbRotLe1Qs fv+Yw+bA5zG74SKLx5aVN5k8Fmwq9di8Qsvj1mtbj02rOtk8jq5cy+Txft9VNo++LasYPT5v kvN4M+01UwB3lJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllq kb5dgl7G4buT2ArWsVf8+fmYvYFxJlsXIyeHhICJxLknZ5m7GLk4hASWMkpc6TjL2sXIAZSQ kvi+jBOiRljiz7UuNoia54wSF5bfB2tmE9CROP/mDliziMA3RokJVy8ygiSYBU4zSnQfkgCx hQXsJB4tfwnWwCKgKrH07hwWEJsXKN5ztRXqCnmJtuvTwXo5geIr135nBbGFBGwleqY+ZYeo F5Q4OfMJC8R8eYnmrbOZJzAKzEKSmoUktYCRaRWjSGppcW56brGRXnFibnFpXrpecn7uJkZg HG479nPLDsaVrz7qHWJk4mA8xCjBwawkwmsYsy9FiDclsbIqtSg/vqg0J7X4EKMp0N0TmaVE k/OBiSCvJN7QzMDU0MTM0sDU0sxYSZzXs6AjUUggPbEkNTs1tSC1CKaPiYNTqoFpguO8pcn7 ND9mlgbnxfP82Cv71J1d/6hr6n3eDnOPeIWdu3kaDkfeC5rXfJlTpKt8k5MK050p+zpXThJf ePvfDtYXU+IZTzR5xho/lsmTqVTOd1UO7Q9afnmKMkf8r1tfd1pk/Fm0NsVc1DhGlnPGEz4m 970lzC9+n/Da0qlhFsjisue25PfVvs2m95YsZqiP/lUycduFM9knVspOfKQSJbiFtafzh7+3 eC6XM/PEbz5TJ3oZ+bbNDl1/STXOdK5qq93e3tJyvpRN+ktXm809/VjL9ZWGi56/baiQ6sby BZf/q+rtu7wrcyWfhnawUeediN70p4d3ftSJ9Zx0s5H9nnbrvq6ELbzWRUaTZJVYijMSDbWY i4oTASZ3r8BMAwAA X-CMS-MailID: 20230726140703eucas1p2786577bcc67d5ae434671dac11870c60 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20230726140703eucas1p2786577bcc67d5ae434671dac11870c60 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230726140703eucas1p2786577bcc67d5ae434671dac11870c60 References: <20230726140635.2059334-1-j.granados@samsung.com> <CGME20230726140703eucas1p2786577bcc67d5ae434671dac11870c60@eucas1p2.samsung.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772494355851663359 X-GMAIL-MSGID: 1772494355851663359 |
Series |
[01/14] sysctl: Prefer ctl_table_header in proc_sysctl
|
|
Commit Message
Joel Granados
July 26, 2023, 2:06 p.m. UTC
This is part of the effort to remove the sentinel (last empty) element
from the ctl_table arrays. We update to the new function and pass it the
array size.
Signed-off-by: Joel Granados <j.granados@samsung.com>
---
net/ax25/sysctl_net_ax25.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Wed, Jul 26, 2023 at 04:06:29PM +0200, Joel Granados wrote: > This is part of the effort to remove the sentinel (last empty) element > from the ctl_table arrays. We update to the new function and pass it the > array size. The commit log does not explain why. It also does not explain if there is any delta on size at compile or runtime. Luis
On Wed, Jul 26, 2023 at 11:00:37AM -0700, Luis Chamberlain wrote: > On Wed, Jul 26, 2023 at 04:06:29PM +0200, Joel Granados wrote: > > This is part of the effort to remove the sentinel (last empty) element > > from the ctl_table arrays. We update to the new function and pass it the > > array size. > > The commit log does not explain why. It also does not explain if there I'll add the "why". > is any delta on size at compile or runtime. There are no deltas in this patch set. We start seeing the deltas when we start removing with the next 6 chunks. I'll try to make that more clear in the commit message. > > Luis thx for the feedback
On Wed, Jul 26, 2023 at 11:00:37AM -0700, Luis Chamberlain wrote: > On Wed, Jul 26, 2023 at 04:06:29PM +0200, Joel Granados wrote: > > This is part of the effort to remove the sentinel (last empty) element > > from the ctl_table arrays. We update to the new function and pass it the > > array size. > > The commit log does not explain why. It also does not explain if there > is any delta on size at compile or runtime. Just to be on the same page: You mean the specific why for this commit. like for example: " We update to register_net_sysctl_sz to prepare for when the ctl_table array sentinels are removed. " right? > > Luis
On Thu, Jul 27, 2023 at 02:31:12PM +0200, Joel Granados wrote: > There are no deltas in this patch set. We start seeing the deltas when > we start removing with the next 6 chunks. I'll try to make that more > clear in the commit message. Indeed, even if no deltas are created it is importan then to say that. If there are no deltas the "why" becomes more important. If the why is to make it easier to apply subsequent patches, that must be said. When you iterate your new series try to review the patches as if you were not the person submitting them, and try to think of ways to make it easier for the patch reviewer to do less work. The less work and easier patch review is the better for them. Luis
On Thu, Jul 27, 2023 at 05:38:04PM +0200, Joel Granados wrote: > On Wed, Jul 26, 2023 at 11:00:37AM -0700, Luis Chamberlain wrote: > > On Wed, Jul 26, 2023 at 04:06:29PM +0200, Joel Granados wrote: > > > This is part of the effort to remove the sentinel (last empty) element > > > from the ctl_table arrays. We update to the new function and pass it the > > > array size. > > > > The commit log does not explain why. It also does not explain if there > > is any delta on size at compile or runtime. > Just to be on the same page: > You mean the specific why for this commit. like for example: > " > We update to register_net_sysctl_sz I think it is clearer to just say: Move from register_net_sysctl() to register_net_sysctl_sz() > to prepare for when the ctl_table > array sentinels are removed. That is not as clear. I think you should just spell it out. We want to use the syctl ARRAY_SIZE() when possible, and subsequent patches ... now the register_net_sysctl() <does something> while register_net_sysctl_sz() <does something else> and <in this case> this user <does something> and so we must use register_net_sysctl_sz(). > " > > right? Luis
On Thu, Jul 27, 2023 at 08:44:24AM -0700, Luis Chamberlain wrote: > On Thu, Jul 27, 2023 at 02:31:12PM +0200, Joel Granados wrote: > > There are no deltas in this patch set. We start seeing the deltas when > > we start removing with the next 6 chunks. I'll try to make that more > > clear in the commit message. > > Indeed, even if no deltas are created it is importan then to say that. > If there are no deltas the "why" becomes more important. If the why is > to make it easier to apply subsequent patches, that must be said. When yes. The why for this patch set in particular is to make it easier to apply the sentinel removal patches. I think the difficulty for me comes from having two whys: 1. The one for this patch set which is to make it easier to apply sentinel removal patches. And 2. The one for the "big" patch (that actually removes the sentinels) which is to reduce build time size and run time memory bloat. > you iterate your new series try to review the patches as if you were not > the person submitting them, and try to think of ways to make it easier > for the patch reviewer to do less work. The less work and easier patch > review is the better for them. Ack. For all these commits I'll try to weave in the two Whys to make the review process a bit easier. > > Luis
On Fri, Jul 28, 2023 at 09:35:36AM +0200, Joel Granados wrote: > On Thu, Jul 27, 2023 at 08:44:24AM -0700, Luis Chamberlain wrote: > > On Thu, Jul 27, 2023 at 02:31:12PM +0200, Joel Granados wrote: > > > There are no deltas in this patch set. We start seeing the deltas when > > > we start removing with the next 6 chunks. I'll try to make that more > > > clear in the commit message. > > > > Indeed, even if no deltas are created it is importan then to say that. > > If there are no deltas the "why" becomes more important. If the why is > > to make it easier to apply subsequent patches, that must be said. When > yes. The why for this patch set in particular is to make it easier to > apply the sentinel removal patches. > > I think the difficulty for me comes from having two whys: 1. The one for > this patch set which is to make it easier to apply sentinel removal patches. And 2. > The one for the "big" patch (that actually removes the sentinels) which is to > reduce build time size and run time memory bloat. The 2) is part of the real why, 1) is more of how to do 2) cleanly. But the real why is the savings in memory because we are moving arrays out of kernel/sysctl.c so we don't want to incur a size penalty. The collateral to avoid increasing size in the moves also proves to save us more memory overall, on the ballpark of about 64 bytes per array in the kernel both at runtime and build time. The build time gain is mostly on the __init stuff and so gets freed right away, but since sysctl code always kzallocs the arrays passed we also save 64 bytes per array in the end at runtime. Luis
On Fri, Jul 28, 2023 at 11:16:06AM -0700, Luis Chamberlain wrote: > On Fri, Jul 28, 2023 at 09:35:36AM +0200, Joel Granados wrote: > > On Thu, Jul 27, 2023 at 08:44:24AM -0700, Luis Chamberlain wrote: > > > On Thu, Jul 27, 2023 at 02:31:12PM +0200, Joel Granados wrote: > > > > There are no deltas in this patch set. We start seeing the deltas when > > > > we start removing with the next 6 chunks. I'll try to make that more > > > > clear in the commit message. > > > > > > Indeed, even if no deltas are created it is importan then to say that. > > > If there are no deltas the "why" becomes more important. If the why is > > > to make it easier to apply subsequent patches, that must be said. When > > yes. The why for this patch set in particular is to make it easier to > > apply the sentinel removal patches. > > > > I think the difficulty for me comes from having two whys: 1. The one for > > this patch set which is to make it easier to apply sentinel removal patches. And 2. > > The one for the "big" patch (that actually removes the sentinels) which is to > > reduce build time size and run time memory bloat. > > The 2) is part of the real why, 1) is more of how to do 2) cleanly. But > the real why is the savings in memory because we are moving arrays out > of kernel/sysctl.c so we don't want to incur a size penalty. The > collateral to avoid increasing size in the moves also proves to save us > more memory overall, on the ballpark of about 64 bytes per array in the > kernel both at runtime and build time. The build time gain is mostly > on the __init stuff and so gets freed right away, but since sysctl > code always kzallocs the arrays passed we also save 64 bytes per array > in the end at runtime. Yes. In my new version I have tried to mention both 1 and 2 and differentiate between them. I stuck with the "why" for this patch set is to make it easier to reach 2. I'll send it out today. > > Luis
diff --git a/net/ax25/sysctl_net_ax25.c b/net/ax25/sysctl_net_ax25.c index 2154d004d3dc..db66e11e7fe8 100644 --- a/net/ax25/sysctl_net_ax25.c +++ b/net/ax25/sysctl_net_ax25.c @@ -159,7 +159,8 @@ int ax25_register_dev_sysctl(ax25_dev *ax25_dev) table[k].data = &ax25_dev->values[k]; snprintf(path, sizeof(path), "net/ax25/%s", ax25_dev->dev->name); - ax25_dev->sysheader = register_net_sysctl(&init_net, path, table); + ax25_dev->sysheader = register_net_sysctl_sz(&init_net, path, table, + ARRAY_SIZE(ax25_param_table)); if (!ax25_dev->sysheader) { kfree(table); return -ENOMEM;