Message ID | 20230726135945.260841-3-mlevitsk@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp443886vqo; Wed, 26 Jul 2023 07:31:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlHgfoCTu9AJ0aoP4ppAg+ypunP4Wnm0Y8FZ7hF5WM0GVbUESbIY1U4qHsG94RfYaJcqEcDA X-Received: by 2002:a17:90b:1d0b:b0:268:17aa:8b78 with SMTP id on11-20020a17090b1d0b00b0026817aa8b78mr1766671pjb.20.1690381859691; Wed, 26 Jul 2023 07:30:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690381859; cv=none; d=google.com; s=arc-20160816; b=h0oXqPJ+7OgffnlfDkSLQEfrkJtCsiOgaRu01K7cUQnM24Yq+KOXleDwMoSdUQZQD7 E+hVBl3AISyGsBUAGfEfxd9E/AoxSLL5MgvPz79KR/pbmUXf9NJ4U4n8HioWhCw8mLPD XU7tFH606ppnMmJtlQPH9TV8ae7JImQHUFhXRgi1Fk5y0zl27I2/+2CyD/RdIW+3unFJ mc+vOFEHnnvQRvs/Ro9h9DDyL3KanLjWah8r8wJ2DB+C76xsP0XYINL6a8YcHr2jFu9o Ecw3f0B4NWjQiVin9W8I3BNsQlzotkMZeGahvzNuC+ZgNhF7qoGgOsXmvcUCbO/Iq3u8 EhIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tbgdp6vazrgBiQOoNU+XwHpUdW8J49pFS7u9g5v72P0=; fh=2NfF+VcPdV2h2hRMeHegn63ohbGEV/1oT544guq3jvE=; b=OX/cLPPD/IescEzNO/1ncvNn/7QvIM4FQkardDY1Wu33CEL3ob0x7DDStCQ4M4aW6j fnj562pqPh92LeaW0xyZ/R/ZibBal1LsA2ZAXXHobYSPGLxCcsDETN697+UhStgHrRRb QifkrermaQDqakegkaEPqe45exCgDFJYTwRWrphA8q600dJvdY5M6KbhSv9rSboff2hf eBha/Nj6yZ02OEo6WCOtyVYIzutvwuaCHzozjx23NdIiICD8t+xoPr6bD9lWe4Yy2v+a 2ML4vxnQ4kmt7qNWU6kyiVPpR0I3F051hTjUSVxWVRwWOefo7CyyH4Nujhha2blXhXtK 7ZYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J3OG1tFS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hg9-20020a17090b300900b0026807ec51b2si1174995pjb.53.2023.07.26.07.30.44; Wed, 26 Jul 2023 07:30:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J3OG1tFS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233214AbjGZOBn (ORCPT <rfc822;kloczko.tomasz@gmail.com> + 99 others); Wed, 26 Jul 2023 10:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231417AbjGZOBT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Jul 2023 10:01:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83C502697 for <linux-kernel@vger.kernel.org>; Wed, 26 Jul 2023 07:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690380039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tbgdp6vazrgBiQOoNU+XwHpUdW8J49pFS7u9g5v72P0=; b=J3OG1tFS+MwiF2GlxBJIDTPlNka3R/w4pAy7PX6LV1yPT3swluCCc9XocerYv4mdsKXfAu 9A2zWwGrOju84gzIucuVlCcY9VWlipv8pzOzJnT1inCHUeMzSAMIxODM8m6CpqyIHRQTnU dRI0vWPqKzCyvZ64YSREzrOumoAFH8w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-356-nLfhup3aMnSU8fi3piZYvA-1; Wed, 26 Jul 2023 10:00:33 -0400 X-MC-Unique: nLfhup3aMnSU8fi3piZYvA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDF24830DB5; Wed, 26 Jul 2023 14:00:05 +0000 (UTC) Received: from localhost.localdomain (unknown [10.45.224.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C25B40C2063; Wed, 26 Jul 2023 14:00:02 +0000 (UTC) From: Maxim Levitsky <mlevitsk@redhat.com> To: kvm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Borislav Petkov <bp@alien8.de>, Paolo Bonzini <pbonzini@redhat.com>, Sean Christopherson <seanjc@google.com>, Dave Hansen <dave.hansen@linux.intel.com>, Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>, Maxim Levitsky <mlevitsk@redhat.com> Subject: [PATCH v2 2/3] KVM: x86: VMX: set irr_pending in kvm_apic_update_irr Date: Wed, 26 Jul 2023 16:59:44 +0300 Message-Id: <20230726135945.260841-3-mlevitsk@redhat.com> In-Reply-To: <20230726135945.260841-1-mlevitsk@redhat.com> References: <20230726135945.260841-1-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772493848645105802 X-GMAIL-MSGID: 1772493848645105802 |
Series |
Fix 'Spurious APIC interrupt (vector 0xFF) on CPU#n' issue
|
|
Commit Message
Maxim Levitsky
July 26, 2023, 1:59 p.m. UTC
When the APICv is inhibited, the irr_pending optimization is used.
Therefore, when kvm_apic_update_irr sets bits in the IRR,
it must set irr_pending to true as well.
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
arch/x86/kvm/lapic.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index b17b37e4d4fcd1..a983a16163b137 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -666,8 +666,11 @@ EXPORT_SYMBOL_GPL(__kvm_apic_update_irr); bool kvm_apic_update_irr(struct kvm_vcpu *vcpu, u32 *pir, int *max_irr) { struct kvm_lapic *apic = vcpu->arch.apic; + bool irr_updated = __kvm_apic_update_irr(pir, apic->regs, max_irr); - return __kvm_apic_update_irr(pir, apic->regs, max_irr); + if (unlikely(!apic->apicv_active && irr_updated)) + apic->irr_pending = true; + return irr_updated; } EXPORT_SYMBOL_GPL(kvm_apic_update_irr);