diff mbox series

[v7,1/3] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM with Custom Board

Message ID 20230726123747.4097755-1-james.hilliard1@gmail.com
State New
Headers
Series [v7,1/3] dt-bindings: arm: fsl: Add VAR-SOM-MX6 SoM with Custom Board |

Commit Message

James Hilliard July 26, 2023, 12:37 p.m. UTC 
  Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM with Custom Board.

Cc: Pierluigi Passaro <pierluigi.p@variscite.com>
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski July 26, 2023, 6:23 p.m. UTC | #1 
On 26/07/2023 14:37, James Hilliard wrote:
> Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM with Custom Board.
> 
> Cc: Pierluigi Passaro <pierluigi.p@variscite.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Conor Dooley July 26, 2023, 6:26 p.m. UTC | #2 
On Wed, Jul 26, 2023 at 06:37:39AM -0600, James Hilliard wrote:
> Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM with Custom Board.
> 
> Cc: Pierluigi Passaro <pierluigi.p@variscite.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 2510eaa8906d..76bb098605e7 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -385,6 +385,12 @@ properties:
>            - const: toradex,apalis_imx6q
>            - const: fsl,imx6q
>  
> +      - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> +        items:
> +          - const: variscite,mx6customboard
> +          - const: variscite,var-som-imx6q
> +          - const: fsl,imx6q

I find it hard to tell what the sort order here is meant to be, but it
appears to be first by what I.MX processor and then by the board
compatibles? If so, this is added out of order.

> +
>        - description: TQ-Systems TQMa6Q SoM (variant A) on MBa6x
>          items:
>            - const: tq,imx6q-mba6x-a
> -- 
> 2.34.1
>
James Hilliard Aug. 7, 2023, 4:03 p.m. UTC | #3 
On Wed, Jul 26, 2023 at 12:26 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Jul 26, 2023 at 06:37:39AM -0600, James Hilliard wrote:
> > Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM with Custom Board.
> >
> > Cc: Pierluigi Passaro <pierluigi.p@variscite.com>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 2510eaa8906d..76bb098605e7 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -385,6 +385,12 @@ properties:
> >            - const: toradex,apalis_imx6q
> >            - const: fsl,imx6q
> >
> > +      - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> > +        items:
> > +          - const: variscite,mx6customboard
> > +          - const: variscite,var-som-imx6q
> > +          - const: fsl,imx6q
>
> I find it hard to tell what the sort order here is meant to be, but it
> appears to be first by what I.MX processor and then by the board
> compatibles? If so, this is added out of order.

Ordering follows the same pattern as say the "Variscite VAR-SOM-MX8MM
based boards", should it be different?

>
> > +
> >        - description: TQ-Systems TQMa6Q SoM (variant A) on MBa6x
> >          items:
> >            - const: tq,imx6q-mba6x-a
> > --
> > 2.34.1
> >
Conor Dooley Aug. 8, 2023, 7:45 a.m. UTC | #4 
On Mon, Aug 07, 2023 at 10:03:45AM -0600, James Hilliard wrote:
> On Wed, Jul 26, 2023 at 12:26 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Jul 26, 2023 at 06:37:39AM -0600, James Hilliard wrote:
> > > Add support for Variscite i.MX6Q VAR-SOM-MX6 SoM with Custom Board.
> > >
> > > Cc: Pierluigi Passaro <pierluigi.p@variscite.com>
> > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index 2510eaa8906d..76bb098605e7 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -385,6 +385,12 @@ properties:
> > >            - const: toradex,apalis_imx6q
> > >            - const: fsl,imx6q
> > >
> > > +      - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
> > > +        items:
> > > +          - const: variscite,mx6customboard
> > > +          - const: variscite,var-som-imx6q
> > > +          - const: fsl,imx6q
> >
> > I find it hard to tell what the sort order here is meant to be, but it
> > appears to be first by what I.MX processor and then by the board
> > compatibles? If so, this is added out of order.
> 
> Ordering follows the same pattern as say the "Variscite VAR-SOM-MX8MM
> based boards", should it be different?

What I meant was I was not sure whether things were being sorted by the
contents of the description or by the compatible strings. I don't really
care which it is, I was hoping for an fsl platform maintainer to weigh
in.

If I hadn't already given one,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
for whatever way is opted for.

> > >        - description: TQ-Systems TQMa6Q SoM (variant A) on MBa6x
> > >          items:
> > >            - const: tq,imx6q-mba6x-a
> > > --
> > > 2.34.1
> > >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 2510eaa8906d..76bb098605e7 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -385,6 +385,12 @@  properties:
           - const: toradex,apalis_imx6q
           - const: fsl,imx6q
 
+      - description: i.MX6Q Variscite VAR-SOM-MX6 Boards
+        items:
+          - const: variscite,mx6customboard
+          - const: variscite,var-som-imx6q
+          - const: fsl,imx6q
+
       - description: TQ-Systems TQMa6Q SoM (variant A) on MBa6x
         items:
           - const: tq,imx6q-mba6x-a