From patchwork Wed Jul 26 08:22:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AngeloGioacchino Del Regno X-Patchwork-Id: 126215 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp274332vqo; Wed, 26 Jul 2023 02:19:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlE+PVpC85mdn/iP34wvh+IdNIyLPek4b3L8COpIxyKvMhVMDWwLj07jWTrUFIPVusymt4tP X-Received: by 2002:a05:6a20:5489:b0:12d:d379:6e6c with SMTP id i9-20020a056a20548900b0012dd3796e6cmr2102357pzk.11.1690363145590; Wed, 26 Jul 2023 02:19:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690363145; cv=none; d=google.com; s=arc-20160816; b=JAmp1BQg77d1ONhY/FOiqno1wmuNuRmJne+MN2qktl5k952bpICj2y2WSfLSnyzZUF uVT3cA7fSxyFplEHdRpzDp9GCwUV9uqulC9/RPbQBMp4brVjszTxYry+lt6Ltyb4XJWm KgmguRX8j1rVbVotq5uDHoJO2+Vw7X59AFF5O5UpZvmZHQ4dUe8iBLEXEV7EfQAzO0vj A9rJaeE7kPkTpya3ZGTrMIOfjd6p2HR8mow3ZHwxVsjc39t/zAeKhVGdhppzGCtfykJU dgD/gJqSB08FU578zqAajkdpOdQ1r1jFAAc4pkQji/fY7tqem8Y9b9s5NVbTlF542LiY gGVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w2ThE4UBL1oerTjDLeHGolXrEnWzxXfjV/UoaGXXiV4=; fh=ClSCaUDR6rLSl56scU0nBrZI7ye6UdZxeH0WEDTywT0=; b=dff3ZeKF2CquuqdWf6almkoHJtSer1Ud+EC7WAmuDjUwBeAjEYe4XL0rH0GppaSww7 G+kIX4PqxPIECWb+dxm+y7QXuh/bC7Y2E7tj02Y9kRS3KiOu8ZwZv3TEblYiYUDsnhMK 4VpZ7CiQIRE148LPx6FTa3ROc6hx4JSEKv6zrQey3vjC9oyge0G7scWnuwhotqKLWevF yaEwJcVm6TT+5HwUQkn9ssuLiQUjutLmFRkHEifFGU8cLE+epFninYQygOK4dI1Y6a9k d3F/v7rYq4C1NH6kcux6QNp93zQ3WDPyL1bNX52vGtFNW+7zB2nd0r+m7NpWWTA5eyRn IK8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ixo/92B0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k1-20020a637b41000000b0055c8f4a56d5si12514415pgn.600.2023.07.26.02.18.51; Wed, 26 Jul 2023 02:19:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ixo/92B0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232739AbjGZIdj (ORCPT + 99 others); Wed, 26 Jul 2023 04:33:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233217AbjGZIcf (ORCPT ); Wed, 26 Jul 2023 04:32:35 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 492F96E8E for ; Wed, 26 Jul 2023 01:22:59 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 328296607123; Wed, 26 Jul 2023 09:22:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690359777; bh=fnTCmYsrDDNtkDG9EQwHh0fbSiert+Ttme90qPGoI74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ixo/92B0b4iuNTniChsi9dxG+BxLjIWQ8FWpvz4PiRgpa7+PwlE2/dc+DpgLjk92D S4p20SuBmmRAvyYtQni89CnMSvPlZQKNVam4y4hyG9keJITRDBdBTMnPgRNmcq347b fiIVHXdFqpbT1pjcXh7Go9ZVt37NQRZBpDKJB30nRObUvf1PuP3xhVAK9Zc2CTtgQf KOmB5stsbGzewlJDMVtoLE3HAezbYmbPj/NBGpzMrJUVfWYuQ6mPmZoz3K917ja/v+ bCh9QU9WDRlmO3AW31KqPiJ1ECJ+lJXp/Jm3rjP3JpvkSKV0VzSvBvlGZE70qQYwwk u8EJ5JvOtLexA== From: AngeloGioacchino Del Regno To: chunkuang.hu@kernel.org Cc: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, fshao@chromium.org, CK Hu Subject: [PATCH v3 4/6] drm/mediatek: mtk_dpi: Switch to .remove_new() void callback Date: Wed, 26 Jul 2023 10:22:43 +0200 Message-ID: <20230726082245.550929-5-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230726082245.550929-1-angelogioacchino.delregno@collabora.com> References: <20230726082245.550929-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772474225665525874 X-GMAIL-MSGID: 1772474225665525874 The .remove() callback cannot fail: switch to .remove_new() and change mtk_dpi_remove() to void. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 08822fe88c93..2c95de5539fd 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -1086,11 +1086,9 @@ static int mtk_dpi_probe(struct platform_device *pdev) return 0; } -static int mtk_dpi_remove(struct platform_device *pdev) +static void mtk_dpi_remove(struct platform_device *pdev) { component_del(&pdev->dev, &mtk_dpi_component_ops); - - return 0; } static const struct of_device_id mtk_dpi_of_ids[] = { @@ -1121,7 +1119,7 @@ MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids); struct platform_driver mtk_dpi_driver = { .probe = mtk_dpi_probe, - .remove = mtk_dpi_remove, + .remove_new = mtk_dpi_remove, .driver = { .name = "mediatek-dpi", .of_match_table = mtk_dpi_of_ids,