From patchwork Wed Jul 26 04:00:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126084 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp176010vqo; Tue, 25 Jul 2023 21:50:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlE03jNq1gh+urJpXT7aYp7rHmzoODRqhoxT+l+8VQPSTs1slfLFMJwU4WC1fRVNjXmRGiAr X-Received: by 2002:a17:907:77c1:b0:99b:4668:865f with SMTP id kz1-20020a17090777c100b0099b4668865fmr667303ejc.10.1690347021199; Tue, 25 Jul 2023 21:50:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690347021; cv=pass; d=google.com; s=arc-20160816; b=Yr65nQ1Q4Em/izDb46mrewxucmCHjjOF940LrG3oBh9blHcqk1wqVnBSkVhdW9PM8D YRvyT8/bO56gkVXW4PSvQhpkax6M6Ld+cw/7pS2cFSuuHQFPHt8N+mYyjoj7dyZduhKR slTo84bugYGSfcTJ/7bGVuVFWmtIetck+S4jzcesCDb0aobhTTRUI5gAFfFLXUPhicOD xPhUFmvehvh7QiLRG1XNB1436BmdiANnDkMJmIcpYqOlf+Tg2MEJjbzIQ6o/8N/stdnE W5R6l9/adZJfpro81V9eOcuSJCGXtxbfPEh/USN9SJveV1hYQetjMEDM+iqIFOgDg3At iu8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; fh=7b0Y5Cx3utyrzaG4S8aa3Mo2ByBxutW+yB8187lmbIY=; b=fGTufV2YFgbtkjHTdcn7fT++ezWtLKmjksMTSUnw8dnMY54fywijPp1GYDUnr/4zY8 LrTjVpbQMq3xjGbMuuCucV1Un6jVwQc5S+SB68UEAelMDMqKDaX4jyM2sqdGqZQUT0vn 2+CdZ6ZLALb99yBhFl8P0lghjQIisSf7aNIaf9/RNZe6zpZM9mekFfQKd6jf/gFaSzlQ gRy7Rd1s7zHIy0yXd7xBSfNfTPAS1Zvs5qJF1koNrrXF5iekzpSvqyzmeoFKlp7WccAw P/EpLZKy7WQ7+jniTXP30SbGOg0/u/bJlWdiY4896T3KYHC1bqw724fx3h+iLDKcqShd y/9g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=p1LexOyj; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k25-20020a17090627d900b00992e0f4e85fsi8880768ejc.229.2023.07.25.21.49.56; Tue, 25 Jul 2023 21:50:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=p1LexOyj; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230356AbjGZEUm (ORCPT + 99 others); Wed, 26 Jul 2023 00:20:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjGZEUH (ORCPT ); Wed, 26 Jul 2023 00:20:07 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20723.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::723]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDCBA5B9C; Tue, 25 Jul 2023 21:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qra3j3Y2Bt84uI9mArcwYulDpPtgSh8BY0Nq0eQDFGfYsmlo2IeCjdus6nUnAwxeGQJWnUjqRz/hMAR+6tZDqi+wt9L8r0trm520BXW2/omfLjgCmU0SPVc0tbfd3nTtSVH2icfpAl9XJibgXmUs7+O+ffeBdjMmhoybhv9XhUOYWLBsAzKwAmOmc4KOdkUievD1XO06+UPTgL9u7agOomAuVdrmowKT+MKnXV5m9LV12DHhrkHvo0q5tORTytAqz8RJ7P01O9Ur37TOmjLcISm77++oBQ/o+Bc3TYhOXF8bDsrVOkWyeda29IYqgg1ImfHCSmG8U7lYa/imqnEqgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=F/14DRGxIniXezdfgCrCpsVo2hpRtTvEivsLcjiwAUg8q6RziN1uL7BA0VMbomdzcPcHXzbXNZOO36Tk418fEcKe/mixzZlZgCnkRfP1Dgkk/ALHUK9cppW1JSiOK090r3T/zCC9RZtax7Dgt6VHB2okAZjburWP3FgadWRnE1mG7c0+utjoxNL8yEYQmNq9IkR20bIiztYG87RsqydGApi3Hnipdxugs0CwBCDyYFyjXauHxLnSGHAvrJWVZV+GXHRSyvvw78X+OBvo3drqR0rOEZHUIWX1v+UNPE+B3djW0EuhF6O4GENQGw2zyoB/HXDvQTtDTfXKsn9m/4WFpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=p1LexOyjqnbBzq+FoyYzcoSDgywW22IRtWTdyv7SbeHEirH3FL36OYoWH91hMeTsAWdZD9h46MhKKMEgWLLv4yifLXvuFIqvs/oSz9lkYQx7hpze0akQ9VPXE86oYhr5UXLsWOlwEJaOwNTUk+gTh8FMccNMBZmeqOkuWx/DOV7p2bcC1KSEz24CgV5D/X4xbyOpoImkr+YGK++eH3MO6TibTy4yTI8wcIasfVgQJZunSgm93sH2wtcAWcLFHYp5ljDB0kNvePy7dBLTD+xL5Pk9TSSRKftnIaU0fFbSaiCSotj+29Cy+hgogRSWqpJBAo4X4fS+Ya+HWm05MJc0ew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:02:42 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:41 +0000 From: Yangtao Li To: Ulf Hansson , Kunihiko Hayashi , Masami Hiramatsu Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 59/61] mmc: uniphier-sd: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:39 +0800 Message-Id: <20230726040041.26267-59-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 77260e1e-3cea-48bb-c51f-08db8d8d28d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kS/072Ljm+QuZ3gkGCffYjgIRNrcJ9DcHAz9hpUY8S14vurIsNoYhZOIVoMjx2H/FJmjhH7JoJxtFIiV2/i4MY6LRHIWuvlsqz2ELxyoNHBTwUm24g0Xg6vy0YT7yN/VQiNlU50h1Gbjqsl1EbONEVRdgQWeaDT+lU9PkvkvQBe2j+7sDAU3M7xNfwy7Py3zEe66L79Tw92mNoRYHuUCGs2pkK9MIcFDO7GpSMEJCt0DAqnvbsde4/sC5SsAFAJyI48FbpRF80jVFbe3UAAq8E+9czHmsXe3Jadj2ZfThLIAzUn0x4apw49Xk3CUzIxVg4TdsT1/H2U8XHzdA/vy2pQq0UBg42WNpVpRz7bodnDou2zj+ik0m4OjjNyOZi6/WKyZ2YbyrLHGxd4Oz0opXCk/MUPPNBJRmG9fdpPv2RDOCMJQMVz/KsAUjVeSb9/T/FU4IB4nn+YGVQtS3iLkUfVtKBVpKDUBoqGAdNafGaIxuZERZjTrb2CFvNA9VhMmWGjgvlASjaJuDSqNdERM+99FgxbOPmaaj3+Y4tyimnNDWaQkuA0RQ60udgxiOIQ1g8j98o6J0eaQ7FXtZw7c+X65aTrHtWHaIoMyQK0paB1Xxj6wifssXTsqytYanoX8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?kCVy00+Meq1it1j8//9zhbHUe8p9?= =?utf-8?q?jd5BnBK5PD3/LUwJGYcABwHzw+kOuxQHeUEErmC3GRYed8UUw/yN99/0WKFBTPolu?= =?utf-8?q?O8W0bNmHKMm+78IO5EYi2tddaA6uSZraW0BudMqIDuMdVwRpy4qfMMRabJdNrFBBc?= =?utf-8?q?KzuIlg32Ngh24FPKSZObVXmmkIlrpO9ruuCImiaCFfK4Sz8LdABD0l00NLis11kyL?= =?utf-8?q?5JYIj/izNWNqSyvdbmsmw2H3bbjl2awoZKrdykpZs4Gw2HkqRepsSAuA31akhSaq4?= =?utf-8?q?5z5wRjqr4KiQ+f+4Atk3DUmzdkoXhVHERtrl6bpt0BmzBi/T2Cp9QWm0fB6I4NtlG?= =?utf-8?q?bE8HVuxwFKJ4vxbKDZc9EfBc0tjlMve3ZAlEAVUsTc7lIu0uw5zMbVsZbn7wsaSaX?= =?utf-8?q?312K03XRqZNzbRVaPQH9WMg+HVencpP8o4XdSug/jXwFQMEx8HPjLURHr9Ixv9upu?= =?utf-8?q?BCIthyGNR+hatqF4TecXh58V3PdJ1NXB5GVEUP//N9E2OTXmRj8bG0LpNEy0qK9Z5?= =?utf-8?q?VIaBMy36jVfh+cEBw8+auTTNRb4ZodpjdBA2iH23oa7v792hoNRqTiw2UQs+r1cMw?= =?utf-8?q?B5m2UNWVCy/SayFxE5JwCUBkCO4qsL1V/KW9FHkH2nLVo2G63iVViR90solqKn6oK?= =?utf-8?q?4d1+dNQ7TQ+t0sMguY2fTMk2p11cF0qwaq24WYNQk4XguX/dYwN7znU8xPPQ8d8vp?= =?utf-8?q?CxnXIrQg3uzpg6em3QkRXPSRPc2PGA9mpIo/a4Vzifb5sizSuwE43Y4D+jWJNkhLG?= =?utf-8?q?JeVq99bFSbMB8jINXU5NcDbspmX7Dd8hLwULFRXP+GSYLqYjRk7CmYqdwzvxu6jsL?= =?utf-8?q?ymPLSWczE2PfxxkEYSDymHoat/iIZvI1nKP1PatCBBgoBkv6MGGPR5xlIRssCR7XJ?= =?utf-8?q?lTW7xCHrejcbNgC690A96mr++mgW9OHzQhP/3WE6MBxPU2WMAEQUCa8n3u+0Gr8HY?= =?utf-8?q?NIsAisaGJ/v86UBPyn0FGfvZAYrHvQBstuzZ5tYyZH1CrGGkjsZwEDk5fUmXRGtgB?= =?utf-8?q?fuKchl8sKUWdwboQ4QXkIPQ71grN7gtfbrxZmSiYKY608qG0ldPSCsLada3awlGou?= =?utf-8?q?TUOdcgmNh06/Jsdut2HQZa0A0NHy081nLJ5+E/LO1A+G9M9crNaDKXvXtCVHEtcVM?= =?utf-8?q?LQMdhxuxtUHmoRnj6le51qIcXzb+G8drWvqNB3DiB8SsWgz5HfkE0Lyn4Jn+MCiwf?= =?utf-8?q?we0duiYBhg1brlXeSf3yHlY9GYEFEfNOswDgFfgfqt48JAYPNNl575UEtDNMLdt+t?= =?utf-8?q?dElGcK8Qvy5bzj+dzpNwq9JyVTbT1rN4V9c6ieQBrk8kD8oR0iDuGbWCjf9RRjyrU?= =?utf-8?q?tvjPofP5IAH7LogDWrUKk93DwRFRbYuUHMVsLzD1aWDCEppMYqRc0oqYVVN8/y4qT?= =?utf-8?q?q7388Jh8HXP+6qxhLRuudstan/grxvr2HfpIykW+CooLjF34mxRet3SKvoTvkUVLz?= =?utf-8?q?SAdg4UGYQYVqX0s5BOGIL1isElMldbyGYNoB7NdFuPATjx2KC/IchlZ0igw1KzA0Q?= =?utf-8?q?HUYnGiVIyao9?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77260e1e-3cea-48bb-c51f-08db8d8d28d3 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:41.9288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iA9diAx8kMtmcQ4RVlwGZy4aLJ48rKAME1kPN2SBTEr8MC8Me2QwinKFdTF6tNNZpI/03iIK+4s6yyl0veVieQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772457317949793953 X-GMAIL-MSGID: 1772457317949793953 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/uniphier-sd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 61acd69fac0e..33a4d1c6ef04 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -727,15 +727,13 @@ static int uniphier_sd_probe(struct platform_device *pdev) return ret; } -static int uniphier_sd_remove(struct platform_device *pdev) +static void uniphier_sd_remove(struct platform_device *pdev) { struct tmio_mmc_host *host = platform_get_drvdata(pdev); tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); tmio_mmc_host_free(host); - - return 0; } static const struct of_device_id uniphier_sd_match[] = { @@ -757,7 +755,7 @@ MODULE_DEVICE_TABLE(of, uniphier_sd_match); static struct platform_driver uniphier_sd_driver = { .probe = uniphier_sd_probe, - .remove = uniphier_sd_remove, + .remove_new = uniphier_sd_remove, .driver = { .name = "uniphier-sd", .probe_type = PROBE_PREFER_ASYNCHRONOUS,