From patchwork Wed Jul 26 04:00:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126101 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp184121vqo; Tue, 25 Jul 2023 22:15:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlG37UYUi6gDdkKb8lpDodoNTD1GQIpRkFYAJvVsE8I0Msy6rAmbL47Dvvq2FLhiSv8zSBpQ X-Received: by 2002:a05:6a20:3d81:b0:f0:50c4:4c43 with SMTP id s1-20020a056a203d8100b000f050c44c43mr1387051pzi.5.1690348521801; Tue, 25 Jul 2023 22:15:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690348521; cv=pass; d=google.com; s=arc-20160816; b=XS7YgsubUzjElWqcuKHyCxauNg+KZ9My/1LkOo68KmvI21aO6uKhQ4uARAIYXPr7EZ 8FeEhbPM+NnHlxQscQBm/YJkj9olc7g7VhuAQE02YKr6AiBLCaJIhQaoKCTOk9f7LRy8 y5qwMvLlzjiapqvQ2GHED04csM9XV9huhwbykqIHhn08uE8oqyReAzRBENIgXX4WEatY w5ylaT6+i4Z0+GSBKo7Gp2CNbekmjVjgoNiQ3ooR4kgGhVoSJBZLfHTARDW7aQd9bxjK 2oOJKO9IvdJRjjUBXhYR6shvJp3dKSwGB4I/uP0HaZUtZg8dfAUF4zz8zwczESv2QPdm 0FOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K1UBCsQ7z6bjOfCJhKMKvjOrHl91zL75OXa3zGFD5pw=; fh=VgrQwm1O7S562Nu0EHXj1yIoeXgypBRfDN0sIz9nJ0s=; b=b1glaJmhinQZTKZrFmlSqG1OQvUXgUJ4mtHEl+7sZ/cDm3xd6KaHVjsIpBZAVQiPY/ QQNeeUWIMKiyEN+ORFz0/kXWjJKJz3Z64CMblpwbOFUDSQKpFVImDn/rutTHcVx2Xkdy fM4V6uRRVDJpzSZjzBmg5b2qRExhFWUvPCKtm+SeSzGMsNDLs/KZxocuF1SrJGxjjMmW m2LwayZ6Vu7yu8ER0I+UJB3uDkTtnxSvPU+YWNgYoBEtnYQCP1SMmlQsqdXKUUGSJOhM wHSVBOcPOwqrZp4171x5QH8gZN3yZZPKOseK3QikC+iIxtV54WKa4sNxsIXNqCf0Chm9 +i5w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=ddaY1C6U; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i190-20020a6387c7000000b0055c4c9cc016si12322842pge.598.2023.07.25.22.15.08; Tue, 25 Jul 2023 22:15:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=ddaY1C6U; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231340AbjGZEJk (ORCPT + 99 others); Wed, 26 Jul 2023 00:09:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbjGZEIx (ORCPT ); Wed, 26 Jul 2023 00:08:53 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20705.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::705]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B84B4EF6; Tue, 25 Jul 2023 21:05:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cFczwi2hXSXjs+rMzgVVPcrTnyWzZx4LX/rX7K0BC7sgEGmnyzpjAXa4G/DxLo8H3jrzci8GKt3x0tyfEsuZPjM9GiBNHsWdGQtSJ8bUgLDAdnzIL2lkM7gJ6Lvhdn8PplqEZXd0v8Xoznkem4mHu3dYFwsw9b4PEx+D7T+knxzeHzOBEzb79stIv9krZ4X7cpgOAMTHurvnq+s8ZKAdhb/Q9TRHTq+nPEa4mY5xJliUiuzYVNrgdZtVz3DDrFCNIoRMBSe2IKZ39wpYONENP3VfjH8o3knjKHPUX0XILfhbq2UCQKaf/7Iay5zVnPMjUBdKX1NpcXaPihRJZb/mJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K1UBCsQ7z6bjOfCJhKMKvjOrHl91zL75OXa3zGFD5pw=; b=lATzebIU8ItjI+ErwlKOEoaT0RhJdGIyyZN12hXevqmvSd9+Iu3yFaTFc3IRFB/LOX6eOzAjP4vt6G38zLwqufsIunpORisGDWbcL+X9RmwiYgDtupADzFRtOyxoZrpzgIPO+oAdz59Ay7KEui5MgO0ivW+VSv5wa8ems4NlVbxvawI82CCGUCvchgShD6qEaab3RPs+9XUdWyYYmQsHWuZ0Nw5V/H/5lJ1VchKUEONGpK2JkKE3rxDWgEJhBRi4l5vkkKt5KucIQa3/N/RpjzfjFbqA/+X+kB77qkLey1aODfI1V6mr9PGs3Y5Rn79+5cWKBNWQ4vycnjTiF5rkkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K1UBCsQ7z6bjOfCJhKMKvjOrHl91zL75OXa3zGFD5pw=; b=ddaY1C6UIn498SOzE5CllYImmyx8vRMeXj/uJa3qdxlsc+pIKEl6+w1cjI75yw84OGj0Djxuxq8VYUEDg59jLJ+tyQm6VjE9olef+LEAV3NgOriwl4u0dALEfSm7jjOZWwmufzdAfMJ9QL8R3w/maApbV/KZfphMLUmAe4MH08dVimPoS+75qSAwiY751bAUz7Wwo1NWM1QjZ693p/tfZLjE4hRWOX5pafB7aFBNktGGyLWyYACGQL/m+1mwl32t2NMK6bRtBz/zE8lKuP2UUnEZGUdC9Nhm0cFWLeLr5EXbKZbCaQQUaSnp96RJSyYcXmfxumLlI8OiwRerARy9+Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:31 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:31 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 48/61] mmc: wmt-sdmmc: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:28 +0800 Message-Id: <20230726040041.26267-48-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a69c92f-754c-4bdd-98f0-08db8d8d1d77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZXHKmj/OkYoyXka9ehtZHrKrXvH4yi940OABB8SjRPatnHFPCglL5I1cFMpNlwhg6Ds9865QlbozMz2O6CfWbmW6C6pWpYnd2V3MYL7Fm2IJ4NzWGSUoRx6Pkb+x6jvOBprDVXRZFRisM7AWWJqcrv8YOfG/7svqs7+EvUVNiCtr6BOs9rF1ptBNbAxPWzvo/J9z3eyBTiTqVREkaY1r3Xpt6+Q5aCuwsx1ZH2OyO/HRetyK+zTVad+dgoil4hGCnfp7BaHmW99PDByJjYB7iuqeKIs8GlJDXCa3zY3eFAhqGIqeYPoOllxhdSqaP5bmFiHme5x+CuxqXonJneuHuXSByvav+gqt1+fooekiqi+V3oN7CJxQdRrfFrEuGruvMiYnHhE1ArlyQLz1jdzlgoa966SbgtYTo2SVhtXJdwmzTQ7OU8shvzhEFu5zZXz2akMcZSS6WoI0YtgrV3gCRVsdWaHFN2mxI8u62C9mjCv00F79DvU4hUUItd3zVDboWiNRdPy7H6X5xnLl+XBfAVgWhTASK/jVnD52FHyO6KljrQ+ho3t6yBGlJc4DAfS0856UUIX1aNsNM8gVZRj2JcyNzLfFCX2lobxt4kDN9vKgofkyXMyimBLPIE37evuN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(6916009)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?dP4t3ScUJA274XeorzaP7ajdfu9F?= =?utf-8?q?A0KGMtIAB8TV/cE8i0xfmkCuuCuwANc8vJsilQiJlmzgf5Ogf/8pkRc8HcNPtf2N2?= =?utf-8?q?lMvD7gvK0bIJFf3gGQtzdE9DJmNWnZr/ss6zX5YlPu2kadXkC1RsnVsJwN8YzfQwc?= =?utf-8?q?eKwdzjH6daMfeM3XzZAfYApsmWj2OBbLX3ZTrYr6T+kEu4FaYOLMHmS+CeJgbx+3z?= =?utf-8?q?P2rFLrJCnlKR5oA1HfmqNRlmqYXQTrTuY7wTVOJAbNW8cm6g5cd2ivbOteZ6klbRj?= =?utf-8?q?RByYnQW7/4zX4PhvJkKBkRFjW3YzHBRN+m/0S/6rCFmOSeZUFuzo9HZSTrSNCiAlV?= =?utf-8?q?lZwj4ctIRntKY4Nl3MNd8RLnlW1NeyOTAse6Sf3Fw1i6lQewgk5mQ6kOanuJngS0F?= =?utf-8?q?zNguUP68zBkjEy9hS7NYLhwPbmJLZpFkkN3VdouUitruPWiJVK1BMcoSdbeBkKgwQ?= =?utf-8?q?iIqFsq2MGVmJWFxT+AcwjSRnxXnPJm/VbxLq/e4yQW22hLbXE3w/1nvJoIWGw6plU?= =?utf-8?q?M2uW9uDdTABg4h1lLP50e6MnDQHKmNJzmygxhHlhGPqe72c+hzFEbZkN5rw55QTIc?= =?utf-8?q?MbUvBMgWCzVG8J14ZzrfRnobLMkUXyqdx+yl5SziEX1vUem0NYQsKL4AsBYaM7FP1?= =?utf-8?q?fraJy2SoxNr75g399V1IpoGKwc9YRY7T7paf4Stddd6i1vjEE2m5PqiAtjUkAxcgF?= =?utf-8?q?eAcUK0F6B4fJxAuhtj9WewUZBSoYsHk0Am4+77a/NVY2Xf+hICt7nSz8uOSTC6Egc?= =?utf-8?q?QxXWjcSDUlA79UezkxnnQQpYfUMgh0IqmbjEpCs0XEUNfMHyeYTnFW29YhCN6ZeX+?= =?utf-8?q?EUFGDMPwSqRwD81SXrYYUDO1fbFuBGk7FJeI8OZVqmUNkmhVU5jzDYqW+2VHnYqk8?= =?utf-8?q?d3kYldund1SvqZ0f1BM7hiEFnwlUAOtcbfA+wRe7iSJmWR63qHDvBUts9c8cpAH71?= =?utf-8?q?B7iNz+vH5UcCnIYYO00QyQwWWEr/S+pTSbaBxmV7lkAniQl0RpSWTYTFSzj7UhX9h?= =?utf-8?q?eKYAe/278+r180x3WHJ7HufEJZxGR+OkiyufcJtV4AO2sQdPaLHIUK/tQrBCE9cPv?= =?utf-8?q?WIHc7oSBn/G5mcx1MP4DUzQ1IJJ+CEq8HC7ltuRKwe6aMQeLZEa7lpxLE3XxLOniC?= =?utf-8?q?yhCcN2LfTfhL2GqIsmzR7vqUZxyiV/UmtsalUVJASJTCsEnfFOdrbgB+kkk9PG+1i?= =?utf-8?q?axQXhcobpzJ+76hIBevkDcpzwHX7HBKKT9HWOYyZY/8vfNC4kMktd0G7skirjRcfr?= =?utf-8?q?c3c7KV4WNqK4T5bwr0T2Vxd6WNELHqYIDCXd24BZYuOCOiPYr8LicKI6hvxRp+Gnm?= =?utf-8?q?pg8JIWbED/tq7pC7d8wzPBvdFX2J9La6Vd8JAF8V44EhekcYsMvOEawBiFu6dF/Ei?= =?utf-8?q?kLujSLj6jqpSFtd2OAvN+p+TFXu2AVvXH0OgfpWs6c9copyS4KEugqu8WMuRRIXq9?= =?utf-8?q?202hD3h3SPPDO6of9alBTZbEBP3w3AH4VBeCnlpEHBafHfcZnAWdiqtn/bEY/H+8s?= =?utf-8?q?mdmzcbeRtSwh?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a69c92f-754c-4bdd-98f0-08db8d8d1d77 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:22.8711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gtSrqdFUbkdTYblJzN/k/BU0MrYutxZZSUNxbb3IS7lpnwFYJZOzjzsI3fY5pTEH358LAKjrW2rYQMfgK9glwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772458891343504156 X-GMAIL-MSGID: 1772458891343504156 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/wmt-sdmmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 68525d900046..74c475d071b7 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -880,7 +880,7 @@ static int wmt_mci_probe(struct platform_device *pdev) return ret; } -static int wmt_mci_remove(struct platform_device *pdev) +static void wmt_mci_remove(struct platform_device *pdev) { struct mmc_host *mmc; struct wmt_mci_priv *priv; @@ -918,8 +918,6 @@ static int wmt_mci_remove(struct platform_device *pdev) mmc_free_host(mmc); dev_info(&pdev->dev, "WMT MCI device removed\n"); - - return 0; } #ifdef CONFIG_PM @@ -989,7 +987,7 @@ static const struct dev_pm_ops wmt_mci_pm = { static struct platform_driver wmt_mci_driver = { .probe = wmt_mci_probe, - .remove = wmt_mci_remove, + .remove_new = wmt_mci_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS,