From patchwork Wed Jul 26 04:00:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126071 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp168946vqo; Tue, 25 Jul 2023 21:28:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlHTJT2GRRHDPgZOF7HY3HZbW/13OAnxr5avyjmUH0vwImSRYVJOtdPmX4UHfDgxgdMGdKGE X-Received: by 2002:a17:906:7a4a:b0:99b:bca6:cf94 with SMTP id i10-20020a1709067a4a00b0099bbca6cf94mr730359ejo.14.1690345680073; Tue, 25 Jul 2023 21:28:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690345680; cv=pass; d=google.com; s=arc-20160816; b=JukJYg1Wfg1e/vM58aKqm5Y+Syrpp/wCE/07WmCEqhoPWTKqMRKrDwxrobdlEDethK SijVyJmaXxgX1Il7fS+YNqU/hkqVwrnsYVBYd0w072h7j4HbsOQcVmLhjPGAjJKOtXba /jUW5ylgbtcXW1oAIcW7R0IA3FeDBfTNOt7OL4S2G0bRKoAGTXtCMGQciOz0EqcP8N4c kwZj7s+Xt03s7HPGndf26TmyuuwBUS6dHxxc5bC89YWQLyLq5OHje9Gk7JfJGNyIFqeZ Rzo9kKs8wdGHGTv8kEsCi53kM/MltQ9X4lYk8HNb35MR0o7v5sy3+afdoNoQOKu+G/tA 7D7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; fh=6cdLzAmRtuylSKIxaYw9sY9DAq4BCLf68zkyCZCuc9k=; b=Ds0XHJnJKVclrSa/xwpzc9HOEaeMrd/TOqlwS3CGRfN3bszarpSvZLCZ1NsdbJMuY3 GNcro1zTLm7wkc+Jl9IcgDg/YDmXDzUW3QFvIvi4quIRuga5hCtD7RnqBg5P93s2k+1g /EFJBVXd0lt8tQ+Ay6XSparvVcDjbYF1lDVBd8fBCsS6vGjjCs9TJVOtcoONW2zj/VXd BIl0G9eF1TvxHkEOmMXmsOmfHfxyRMkD1CvRHMBnKghpwhI+SKbA+riWMhbNVyMnGHqn Boq0wK57B2KIaQnZrbwOo/07dAc6rS0V2T/UvsaCmUGRvIxZykhCMlHvBZkNVbpBPPHs PCdQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LYaSzgp+; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x20-20020a1709065ad400b0096f6faaaa93si8910630ejs.223.2023.07.25.21.27.37; Tue, 25 Jul 2023 21:28:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=LYaSzgp+; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231176AbjGZEIl (ORCPT + 99 others); Wed, 26 Jul 2023 00:08:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbjGZEIB (ORCPT ); Wed, 26 Jul 2023 00:08:01 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20705.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::705]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 064044EC3; Tue, 25 Jul 2023 21:04:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YPE6dxRszVSeZIbRIKnSjaJS4ATjpPalnUOYSaW/hGO6uVhSSYepKkvIu3WObbiGgxie6S0qrNtsJ/xREGhAs7YdfuYqKRdWO0+AEPKsShAlU0l+jqghcWVSk3OhF0URC0Vaw+YEG9K3mEJtFWgnjCjSVehfPXwBb+d2sOAgGVxtfMvBVQeQnE60yJoPBsxihdEMr0tqPp0q3ppOKPuOJ+5uQLg+ZJ5FumE0PpS4/s5v1EJf7C7eqcny1z0NrlWxnUJw/uYW6bIGIzFYw4ojce99J+L1d9NhBaDAHI1QTFr96IIzogW0u3OMg1rSNWvxSHaf+ww8noCIEwI3My0nqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; b=LQ5xk8DyABleCejGjICE7S1S1M7Ud4H8/i/SgYWGHXEvRYegHBFLOJa9wXq3eAqlRkgeq+0DBTCrdXc4hyS0j2hxgzJX0QkBBFc4H9rBVYpEPUf7WCyGR9S09ufR+OswuaKHFl171StooXn2w3fhhs+LHD2fiPH1BlYjuPMJ7jzpb+kJfzR2YKTsOCFyOPQC8SbJShlAbBq5ASLeQeib+C2y4TkMGbEIn2pmiF4i6z4jsIORrILXgTp5SRBn25t4oM+sL65FWRYk3zxS/4zjOlP8fCiHLWj/JjpbNngAH95ub8X7VWAJwW5mC6ARhj4zaufFdgOzNyZajOq1jCeoRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; b=LYaSzgp+q8y1vRJbdfXeHpo4tO+omEE3ETxPFYa9bGPcabrnoDA6ZgJm2RiZH0adxJZ0ex+cPjF+S6bw6B1JMRnQ3BH/bN7KNzqkWbxlLg8iBgQr3XBlilnrZZt2rU+T0aJQGZlQR7IgG+ccniz9PdTnzB0phipxWETBKsNOUQZJ7tzsmVnoc1wtom90JMdBJ27gV14B7E6DwSfkLhRkXD7VLOGt++Wo+hWV9eYLwYNB/yMYFLYqjDckrlcjQEL9l+wPN8TYicllJ76+3kHaEyCQjI1X9IsbetrV1ThhoxC4ncpKi8ZgGjWOgKWAml/4HwKIagA2l+a3IDeZLUgXEw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:29 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:29 +0000 From: Yangtao Li To: Pierre Ossman , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 44/61] mmc: wbsd: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:24 +0800 Message-Id: <20230726040041.26267-44-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: db671ade-63f1-42fa-c257-08db8d8d193f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CMIbEO5DKVz9xi+KLGQwANXldswD12sXbH9ochhu1G/Akf8QuCWtDnblQ7RxLsoE1TuK1S62LQdFMFpFDZc9oE4KBsl+lMCilPDwxF3kDrjPM5QiI3dD6RNxzUuAzCnots2HcwRstxQ0isyQTn7Mzqgk5SdLv5c2X2iVQTcFXKkBQccbZifJ9+1gLJlIMwxHTbE+wrroaJP7UYhs7yZKVQQpjNHG/zwSyMvJBdISMD40Bnjk07PqEnpIUG0b1ZT4aJyIKKmf5i7kQQPF/z9+5nCoWEI/0dHA9UBDUc+31+NJp/JY5jW/EKPuC9uDhdiv14n8nh0mq8CuomvdbZ+5/m5fDLS1ckeFw9qOL9zYN/AN+udxcPyxYXcBWArsPmGXqsv1fsmMA3qYuEqPuBaEkcuoQ9ZQnYNu5EAWXzES9xxOXpcmyX46L02pD41OiIyXjNQczC36FHrrPPT6k/QDALhmskUiVez1xIifQlsFll5fggSy8WO3TaOkI3ukLLsJFw79g9zXA7RhBsafmXa0TYsmcJ07u+5aa6Yl5GCzW2SstxsJgHgdHnFedjPftqTtNHKlWxFYwqpnoF7Dv1OCQcz2b604fhu2fn+pO3Q1UPbsgTeDdELT8Z08hgO5DldX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(66574015)(6506007)(26005)(1076003)(86362001)(2906002)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?d7r9vFc5C4Ph0wV8RvDavxDv6VSN?= =?utf-8?q?vCPABja6M98juTs1ZuaW8vykyGXbLGSRPbSer+4gncDMk74C4CV5/O9ApnVV1VX6B?= =?utf-8?q?Ru7yK/bL4OFBZaDAfxXlHcafy1Rffk6/BZWqh4AAeIiA7m793yTAv8A0XXU4/BVTN?= =?utf-8?q?uy3rRBiy9tMcDrQe5RLjr61oKp6x1ok9+vhlylm5e+rzRZIa4O2jVOi+l7wKV2Ad8?= =?utf-8?q?rSyFMY8cBrFKL8OzR0evJmoHOsaY4Y+mmhE4ixgHravEb/i0nrXX1cja4rynTucX6?= =?utf-8?q?hyqd231rjcN++cg7evkb75+qMTaW6AQWp8kqocSmaiHkONmirl02NyfxYk57TnJPZ?= =?utf-8?q?78f1+MrIiicLMxqZD+tnOljJ+WFRl8ZCeTVdDbAVUQ7FSipBhyDk8QcRVdbSS2sdu?= =?utf-8?q?zwkz5nEf8r8TodiezilzXwb5hEy5b7lHyd+4amRexNmpdbhLM0Z0+Yt1PfqD7eSwM?= =?utf-8?q?KBOVgKtkwr+uK6K9mwQ7RIm6iC4yK+XCthxeXiohOWbvFe9eD/Jf5HaCLdQNErU2p?= =?utf-8?q?Tg0olaJOWwgftxo9XD9DKXKg0DFq6FoXVlej8H2Kn/N8g0uF5Nly7avNz9NMcC2rW?= =?utf-8?q?wAhvDe73rEK16NIoCBryeovln7CBsaHTIbPqhqKcsDeDao3pDC4UAkybV6xVke/Ik?= =?utf-8?q?nBB5fnEbZPJQeXsCueqFI4m/W4mDGxAFb91kgsb1cktEMjy5kBfaqi6ADpTDeO65U?= =?utf-8?q?GKXvLTPHFS+2UOOPXXaZLhsYB3EDRgp3ZcKD4UWUdrT/xWAyUiSCoaMcUY39GsRlx?= =?utf-8?q?JSzOvDimb68MoLv07twP6SxXqyFsKFEbOZpNNPKLluCgSJjZBj3BagpsPwt60ImU1?= =?utf-8?q?uvqgzFNZSisPl9qbGOX/6O2+rZMXvqd6vWdM/sFmh7k1OvIUgc5RxVyCgGZ18F04+?= =?utf-8?q?CpuPtOvzxBMN7tps7fyBxsRYFF/xg9QGY92253NOTiljqYdPnujhsImIhEl/UtUgp?= =?utf-8?q?rDGcXMcAuNgUZkDcY1TetuZmFDkMosK9ueMsxSKikkQM0QsXkE1y+s/dl4t7v5Ikv?= =?utf-8?q?UfAUkuWpazX5kgDIQ8lYFs5qNhzQypxVPoR2we+wsp1Knmr5C2Td88PAgMoZ/xoP+?= =?utf-8?q?0KGwkuSbqu6keT6LnPS2GeZCV8T2MMHwaJqhtfyV6+YB6GY0DN9k1U4FqE/2NPZO9?= =?utf-8?q?Tb1AxRsH/XiaLb654FUaWN6RB9QNbfYEVc01LqnyeH8LP6NA6oNJ8UfLZmUPNgS1b?= =?utf-8?q?ayEsleeXI1Gg9J3I40+m3mPPz5aNyV3tco8e1R2fjFw0ZGT8wl4zTdbsQqPemwn0Q?= =?utf-8?q?PHJ9xdaGRgBsjCNME+gsua/rWkjodtN6Cos0UZnpHCfXHz8ZOP0jxXhjoLPOaCMgw?= =?utf-8?q?aEK9qLv76XxAzMYRDTxOcPV/c1JUvdsibWc6VoS+Lng2u+XbLiY7iYzYGOrtiFsaJ?= =?utf-8?q?mtjKUB0s4ccpixOQAtVhEH11YZ8UKClHbgxZ68H96P4Mnt8jyA68K55QOdix7hpmq?= =?utf-8?q?QNmVPSjmTwQs2yzHkRMfIaGJ6+2/0amuHVLp9tNjuE/0GoKeoqS5391gPbpUcr93M?= =?utf-8?q?vANrUr/xpp/O?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: db671ade-63f1-42fa-c257-08db8d8d193f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:15.7681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NTTj5IkqR34zCnCzGodwaZdWac9n/ccGWzxyjuGqWFzOVX9WqNR6P+SXwDkjjGyq6nDJGbzyyryAqKg90vBpkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772455911881415701 X-GMAIL-MSGID: 1772455911881415701 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/wbsd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c index 521af9251f33..f361cefcee01 100644 --- a/drivers/mmc/host/wbsd.c +++ b/drivers/mmc/host/wbsd.c @@ -1758,11 +1758,9 @@ static int wbsd_probe(struct platform_device *dev) return wbsd_init(&dev->dev, param_io, param_irq, param_dma, 0); } -static int wbsd_remove(struct platform_device *dev) +static void wbsd_remove(struct platform_device *dev) { wbsd_shutdown(&dev->dev, 0); - - return 0; } /* @@ -1904,8 +1902,7 @@ static struct platform_device *wbsd_device; static struct platform_driver wbsd_driver = { .probe = wbsd_probe, - .remove = wbsd_remove, - + .remove_new = wbsd_remove, .suspend = wbsd_platform_suspend, .resume = wbsd_platform_resume, .driver = {