From patchwork Wed Jul 26 04:00:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126075 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp169455vqo; Tue, 25 Jul 2023 21:29:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlFonlTRGfgvMW0Ym6IgLg/BRyCd1VIO1v176nLJvOzfqTyxbO/+xyNRgiTzQnrPDSZ8eYMp X-Received: by 2002:aa7:d71a:0:b0:522:36e8:bc88 with SMTP id t26-20020aa7d71a000000b0052236e8bc88mr552563edq.12.1690345766242; Tue, 25 Jul 2023 21:29:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690345766; cv=pass; d=google.com; s=arc-20160816; b=oOYnVjCSjeT233+vNeS9Eg/yds4iZoE1675IGu0QUk54i0Yek77g1DFBcGp47xHbCt dtmccmcF5MLJoes3ZC2f0aBTw6r9j9K8fKF7s33p5a0J/cErI1gCLPPIYwCdufUmolE/ 7bemA/FP1YSfLdUfjS4KeckGJtZomm3sPB3an4PeiOFln8FSkFXad4WUuUC6/3YyM8+D maaCsHPWmLX4RbqVyWP28JK54cVsoq5I45gWrwZESemnNZSzf3fVfV2cGgEB7C4SFr4m jorWHMdNFfKXm72+9/b3fce25/zazrxNdyAefhKvCI/r4I/akASC0nRh4Ppy5ShMMuN/ ES1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WVnebS5xmKX74dwA/QiihEaSwS42iXdHIK6TKi1CgBE=; fh=ZYodWTe0KCUO3NR7BtRFAqGMu45kjt7wn2F8buQXmlM=; b=mmkxagUd0fsCA2lG4PScmXiwIZGHkFZj6ZlYwh6utN/ES58hckfSeowoVQO4Yd1wNV 1kWU3rqjQ1jtCk/idBpHC44QEcpPyvoRQYH0+RX5I57VZtUjQMNoWZ0trDmuza6mbGWt S6wE78HTDIBhnY2+Duk2C5RLe6j5OreLHuZVtypHE2DsUK1j+xNW4kjnhdNTu9xXiLtt BWUh57eHT2cnBDr3aJVh8GHQi51uZqwUYnUy+VX+dKzLToqjopnyfYWcVW9ecGUMCzlg ucDbkhIkMsx++ltd3MA9CsOhf8v3pxxb47a+3aHAA0CM/WQfK7C1J/xkmzue2TKGxHLG mzUw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=nszivcoJ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y14-20020aa7c24e000000b005221fc36675si5579612edo.78.2023.07.25.21.29.02; Tue, 25 Jul 2023 21:29:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=nszivcoJ; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231790AbjGZEJ0 (ORCPT + 99 others); Wed, 26 Jul 2023 00:09:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbjGZEIX (ORCPT ); Wed, 26 Jul 2023 00:08:23 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20716.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::716]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A0884EE1; Tue, 25 Jul 2023 21:04:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AIZYZ9KxGp4ohgfglbtD1H2Kw6zo86YPuqYoUKzR5jkScoBQQr4V8sfNRTkKpb/FBIQhjvoxUcBL6SkZi+eNht0yR7XzCEKj5IhEHhIpQF6Gjo1CMQxUjBBKf/CzSJZCYa4AHRygU4LsN9ByZ1V6upIsLdgKrk1MqCGqikJ1DyIC8ZOD8H0cx4kDErX0ThAN9zmO/6AvZU86Ij4EZXG8WAOWytRGPY9OqRTDJJGCerrf9ZKPIPkQS7znnQsik+4Yk0JV0Z+6OD/XyYtzXj/ULPRuduMHq8oJAxk2JpYOMaKrpmfnaJvwODgBlz2lFgGm3GUi1cVtiNxJilCa3aWR+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WVnebS5xmKX74dwA/QiihEaSwS42iXdHIK6TKi1CgBE=; b=K1/0y8OjSw+sdXj2OChixqVMdp/oDv0StqschXcvjzzGKIMgUQODouYVhAkJgkXjl0miHcqrN/zK4Ra5tWcxJ51VM03lsPhRtyNOa0aH3qnClakaU1auaBPE9Ow06TMuxYB09FKvk0GzTsZn4pNmkjTfRu0h197op6dZPXFXjrb3z5IwUnAcs3PAmXTd0J0BJhq29xTWQ2HFuJuEBTO/L89h1Eq3uO/cEPhN391Tn6cDJE/AX72g7SHLkijYXhaQo75o3wELayBz8LkKzoeFUMkVDgTU8+9PXVTPL3WEIzY3cdKo89pJK2KvBzUgFZc8RorUxPV+aT+xMLifhy9pbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WVnebS5xmKX74dwA/QiihEaSwS42iXdHIK6TKi1CgBE=; b=nszivcoJJV1sDS+ltn3AVb8fPhrrFBiVObnn0zopmnEOVdIV6GiwIIuqFZUT57UWgJBO38p+/OHaOAVX9bYvseUm498bOqnnK+8Y8SshGyNoBWeDedikfO1qkxbvr26Er1y6Ad97tm6tplrfEU1gkat9Uf4bZy/pY36LjS4TrHkl+DfKGxMawnboDzkBHLK4PB1dz8uNtXghtKtCZqnAFkDFV0wzbG3zxe4Gi1NBCE4zpORv/vzgT9x4t79OW0E6GDH5BXjWCZKPnGGU0yx1A0v3IbthQRNypGLfBbyBgEGObTwWbYBYfI2BrYKOksGZZcilXAnDzAPUu5wDpbYp5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:27 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:27 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 41/61] mmc: alcor: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:21 +0800 Message-Id: <20230726040041.26267-41-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 54b725bc-49fb-4e46-b3b6-08db8d8d15ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sCKDz5wMkAML9YbfOoCMFQ/GrC1sH8I2khedVHbGNBjElt0kYu4DL2PNbxM+jWA8ZK8Dsup9f/C2KQzxqMRQmOQFOZwYaodQPlfrkQbmUFJK0AVrwatXV5GuvLM0VPkfVz0GVntWDeWfmigodOcy3I1Cg0TVUN4SHzZHVaKvf+UaheoyVV9dS/PEMncAzmyj0kNzGSQ4GkpBEHh20nB3kdRKhODO5/zKEyulxWgAUyHhV6ImVbsD0uAMYzK58WEdhw4NKe5mWRtDtMGyXKJJeSMMF6aUFOVpAoPEIONl6XF217zUEua5bBl1J06EYHI9W+eygCOzflRAtpZxTB6Oat5WOmMcT6NMa3c9nc04kSG4qMQHmlBB4yVt45bWyQogav5Uj3kB+psvbRyotozgWGSr3sVf6VIcvbQo10qBUzfiWgRsF5/liRJwOKy/Cl0qeyPESBL2H3/ZaMC478zPnsyAjjdhb7yVu0zRYEOWA2jGAf+chm/kVW5kCt0Qo544yBy4EAyvXXLXroVy2cE1YxwTfku/RAbDsvm2XgRxKo8fVfIo3oJL5TACBR23SfnfXRm0lcx2bds3TopEV13VXw8hEcw6nq1FpSNfHMoWLHQYC1F5oBpuw21DApYKI+ft X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(6916009)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?m9zvFQuJkZueQtV6Lv/puPMZoAm5?= =?utf-8?q?GtgRiwKaSXARqYGaHwBmwShVxwni0SJLnG614KLkOgi7cwN7yL8a38+a4gZuX7YdL?= =?utf-8?q?o3xYF9sNKFGPvlcv1Yu0eNtvTh1MEE5GBmuozuR/5jEUrYIn/dP6MotP5m3Vwjcc1?= =?utf-8?q?ksNapScGRhkMczoFcvP/LR8Q/144ge/Z2OE74VMCUVOODMMNB1he8npEe73JPnZkS?= =?utf-8?q?CWOuL5s/CPY/IFnhV+HkVXtnn7BA8Kj0an/z/ai3SBoG6vI9Trg6dALHV/CmFFb+k?= =?utf-8?q?Wwi+TMD/LaI7yDmAxG85OH2Uem4eMXMZ8LbNtLl6E0Akj0BMPtGXHEOyyuMCtRG5C?= =?utf-8?q?D5QRK/V6WykUchGEBwndveMjqgns0psYGnXtVGpGYDJFDlN2+iq8hrpDi6CiHCrZA?= =?utf-8?q?0B1IP5JjCNBeRnE4RfPIF94HlQ07DTQCQ5f9c0+cdzA8IniNxzsEFpoJ0h+FAJnOD?= =?utf-8?q?waphqLlH+nGseAcDvS6+MF6X+p1Io3M+KFGk7rn0DECIZxJob9JSZ1dMfw7x9NvTh?= =?utf-8?q?Ga/L/plwzRgCGRGnrNR4UPzxPyeeMdaMbvjPisD7Y3MUj4lNjLqIOque0sZpyRUzm?= =?utf-8?q?HoimiMl9z46LDPrPjILJDvWoe9uuDuLdnKw6cqF1b3g1XpC65DlJxTpkQ+9QZD/Kx?= =?utf-8?q?DAQfmGbuPRyuLW5mbUPgkLAITY7aRVX8bluiuT5iqt6eYzTzvOGpVBzfJU241a8q4?= =?utf-8?q?vEehmP+RkRmPKQyFUzn+UX6PcFrwghIFIY+czZV/YyZW4DWwfl6HUzqP3M0lSe3N+?= =?utf-8?q?7qTdpIjXm/RAl2bOq5l2vyGvB/cTjsxtZFZC81XvRQ98T/0vXTHzBssTdNDtIFF67?= =?utf-8?q?8a6W1Byo+EfbuuHpC8uzyqv9ZNnDAV1VJPGhfhr5MPf5FE83B/msguYHaSMUCF1wt?= =?utf-8?q?22WPAoh7lDNrEEH7+pdcszqZpcrCDl1L79YIMetvO+fQYhNKwDZTWrqTHJjz6egAf?= =?utf-8?q?dx4KkZ3bQC77ka+wPNo3mMQuiVObNRXi1zAcNxwL8yg8vtyi4AedFqzphDck5YKNb?= =?utf-8?q?AwuF6T3ededjcAIDQvta9GXsc6AyAwXYCK+BokhIoEBwStzELf80yK5oJsoIQjsVt?= =?utf-8?q?MHXgqk8oQYfPpjx7J+SE9N7bRl7jA3hi5yGe362gVz6AYwvKOE9godWn/PXgkszoN?= =?utf-8?q?wjff0R1qxELTynjRNHJBUI0S3Ei+lRynowZDcoUfNrssBeOhE2PaETgpyodVUY1LS?= =?utf-8?q?xHMLZacCKbaIXKwisAGWRy8GPxZbvvBxhx9ggpWU0CkuyARYx4EZLn55WkP346WnU?= =?utf-8?q?UxB/7fWNEe4PZd8Gl8K0keOAr4Py8afC6m+xCRFnD6+wXUYdySXpbBUqL/kBlRCl5?= =?utf-8?q?uEUmfpTu65RA5qO48L/h/xFp6TNNt6YKvCU+0e3CWYoyKDQHzkn3v6Jkukoi5t/7k?= =?utf-8?q?rZeZ3UN8pxJ3pXNddTHoFrKGcROhBR39snqokG0v1ob906dldzj1ghp8tSuj8nyqN?= =?utf-8?q?MXt4ZxIYPLKY4BTr5pol5n7XjgsRz5sA7eVzm68vbraM2FPvCGIi7KdDT4ZfAOt2E?= =?utf-8?q?cYskj9mKzbjv?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54b725bc-49fb-4e46-b3b6-08db8d8d15ba X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:09.8822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hoHuRZY1A4Evx/685MJp3k8K1MqSw7MKk1vKcqgg5maEOaAzVmU0eNroCIw8PCcfiWWisQtHiyCiCJ7NfI/D3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772456001813249151 X-GMAIL-MSGID: 1772456001813249151 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/alcor.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c index d01df01d4b4d..42aa43740ba8 100644 --- a/drivers/mmc/host/alcor.c +++ b/drivers/mmc/host/alcor.c @@ -1125,7 +1125,7 @@ static int alcor_pci_sdmmc_drv_probe(struct platform_device *pdev) return ret; } -static int alcor_pci_sdmmc_drv_remove(struct platform_device *pdev) +static void alcor_pci_sdmmc_drv_remove(struct platform_device *pdev) { struct alcor_sdmmc_host *host = dev_get_drvdata(&pdev->dev); struct mmc_host *mmc = mmc_from_priv(host); @@ -1136,8 +1136,6 @@ static int alcor_pci_sdmmc_drv_remove(struct platform_device *pdev) alcor_hw_uninit(host); mmc_remove_host(mmc); mmc_free_host(mmc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1177,7 +1175,7 @@ MODULE_DEVICE_TABLE(platform, alcor_pci_sdmmc_ids); static struct platform_driver alcor_pci_sdmmc_driver = { .probe = alcor_pci_sdmmc_drv_probe, - .remove = alcor_pci_sdmmc_drv_remove, + .remove_new = alcor_pci_sdmmc_drv_remove, .id_table = alcor_pci_sdmmc_ids, .driver = { .name = DRV_NAME_ALCOR_PCI_SDMMC,