From patchwork Wed Jul 26 04:00:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5p2O5oms6Z+s?= X-Patchwork-Id: 126105 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp186841vqo; Tue, 25 Jul 2023 22:24:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlEJNYGc4XpBHyzmjzXaEDxyR3qIXPasrhP6Wd//qjOoCWqQAHSwioDY0VPt42ubEz5P5ki/ X-Received: by 2002:aa7:c50c:0:b0:522:5778:aed9 with SMTP id o12-20020aa7c50c000000b005225778aed9mr676787edq.19.1690349041375; Tue, 25 Jul 2023 22:24:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1690349041; cv=pass; d=google.com; s=arc-20160816; b=Vwu3pBDqVEjYI6B5OkY/vUVG1wNcHRwob+htqMmU+SZinbdCLCW+Q//UCBk/GvMwZu f2hSO/8jeg3Pf4COQ21AE0iaTSLUPn5VSMrJTWYpEKPE6Y52R4iXB0Yplnw+T0oCpuF2 gSzrUnr2iLFccGq2P5XVJfol0CoYa8HaDBRZ4040xtvyLDNGdeIoRaCcFBJJjSLZxY+M jVSSQDT2wiaoUjhmRD5CFkaUOkDS2KqtomjykvtvR0OnD5DPUNdunwdvI9uMBYz1a511 RwUL2h2IIzlUnjIPEsEVkOLtI/pBBnPWL16dX0GAqy5D2/Qw0L4TpMOcs5OKNBWw7zHb k47A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZqLHw9NdBMcVTHEOA1IaAb63aa7Km95uMTjhpgdnf2w=; fh=sF9PDWD1dowmsGW2YAvM25ENNNz6DTvxncohGgNxjqc=; b=dvsheCwKKVtRRYIJm64RKO08MK7eYxs/f+b1pRy7bTAcEHEfNKmGopV2GO6UOr0jNL cKcHmgN/PZzm+l+yn+irehH2gYXrkkS8uxF3+ivTyF+x8n4h8bJNZHbtvYiXYwd4u7HD ZqQKqYiFjNj4qx0bA8JIdlRMWKyCYOpC4TBJZVbFivZyiavkfApGqQLVhDBcppY+pZs8 Z6lkN/46g1TaRqHUhK8w8pefZ2g7qEn8f21ev98QSImPkHU45gu8r6aD35q2vnO1JsOw yW8Z9QDR2lSuO078S/+uLErzIsBvSzSWTPrI2W8crLKoRmpjNsIlklSIUWXcEDlb0gbc Bk/w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=PmtQFItb; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g16-20020aa7c590000000b005222adc64f8si4633326edq.405.2023.07.25.22.23.38; Tue, 25 Jul 2023 22:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=PmtQFItb; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230398AbjGZEHu (ORCPT + 99 others); Wed, 26 Jul 2023 00:07:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231244AbjGZEHB (ORCPT ); Wed, 26 Jul 2023 00:07:01 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20700.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::700]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C833A9E; Tue, 25 Jul 2023 21:03:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IPPCNJ/LrNLvZJ0UDolt7lfm93qpB77gnNf+uQLBQmQ+zTYwf3ob3OVFN8orfUTiZGSG0x7RQ5w2z5QTiq9y+Fn5kzeD0/3rntqItDn6UFmOkRYWwsBC7Z0/XdJU2D8t0ntaHGWg7ljwiEyU6/tOkvrc78peDI7EJq+AAI/x/0eW84hXc3fd5NK67RV80iYo4IM8geju9Elh3t1ba3U/9CKdyNArkA/rQ2bpVYe+XGtNNuneUlzwOCmFBe3JBREEo8GtdcyrMW8scKt7F6h9O81uVFPt/suIBOT5L+vqF/Jr+ZcEJuk39jrQWCGpI8AdnEv+nf8tHsSPqcCna3dFVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZqLHw9NdBMcVTHEOA1IaAb63aa7Km95uMTjhpgdnf2w=; b=A6Fo7jvTFmzPTiZMnf99xtU775P2N/M5/X84Jqspvvs5vgAaN6yiZnicRowwJO98I1ukt3c2DxH9LkWu+5fXvp2wOUPFvm1mRR0SDYzhHj/Xvw9I7nvHMgNjyYV0b4X1gXhbIA4sPgjRVDpu1is8bntjUnf4YsV6zExgzl2615ZEJ54GBcnvtS6WbM4diLiBgySn2d4qU4M9kAXZuQzT/bUo9ohAUGsU+/MskZ8wMnBg7otz873WV2kJaPSCOXEVb4iPgeboWv5KCouO5Zz3knIdgohkqIzEx4azjRmpq9tvFWEMrZZexlaTp4rtAzO2XOZxMf79s9H+t++qJz2c2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZqLHw9NdBMcVTHEOA1IaAb63aa7Km95uMTjhpgdnf2w=; b=PmtQFItbhCGE2SRU92nXJFTTepqp8R0Y5jhJ8966P3Tl2Ez8/9kT9WiCqvgO4Pjq5X52pnEI/IJ9GwstBVAEdRTchQw8/TS49RGGUz+O6rX90/vYKMaKhL7nmYCtW/nnpUCxwxCjnMXd/7GKo6/vQ5LOvxKdnlGE3E96Q5f5U37AVyhZNE7SjfrKhDfqsyRZRdCt+1duYhUhg1L876prMms5VrBYlR4mT9SedQQmjWUBzD1hxespe6qKRVtx3njMwmUG3+AGoYlAy4p5w9Pebqvoy0c1eigdbSrwQDvoASbz5dg36HSb+6+v7QdDMilC3Obe46SfQFEomyEPp0kDYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:02:22 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:22 +0000 From: Yangtao Li To: Vignesh Raghavendra , Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 32/61] mmc: sdhci-omap: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:12 +0800 Message-Id: <20230726040041.26267-32-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: d1927a0b-59cb-4a48-6a0b-08db8d8d0b94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gXxoFi7EEnnvgb6Vkza+dHXokHCSBivMqhjtMJjGOyuZwU2nJ/1KiNLwbXTG4rsE/znU+3tv9koS2KvhsdA0A5/osP66UDkQ330FVX9BE17UhBhu3kYfJLPJtYth+QATAp11pOggwSbscFVfLUs+RvKFtNYa6/O/A2QiGsA32N4eS+eXnT9DQ9nwIjB46Oqp3eqmyRYz5RNUqii+bGnOZbAPFOwPUU/pOtnn5QEZCXBHDdML/gB4h9RIB9AKkUsFlMgJz5DxsWR2ZoKJSqliRqOLEYM2MDYHuC0KcnTZ9s1dvChpWXo9fqvSO3qA1bcGPgDANZPN7Z0s42Jv34NqHp71s7s42a6hX+zRjTT14QaSvERx1tjyLPZpEKwySTAe39CYCdMtvJc3ALhrGG+pQVE416SOvGXjpebLRhPr0aJxEEVibFV68GveAKnLPxKrtExKTmRob0sHBXOfewbUZYIcWErmX4ceGNGr1fi18EB0WuhXYfC7Abgz7aSK4XMMKgHMM2xFwbTI5dRFNxl0XDetuqfvK0hjp/IJmVlESfqAGaGRDLuKx0twQjwmmLASMi9ATXeY1ngmLqcOcbzvWDeL5A6Xt1nuXYWYmB7WvgoNE+05KRfqy13OydssL9WV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5269.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(66574015)(6506007)(26005)(1076003)(86362001)(2906002)(36756003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?E+XQomqy2xz+eFG5vcUsrPFKFb6P?= =?utf-8?q?0ybdSS2kPPSQQdpTdwKPBxwITkMoZOcmBowD3KOCtQ1oUpjqnbX1jnxnJkntqu5D2?= =?utf-8?q?tkG7ILZrG3I96q+rUXkNhHozNbjL9OLDfpX2mE90Rd6kmkYFl/F46Eirscr6ykWQy?= =?utf-8?q?Pdvnczg+2zbMQZZYvcV2EyqGhT8bsnsjA6mACYRcEmvoj37jqRBprJFRIQQTL2fHd?= =?utf-8?q?5fgGglvP/kp0EkVO2mtOJ2TYKQG+wdn3siUg4MFjOKQADzo/xbqOszR8cF1JmXpJI?= =?utf-8?q?ZD5MhGEJWOfflJUXe9+cf4Wsl8Ykxu4LkRRDad7aP/X4ou+G7X4Ex4b5w/EkiGni/?= =?utf-8?q?uqY+EEJSou+TGswTWrplUZJI26q45a7P7LFhiljKT3IU85/eh2iAQxSpneWFB84Gs?= =?utf-8?q?+Q4A/fnWtcwZ7jk376mOjPv1Q41n7h7lZk9gaSVFzBd4A7LE5BtnDwN+GJWYb8OBW?= =?utf-8?q?HmvHF2/vL/obrfbv49mn85Iejqr31qi732OBLXSaEhui284V9uJ2hnNXDBR9V2ZZM?= =?utf-8?q?ChkODPhYOjnxZWQvTOSbIWB9vONubUJUXrZbCZjWif7UwOQg5mLiPay1YYQWzdsc7?= =?utf-8?q?NgeNJkjPDimUpDPu4Mvrw9507fWyY/7Ln2p7MoQQcVf+IRa40l15XQwPqMPCUUjV6?= =?utf-8?q?6APfPf/62I6iLPoqpbIISlFbZOmZNIkjEsL5rIBLVkAws5IdrTh4LpPjuXt+eNrPI?= =?utf-8?q?ozOY4aooOcudw0zcDc3Jxw2CsRXs8dktaBXCoLijvo1EaFbahoR3dkQyRTh8ClgX9?= =?utf-8?q?hgHw74T+KHNMQ74qtCCPRTqVzP7jHal/ClSC+CjRfMwzzbng6iXONmhvpKcvPlvzD?= =?utf-8?q?r9wb46zBNRRu1lnD+12YZ3gyBLseaw39zPbSEF4xbODG4bR+8OdNxj8lVApvun0mK?= =?utf-8?q?Bsu3oAvH5OtYwVae90sOQkqW8JWLLG522Rp8jS4I0Iz6Ge+/NlRw+mS+vBC2m2yiL?= =?utf-8?q?mV+aspa+kVNozCwpkSEUHp5WpusNrHBd9TY3Jl4arQ83hIYGu7agJ/XupVNYl3vCH?= =?utf-8?q?BuEqO702SgkoF3f2aEhfKfJoU4QM6E4+Cl+q/SeyyBbGgaFlgxFoVYXxj9luecq7s?= =?utf-8?q?854fFJJLQ0Ub+CE+VdcWOPa/bH3QZzP72Wp1Mj5tjiDHBH3MRFmoL1lfs3V0KYCfj?= =?utf-8?q?o708Yugf01V7CoTW4mPTEUnJIgYW22FDz68MlSlChm8Fm8u2Jf9ECKQ59vNM1dupX?= =?utf-8?q?ZWDZ2GQbfVi3h4h30eznLD4DDXN5Ng6p5jTm1oQ4RWQ1NOkWcZOPLEpLDKeYOLHqT?= =?utf-8?q?luH7hMQ8te+oEZoX59NQW3yJ6JFjUYoUGm+KXI7R2MLy/c5U+UWU0igC3/HOONdst?= =?utf-8?q?UVy/ksulOjT9JcH6l/8JWEt2TbiQrGFeFCxDpHu++u9l0S8580nlj1pt5griWILfc?= =?utf-8?q?0+SsjbOVKSGp06ERb8FtchHi6kObP42Em7BjXdj0EbMeNUM3qykSF32JogEOpydfu?= =?utf-8?q?nRyXk0oi2nXvFE+hqCLBcK6RwfaKU/wL1Tipc58hlbB7RUFMbvMwkrMHbgSworbod?= =?utf-8?q?F2knH2AjRXh2?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1927a0b-59cb-4a48-6a0b-08db8d8d0b94 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:52.8721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Fx3Iwgo3bNluQYOrlal14rRFZY217JDZ1PdprAmV/HlHH0abJNHvNupYIlyymo00uMHvkLzuZ9DYwDtHMD1GQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772459436270269198 X-GMAIL-MSGID: 1772459436270269198 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-omap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index 8ed9256b83da..6aa77eb4a3fb 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -1394,7 +1394,7 @@ static int sdhci_omap_probe(struct platform_device *pdev) return ret; } -static int sdhci_omap_remove(struct platform_device *pdev) +static void sdhci_omap_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct sdhci_host *host = platform_get_drvdata(pdev); @@ -1408,8 +1408,6 @@ static int sdhci_omap_remove(struct platform_device *pdev) /* Ensure device gets disabled despite userspace sysfs config */ pm_runtime_force_suspend(dev); sdhci_pltfm_free(pdev); - - return 0; } #ifdef CONFIG_PM @@ -1478,7 +1476,7 @@ static const struct dev_pm_ops sdhci_omap_dev_pm_ops = { static struct platform_driver sdhci_omap_driver = { .probe = sdhci_omap_probe, - .remove = sdhci_omap_remove, + .remove_new = sdhci_omap_remove, .driver = { .name = "sdhci-omap", .probe_type = PROBE_PREFER_ASYNCHRONOUS,