diff mbox series

[V1,2/2] scsi: ufs: ufs-qcom: check host controller state

Message ID 20230725192710.26698-3-quic_nitirawa@quicinc.com
State New
Headers
Series Fix hibern8 enter failure during host reset |

Commit Message

Nitin Rawat July 25, 2023, 7:27 p.m. UTC 
  Check host controller state before sending hibern8 command.

Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
---
 drivers/ufs/host/ufs-qcom.c | 4 ++++
 1 file changed, 4 insertions(+)

--
2.17.1

Comments

Bart Van Assche July 25, 2023, 7:56 p.m. UTC | #1 
On 7/25/23 12:27, Nitin Rawat wrote:
> Check host controller state before sending hibern8 command.

A patch description should mention what has been changed and also why. 
The above explains what has been changed but not why. Please explain in 
the commit message why this change is necessary.

Thanks,

Bart.
Bjorn Andersson July 26, 2023, 5:34 a.m. UTC | #2 
On Wed, Jul 26, 2023 at 12:57:10AM +0530, Nitin Rawat wrote:
> Check host controller state before sending hibern8 command.
> 

Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>

Please read https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> ---
>  drivers/ufs/host/ufs-qcom.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8d6fd4c3324f..95412e98a598 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1254,6 +1254,10 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba,
>  	struct ufs_pa_layer_attr *dev_req_params = &host->dev_req_params;
>  	int err = 0;
> 
> +	/* check the host controller state before sending hibern8 cmd */

That is exactly what the two lines does, but the comment does not
provide any insight into why this is done. Keeping a comment here seems
relevant, please make sure that it adds value.

Thanks,
Bjorn

> +	if (!ufshcd_is_hba_active(hba))
> +		return 0;
> +
>  	if (status == PRE_CHANGE) {
>  		err = ufshcd_uic_hibern8_enter(hba);
>  		if (err)
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 8d6fd4c3324f..95412e98a598 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1254,6 +1254,10 @@  static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba,
 	struct ufs_pa_layer_attr *dev_req_params = &host->dev_req_params;
 	int err = 0;

+	/* check the host controller state before sending hibern8 cmd */
+	if (!ufshcd_is_hba_active(hba))
+		return 0;
+
 	if (status == PRE_CHANGE) {
 		err = ufshcd_uic_hibern8_enter(hba);
 		if (err)