diff mbox series

firmware: coreboot: framebuffer: Allow building with simpledrm

Message ID 20230725174334.887485-1-alpernebiyasak@gmail.com
State New
Headers
Series firmware: coreboot: framebuffer: Allow building with simpledrm |

Commit Message

Alper Nebi Yasak July 25, 2023, 5:43 p.m. UTC 
  The coreboot framebuffer driver registers a "simple-framebuffer" device
based on the information from the firmware, after checking that it's
compatible with the formats listed in simplefb.h. It was added before
simpledrm, and its Kconfig marked as dependent on the simplefb driver.

The simpledrm driver can also handle "simple-framebuffer" devices and
the coreboot framebuffer works fine with it on a 'Lick' Chromebook.
Allow building the coreboot framebuffer driver with simpledrm as well.

Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
---

 drivers/firmware/google/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Brian Norris July 25, 2023, 6:02 p.m. UTC | #1 
(administrative note: I doubt coreboot@coreboot.org is interested in
receiving linux kernel driver patches)

On Tue, Jul 25, 2023 at 08:43:33PM +0300, Alper Nebi Yasak wrote:
> The coreboot framebuffer driver registers a "simple-framebuffer" device
> based on the information from the firmware, after checking that it's
> compatible with the formats listed in simplefb.h. It was added before
> simpledrm, and its Kconfig marked as dependent on the simplefb driver.
> 
> The simpledrm driver can also handle "simple-framebuffer" devices and
> the coreboot framebuffer works fine with it on a 'Lick' Chromebook.
> Allow building the coreboot framebuffer driver with simpledrm as well.
> 
> Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>

Reviewed-by: Brian Norris <briannorris@chromium.org>
diff mbox series

Patch

diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index 1bc7cbf2f65d..41b78f5cb735 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -59,7 +59,7 @@  config GOOGLE_MEMCONSOLE_X86_LEGACY
 
 config GOOGLE_FRAMEBUFFER_COREBOOT
 	tristate "Coreboot Framebuffer"
-	depends on FB_SIMPLE
+	depends on FB_SIMPLE || DRM_SIMPLEDRM
 	depends on GOOGLE_COREBOOT_TABLE
 	help
 	  This option enables the kernel to search for a framebuffer in