diff mbox series

[-next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer()

Message ID 20230725135834.1732-1-yuehaibing@huawei.com
State New
Headers
Series [-next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer() |

Commit Message

Yue Haibing July 25, 2023, 1:58 p.m. UTC 
  Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function vmbus_ontimer()")
this is not used anymore, so can remove it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 include/linux/hyperv.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Michael Kelley (LINUX) July 25, 2023, 2:12 p.m. UTC | #1 
From: YueHaibing <yuehaibing@huawei.com> Sent: Tuesday, July 25, 2023 6:59 AM
> 

I'd suggest using "Drivers: hv: vmbus:" as the prefix in the commit message Subject.
I see that "hv: hyperv.h:" has been used a few times in the past, but my suggestion
is much more commonly used and would give better overall consistency.

> Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function
> vmbus_ontimer()")
> this is not used anymore, so can remove it.

Indeed, yes!

Reviewed-by: Michael Kelley <mikelley@microsoft.com>

> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  include/linux/hyperv.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index bfbc37ce223b..3ac3974b3c78 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel
> *channel,
>  				     u32 *buffer_actual_len,
>  				     u64 *requestid);
> 
> -
> -extern void vmbus_ontimer(unsigned long data);
> -
>  /* Base driver object */
>  struct hv_driver {
>  	const char *name;
> --
> 2.34.1
Yue Haibing July 25, 2023, 2:17 p.m. UTC | #2 
On 2023/7/25 22:12, Michael Kelley (LINUX) wrote:
> From: YueHaibing <yuehaibing@huawei.com> Sent: Tuesday, July 25, 2023 6:59 AM
>>
> 
> I'd suggest using "Drivers: hv: vmbus:" as the prefix in the commit message Subject.
> I see that "hv: hyperv.h:" has been used a few times in the past, but my suggestion
> is much more commonly used and would give better overall consistency.

Ok, will send v2.
> 
>> Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function
>> vmbus_ontimer()")
>> this is not used anymore, so can remove it.
> 
> Indeed, yes!
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> 
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  include/linux/hyperv.h | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
>> index bfbc37ce223b..3ac3974b3c78 100644
>> --- a/include/linux/hyperv.h
>> +++ b/include/linux/hyperv.h
>> @@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel
>> *channel,
>>  				     u32 *buffer_actual_len,
>>  				     u64 *requestid);
>>
>> -
>> -extern void vmbus_ontimer(unsigned long data);
>> -
>>  /* Base driver object */
>>  struct hv_driver {
>>  	const char *name;
>> --
>> 2.34.1
> 
> .
>
diff mbox series

Patch

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index bfbc37ce223b..3ac3974b3c78 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1239,9 +1239,6 @@  extern int vmbus_recvpacket_raw(struct vmbus_channel *channel,
 				     u32 *buffer_actual_len,
 				     u64 *requestid);
 
-
-extern void vmbus_ontimer(unsigned long data);
-
 /* Base driver object */
 struct hv_driver {
 	const char *name;