Message ID | 20230725104956.47806-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2408298vqg; Tue, 25 Jul 2023 04:45:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlG/3MPNKbvKMgXfrhqYtXrAloGNTtXJ0ZllV9+DZOUllKDV4F4Hkd7R+f/Aqtlfmb7XiRZ5 X-Received: by 2002:a17:90a:7e95:b0:262:e1a8:7eb0 with SMTP id j21-20020a17090a7e9500b00262e1a87eb0mr9083859pjl.39.1690285539212; Tue, 25 Jul 2023 04:45:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690285539; cv=none; d=google.com; s=arc-20160816; b=EKSJPBy8gMOxyNg+495h9byMX7RO4y86yFBe1R6HSVp4JkfIC9hfIDAVheG2yzisZ+ PjkhInwfomlQmAbbHqoEgsMLcJcZeMnVNAap7pQF68jO8NwiKHgT1Z/2WEsPIL7pEYNq yH2RerQsKna4ul+G06cD3dVuR47FLNQYjbXnusEyuCF2I4m2bV/y23lORBNEmAphR6fD 1UjSzNL1Xu1kkZRvYH+MGHX9RWVGfqwPwLt5t6zwEqL5W5+5lCQiDWmnEG9OE6jWwYmu /gN5dTCU78/rt1xQ4BBQhPSAKD6nGJ79yJocRa8fccV7dcnMc3nASm0icbHQJ0m4C+Oy PAmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=OYDQPZrNB/tiRGVs8vUnxlahrML4B4PTqgWgWTfODE4=; fh=2scq9KNAOdOkeybPSylw7zPZpYu1F/m5xF4nK/9D/xU=; b=ArIdSYVF18dl+nI6vEm5S+uOx2GxhyLEVEpZhs4Xp3f2c4f1mjEq6ON7gMZbhozrth 4URZb8B9cEtfyfVhwOXrnJiAwa24k+DM8SD1/9aDx6p5/+Yg+cpS9SEZAO+8vPyLZE3n g/KmMintK12lMrc6VvDYNkR9iEF/c+OFicCaNye3Iw3zzmRwe78qY/h2ynlSvohss7Kq VOvfWScK/f6ZYLl674cCuN/m/lg5jgZpvCeFEj2hdp3Qx0KKyORo9P4FEeGct2ycuHYV R0ojbVOvlelt6B9CqMqIm258ZCbsb3rb1g0U2UWTJGMwWP/xsiigXsmRrly73FQAEcZ/ JoKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mogBMQc7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i15-20020a17090acf8f00b0026813904130si4781419pju.18.2023.07.25.04.45.24; Tue, 25 Jul 2023 04:45:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mogBMQc7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233725AbjGYKuW (ORCPT <rfc822;kloczko.tomasz@gmail.com> + 99 others); Tue, 25 Jul 2023 06:50:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233730AbjGYKt7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 25 Jul 2023 06:49:59 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6307D199E; Tue, 25 Jul 2023 03:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690282195; x=1721818195; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=N5C5HN9967gW8tCp5yOVdvgPZjm+pd+371s1T29mDB0=; b=mogBMQc7pa7+nA+MJglrdMSCNbc+nU03XJ+AoUtD6RWzmvSTSJlLs9GK 2ATvHlO7XQvBTQUy85zLAFDwuIOl3ow+xrBSIhT3StY9iAr3d8IhFjg/k DZsOg9Fbex55R2sqn1D3xu9c9XgjwQMGrS7GAtPUMZyEyeAkEUuRqHRkc VMEo8psTe6SIkF9KNEeqUR/denitiNU7+7PJTY8QIfjVZj5tR++CCkIq3 eQ8W68Yfu2ASzrqrNDMmQgmZzgEXnvHwBIcHwHIRW+nKJ1AM3PHAKFuma EdEpogH+yvLLeoH1SQ7UwT0xh6bJfBVEqEDQieA6fLrcXze0ugDUuk5GO g==; X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="371295483" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="371295483" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 03:49:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="791332822" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="791332822" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 25 Jul 2023 03:49:49 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D34F52E9; Tue, 25 Jul 2023 13:49:57 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Corbet <corbet@lwn.net>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Stephen Rothwell <sfr@canb.auug.org.au>, Randy Dunlap <rdunlap@infradead.org> Subject: [PATCH v2 1/1] Documentation: core-api: Drop :export: for int_log.h Date: Tue, 25 Jul 2023 13:49:56 +0300 Message-Id: <20230725104956.47806-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772392849578619178 X-GMAIL-MSGID: 1772392849578619178 |
Series |
[v2,1/1] Documentation: core-api: Drop :export: for int_log.h
|
|
Commit Message
Andy Shevchenko
July 25, 2023, 10:49 a.m. UTC
The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() might appear. Otherwise kernel-doc may not produce anything out of this file. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Fixes: f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Acked-by: Jonathan Corbet <corbet@lwn.net> --- v2: added tags (Randy, Jonathan), assumed to go via ASoC tree Documentation/core-api/kernel-api.rst | 1 - 1 file changed, 1 deletion(-)
Comments
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() > might appear. Otherwise kernel-doc may not produce anything out of this > file. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Fixes: f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > Acked-by: Jonathan Corbet <corbet@lwn.net> > --- > v2: added tags (Randy, Jonathan), assumed to go via ASoC tree > Documentation/core-api/kernel-api.rst | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst > index a526fbe06f86..ae92a2571388 100644 > --- a/Documentation/core-api/kernel-api.rst > +++ b/Documentation/core-api/kernel-api.rst > @@ -166,7 +166,6 @@ Integer log and power Functions > ------------------------------- > > .. kernel-doc:: include/linux/int_log.h > - :export: > So I still can't take this patch for the reasons described before. It looks like Mark took the patch that added the problem, so perhaps he should be a recipient of this one too? I'll add him to the CC... jon
On Tue, Jul 25, 2023 at 07:12:25AM -0600, Jonathan Corbet wrote: > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > > --- > > v2: added tags (Randy, Jonathan), assumed to go via ASoC tree > So I still can't take this patch for the reasons described before. It > looks like Mark took the patch that added the problem, so perhaps he > should be a recipient of this one too? That's what have been assumed above. > I'll add him to the CC... Oh, I missed Cc'ing him...
On Tue, Jul 25, 2023 at 07:12:25AM -0600, Jonathan Corbet wrote: > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > > The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() > > might appear. Otherwise kernel-doc may not produce anything out of this > > file. > So I still can't take this patch for the reasons described before. It > looks like Mark took the patch that added the problem, so perhaps he > should be a recipient of this one too? I'll add him to the CC... Is this the same patch I applied yesterday or a different one?
On Tue, Jul 25, 2023 at 02:46:33PM +0100, Mark Brown wrote: > On Tue, Jul 25, 2023 at 07:12:25AM -0600, Jonathan Corbet wrote: > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > > > > The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() > > > might appear. Otherwise kernel-doc may not produce anything out of this > > > file. > > > So I still can't take this patch for the reasons described before. It > > looks like Mark took the patch that added the problem, so perhaps he > > should be a recipient of this one too? I'll add him to the CC... > > Is this the same patch I applied yesterday or a different one? Hmm... I do not see anything like this patch in your current ASoC for-next (nor in for-6.6). Did I look into wrong branch?
On Tue, Jul 25, 2023 at 05:06:30PM +0300, Andy Shevchenko wrote: > On Tue, Jul 25, 2023 at 02:46:33PM +0100, Mark Brown wrote: > > Is this the same patch I applied yesterday or a different one? > Hmm... > I do not see anything like this patch in your current ASoC for-next > (nor in for-6.6). Did I look into wrong branch? There was some random patch you just sent me the message ID for in the replies to something from Stephen which I'm fairly sure I queued, perhaps it was a different thing or git thought it was a noop when it was applied?
On Tue, Jul 25, 2023 at 03:27:58PM +0100, Mark Brown wrote: > On Tue, Jul 25, 2023 at 05:06:30PM +0300, Andy Shevchenko wrote: > > On Tue, Jul 25, 2023 at 02:46:33PM +0100, Mark Brown wrote: > > > > Is this the same patch I applied yesterday or a different one? > > > Hmm... > > I do not see anything like this patch in your current ASoC for-next > > (nor in for-6.6). Did I look into wrong branch? > > There was some random patch you just sent me the message ID for in the > replies to something from Stephen which I'm fairly sure I queued, > perhaps it was a different thing or git thought it was a noop when it > was applied? The first version is here [1]. Then it was a discussion about Linux Next build issues [2]. In the discussion I mentioned: The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent. which is exactly what [1] is. I have no idea how it can be a noop, but the patch is missing as far as I can tell. This thread is v2 of what was in [1]. [1]: https://lore.kernel.org/linux-doc/20230713165320.14199-1-andriy.shevchenko@linux.intel.com/ [2]: https://lore.kernel.org/linux-next/20230713121627.17990c86@canb.auug.org.au/T/#u
On Tue, Jul 25, 2023 at 05:40:54PM +0300, Andy Shevchenko wrote: > On Tue, Jul 25, 2023 at 03:27:58PM +0100, Mark Brown wrote: > > There was some random patch you just sent me the message ID for in the > > replies to something from Stephen which I'm fairly sure I queued, > > perhaps it was a different thing or git thought it was a noop when it > > was applied? > The first version is here [1]. > Then it was a discussion about Linux Next build issues [2]. > In the discussion I mentioned: > The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent. > which is exactly what [1] is. > I have no idea how it can be a noop, but the patch is missing as far > as I can tell. > This thread is v2 of what was in [1]. > [1]: https://lore.kernel.org/linux-doc/20230713165320.14199-1-andriy.shevchenko@linux.intel.com/ > [2]: https://lore.kernel.org/linux-next/20230713121627.17990c86@canb.auug.org.au/T/#u So there's two versions of the patch and for some reason v1 was mentioned yesterday but there's also a v2 version?
On Tue, Jul 25, 2023 at 03:51:44PM +0100, Mark Brown wrote: > On Tue, Jul 25, 2023 at 05:40:54PM +0300, Andy Shevchenko wrote: > > On Tue, Jul 25, 2023 at 03:27:58PM +0100, Mark Brown wrote: > > > > There was some random patch you just sent me the message ID for in the > > > replies to something from Stephen which I'm fairly sure I queued, > > > perhaps it was a different thing or git thought it was a noop when it > > > was applied? > > > The first version is here [1]. > > Then it was a discussion about Linux Next build issues [2]. > > > In the discussion I mentioned: > > > The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent. > > > which is exactly what [1] is. > > > I have no idea how it can be a noop, but the patch is missing as far > > as I can tell. > > > This thread is v2 of what was in [1]. > > > [1]: https://lore.kernel.org/linux-doc/20230713165320.14199-1-andriy.shevchenko@linux.intel.com/ > > [2]: https://lore.kernel.org/linux-next/20230713121627.17990c86@canb.auug.org.au/T/#u > > So there's two versions of the patch and for some reason v1 was > mentioned yesterday but there's also a v2 version? Yes, and I forgot to initially Cc you for v2. If you are using b4, you can take Message ID of this message and I am sure it capable to retrieve v2 of the patch. Or I can resend with you in Cc list.
On Tue, 25 Jul 2023 13:49:56 +0300, Andy Shevchenko wrote: > The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() > might appear. Otherwise kernel-doc may not produce anything out of this > file. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] Documentation: core-api: Drop :export: for int_log.h commit: 5bdeb6f5c7b94f653183f08eca8a08022b2efac6 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, Jul 25, 2023 at 08:20:32PM +0100, Mark Brown wrote: > On Tue, 25 Jul 2023 13:49:56 +0300, Andy Shevchenko wrote: > > The :export: keyword makes sense only for C-files, where EXPORT_SYMBOL() > > might appear. Otherwise kernel-doc may not produce anything out of this > > file. > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! Thank you!
diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst index a526fbe06f86..ae92a2571388 100644 --- a/Documentation/core-api/kernel-api.rst +++ b/Documentation/core-api/kernel-api.rst @@ -166,7 +166,6 @@ Integer log and power Functions ------------------------------- .. kernel-doc:: include/linux/int_log.h - :export: .. kernel-doc:: lib/math/int_pow.c :export: