Message ID | 20230725104608.950442148@linuxfoundation.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2410176vqg; Tue, 25 Jul 2023 04:49:46 -0700 (PDT) X-Google-Smtp-Source: APBJJlHExIuvLhdM5bsI0vigcms+Ldt9qUtohP3vs4m3CJGe0Y1SH72mcP8sWObT+MhSHuhHcBqX X-Received: by 2002:ac2:5970:0:b0:4f9:5a0c:85b8 with SMTP id h16-20020ac25970000000b004f95a0c85b8mr7682018lfp.36.1690285786346; Tue, 25 Jul 2023 04:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690285786; cv=none; d=google.com; s=arc-20160816; b=cAPgGP1dBOsdXK9tA29/gSs09fF8MqqJmdqKWw3ehXjn7RCCFpMHwUNq0SGmpSwTyM IojCJsqBfhOR9TrbKZ8wAUgu2gN2voLpNNKuSzynXsgp94Z/iw77qzL4YK4zg6Nnx9EQ YSb28EVbF4u1KbGRSsGE3u9e4OhT7gq5TH3hJhUkPcUZsIomGjTsUy2shLE58LXxswHW L1oiQ9trYTxW5YKLI7JD/DA2xa7OSD74yK/LRaf6YQLw9on4ZwtLPZMLWaW6OUNvVuJv oxJZKcbkeC1GuVrMbdJBSXpNEklLVE+7Iz7uWN1gtiruiIJW7Tu0afM0pzMwLPg8Ji3z wHig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=58K7gOf6RFhj0fkVL6RbdMJTxgttE27zNcYAYmKSs6I=; fh=lP7xFG8LMCk6E4eEHoDhWf7pUSclif8yeIbxz4oRH8Y=; b=fjLZXr46X462bQCAXA60fzCyLCQ+NRD6o7sqSD7cfrw7SEXgo/Q/kI7suQeJuBkv2f DV4bN/x5f9K6igWnGDg9HkD727b3qhkfYLlkfxCWUVKcSD/TQIHjRHfyISeGfzg1Nf00 w8enDhu92MCfuw/9Ljv5rlcSonGGzm1Qvtoa2dPdJEZUnyIsgj5PWVrgboHm7WS36ZGA 74fmtVdOW4wVT0Li8q8pvjCJXsVUMixlCAvmnQeSsPBM/zuEytDEFN11fq0voS5VqRN4 j5eWcFe7yu5YGOVucL1n+LYYLgASA2GtZZ6k/pBqL4r6Tkwvipb2RLQ+/2rWQRF5B8Gi zRTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ePRn+xDK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y16-20020a170906071000b00993b3881eccsi8205927ejb.691.2023.07.25.04.49.21; Tue, 25 Jul 2023 04:49:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ePRn+xDK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbjGYL0S (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Tue, 25 Jul 2023 07:26:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234489AbjGYL0R (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 25 Jul 2023 07:26:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 598B5187; Tue, 25 Jul 2023 04:26:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EC3376168F; Tue, 25 Jul 2023 11:26:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 078F8C433C7; Tue, 25 Jul 2023 11:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690284375; bh=iO9QVdD47x8v4TjKLcrILY8ClzTFgslHn+QJsF9+AQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ePRn+xDKpZ9LIOTspr3nd60dPfWx5T/qUVUge2AbTzUGguUtAtx7O6Un5oIx94TdK TpvOMwQ4THMVm9fXCEBD+U6RLPo1R6lLyzfzWtyqcmP//ts8EjwDgdOnPG1fdjDRbJ gpW0LfOmq0MwMgGXdcoewYK8ZL73itWbjPfEwA0s= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: stable@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, patches@lists.linux.dev, Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Andres Freund <andres@anarazel.de>, Jens Axboe <axboe@kernel.dk> Subject: [PATCH 5.10 333/509] io_uring: Use io_schedule* in cqring wait Date: Tue, 25 Jul 2023 12:44:32 +0200 Message-ID: <20230725104608.950442148@linuxfoundation.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725104553.588743331@linuxfoundation.org> References: <20230725104553.588743331@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772393108847341898 X-GMAIL-MSGID: 1772393108847341898 |
Series |
None
|
|
Commit Message
Greg KH
July 25, 2023, 10:44 a.m. UTC
From: Andres Freund <andres@anarazel.de> Commit 8a796565cec3601071cbbd27d6304e202019d014 upstream. I observed poor performance of io_uring compared to synchronous IO. That turns out to be caused by deeper CPU idle states entered with io_uring, due to io_uring using plain schedule(), whereas synchronous IO uses io_schedule(). The losses due to this are substantial. On my cascade lake workstation, t/io_uring from the fio repository e.g. yields regressions between 20% and 40% with the following command: ./t/io_uring -r 5 -X0 -d 1 -s 1 -c 1 -p 0 -S$use_sync -R 0 /mnt/t2/fio/write.0.0 This is repeatable with different filesystems, using raw block devices and using different block devices. Use io_schedule_prepare() / io_schedule_finish() in io_cqring_wait_schedule() to address the difference. After that using io_uring is on par or surpassing synchronous IO (using registered files etc makes it reliably win, but arguably is a less fair comparison). There are other calls to schedule() in io_uring/, but none immediately jump out to be similarly situated, so I did not touch them. Similarly, it's possible that mutex_lock_io() should be used, but it's not clear if there are cases where that matters. Cc: stable@vger.kernel.org # 5.10+ Cc: Pavel Begunkov <asml.silence@gmail.com> Cc: io-uring@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Andres Freund <andres@anarazel.de> Link: https://lore.kernel.org/r/20230707162007.194068-1-andres@anarazel.de [axboe: minor style fixup] Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- io_uring/io_uring.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
--- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -7625,7 +7625,7 @@ static inline int io_cqring_wait_schedul struct io_wait_queue *iowq, ktime_t *timeout) { - int ret; + int token, ret; /* make sure we run task_work before checking for signals */ ret = io_run_task_work_sig(); @@ -7635,9 +7635,17 @@ static inline int io_cqring_wait_schedul if (test_bit(0, &ctx->check_cq_overflow)) return 1; + /* + * Use io_schedule_prepare/finish, so cpufreq can take into account + * that the task is waiting for IO - turns out to be important for low + * QD IO. + */ + token = io_schedule_prepare(); + ret = 1; if (!schedule_hrtimeout(timeout, HRTIMER_MODE_ABS)) - return -ETIME; - return 1; + ret = -ETIME; + io_schedule_finish(token); + return ret; } /*