diff mbox series

dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd

Message ID 20230725102900.225262-1-peng.fan@oss.nxp.com
State New
Headers
Series dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd |

Commit Message

Peng Fan (OSS) July 25, 2023, 10:29 a.m. UTC 
  From: Peng Fan <peng.fan@nxp.com>

Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Conor Dooley July 25, 2023, 6:36 p.m. UTC | #1 
On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL

Why not just add a soc-specific compatible for the i.MX8DXL?
The current form of this does not look right to me.

> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> index 407b7cfec783..3a92e4fef7ae 100644
> --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> @@ -18,11 +18,14 @@ allOf:
>  
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - enum:
> -          - fsl,imx8qm-scu-pd
> -          - fsl,imx8qxp-scu-pd
> -      - const: fsl,scu-pd
> +          - fsl,scu-pd
> +      - items:
> +          - enum:
> +              - fsl,imx8qm-scu-pd
> +              - fsl,imx8qxp-scu-pd
> +          - const: fsl,scu-pd
>  
>    '#power-domain-cells':
>      const: 1
> -- 
> 2.37.1
>
Peng Fan July 26, 2023, 12:21 a.m. UTC | #2 
> Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
> 
> On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
> 
> Why not just add a soc-specific compatible for the i.MX8DXL?
> The current form of this does not look right to me.

I could add one dedicated for i.MX8DXL.

Thanks,
Peng.

> 
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > index 407b7cfec783..3a92e4fef7ae 100644
> > --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> > @@ -18,11 +18,14 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    items:
> > +    oneOf:
> >        - enum:
> > -          - fsl,imx8qm-scu-pd
> > -          - fsl,imx8qxp-scu-pd
> > -      - const: fsl,scu-pd
> > +          - fsl,scu-pd
> > +      - items:
> > +          - enum:
> > +              - fsl,imx8qm-scu-pd
> > +              - fsl,imx8qxp-scu-pd
> > +          - const: fsl,scu-pd
> >
> >    '#power-domain-cells':
> >      const: 1
> > --
> > 2.37.1
> >
Conor Dooley July 26, 2023, 7:42 a.m. UTC | #3 
On Wed, Jul 26, 2023 at 12:21:10AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-pd
> > 
> > On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
> > 
> > Why not just add a soc-specific compatible for the i.MX8DXL?
> > The current form of this does not look right to me.
> 
> I could add one dedicated for i.MX8DXL.

Also, where is the user for this? I'd expect to see a dts patch too?
Krzysztof Kozlowski July 26, 2023, 7:44 a.m. UTC | #4 
On 25/07/2023 12:29, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  .../devicetree/bindings/power/fsl,scu-pd.yaml         | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> index 407b7cfec783..3a92e4fef7ae 100644
> --- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> +++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
> @@ -18,11 +18,14 @@ allOf:
>  
>  properties:
>    compatible:
> -    items:
> +    oneOf:
>        - enum:
> -          - fsl,imx8qm-scu-pd
> -          - fsl,imx8qxp-scu-pd
> -      - const: fsl,scu-pd
> +          - fsl,scu-pd

No, sorry, you got in the past comments about style of compatibles.



Best regards,
Krzysztof
Peng Fan July 26, 2023, 7:45 a.m. UTC | #5 
> > > Subject: Re: [PATCH] dt-bindings: power: fsl,scu-pd: separate out fsl,scu-
> pd
> > >
> > > On Tue, Jul 25, 2023 at 06:29:00PM +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > Add an entry dedicated for fsl,scu-pd which could serve i.MX8DXL
> > >
> > > Why not just add a soc-specific compatible for the i.MX8DXL?
> > > The current form of this does not look right to me.
> >
> > I could add one dedicated for i.MX8DXL.
> 
> Also, where is the user for this? I'd expect to see a dts patch too?

arch/arm64/boot/dts/freescale/imx8dxl.dtsi scu node
not use fsl,imx8dxl-scxx. It's already in tree.I am just trying to address
the dtbs_check issue.

Regards,
Peng.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
index 407b7cfec783..3a92e4fef7ae 100644
--- a/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,scu-pd.yaml
@@ -18,11 +18,14 @@  allOf:
 
 properties:
   compatible:
-    items:
+    oneOf:
       - enum:
-          - fsl,imx8qm-scu-pd
-          - fsl,imx8qxp-scu-pd
-      - const: fsl,scu-pd
+          - fsl,scu-pd
+      - items:
+          - enum:
+              - fsl,imx8qm-scu-pd
+              - fsl,imx8qxp-scu-pd
+          - const: fsl,scu-pd
 
   '#power-domain-cells':
     const: 1