From patchwork Tue Jul 25 09:23:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Herve Codina X-Patchwork-Id: 125465 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2357768vqg; Tue, 25 Jul 2023 03:00:45 -0700 (PDT) X-Google-Smtp-Source: APBJJlEDpd2X5nSVZ0oC/R6otcSxJyPnl3fquzRO6A/Bu5TlgVpYnU4CbnmnytYt4+MsT8+I83h0 X-Received: by 2002:a17:906:9bf6:b0:988:6e75:6b3d with SMTP id de54-20020a1709069bf600b009886e756b3dmr11585753ejc.33.1690279244953; Tue, 25 Jul 2023 03:00:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690279244; cv=none; d=google.com; s=arc-20160816; b=asP0IaqljmQTX+LeNeSdInwNYCw9EG0zx6Ty/RViAzjF/bVelyhiWeziQSP4JrATWU PsO5OWFQDqi7zwd1XNA7GkdDxHPc+o3qdQR5hvASLzS1C35RybWJkw4W3hO0MHKZpYpS LkoRdvsP2lUrK9zk2GXztTdjfghz7frhY+1m6qYLd3/2UQmHN0L6zilO1Xo9ydigr720 W3lTzwd1OB2AwpO29vQOicfDAuyJI+Jo9noPx0WAUqA/4brga8MoUFCfODX1W5USr05L +sLiUdKNdjkEhGGKy5MzFxAY+xRfJQ9wPjrtxRAmxDRGu+LBCie7WoGvMEwwJwaNXohN BmVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xIZUkiljeq5EyyyjloaIDqu07RrlxVK9HSpAZYn78Ng=; fh=j5z+1OhFuGBFoHpqsKfNW8PvbyYDiDyztgOSDrYZWKg=; b=L3nwD8QVw/I+AkN5hXQMOpbTECG21kmoBL0kz3PkrvfeVePznPaAN9S5Opg1NPFoe7 ljfaCcvtyDNdRy9UjarIVFAZXsKyCe+FvXEKBEzPpPABJMq0nDniYRX+NaxHwiDcWeiy eMT0JnwW4kG2eClWMaRohnX5GSusE+YCxeRsCotcK0uTK+3beoyd6XGpmAqggfGtxRAz auJfDEnmK4SDtY81Nako4H9EfcaUY846F35iEwyDAi7mYQI1tuqgf+gw3WoUPWvZsE6G zQ9Pz0CmegZKbB5dms5CbQ/SvUHbHfHtwQ5RVYiUQdhd47fEKMzfRustWkSDE5OwzvF7 AYfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=UBeagqBx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a170906248f00b0099317a3240esi7326284ejb.396.2023.07.25.03.00.21; Tue, 25 Jul 2023 03:00:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=UBeagqBx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232714AbjGYJ1a (ORCPT + 99 others); Tue, 25 Jul 2023 05:27:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233228AbjGYJ0w (ORCPT ); Tue, 25 Jul 2023 05:26:52 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDAD110E7; Tue, 25 Jul 2023 02:25:40 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPA id E6F7640016; Tue, 25 Jul 2023 09:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690277137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xIZUkiljeq5EyyyjloaIDqu07RrlxVK9HSpAZYn78Ng=; b=UBeagqBxQbAP4rhEBhUnZhx88v2X+DDVCQWAM3lsq78lrttSkMhhbN2xBgz1I0XqmAYW8A y8W8Tn7FS2LQCWTN95lhK2xA8c5Q02ZRGcW7N9x332eQOzfzPQaK3cAOuVWFJv0S3xjpYd JsYrwWYJpVSEuDsZ3TfM5/3mbZgBDugSBZbAbpHEN1NUc8qLU9SdEpcy4tyjpt5VT47dnO aVaEbJMZSOu6m2LJcaxVrL6wZrg4rZAFLeWs1+QGEpQb+u1ha5DChgIc5ADdXpSWP9i9b7 kQBPAKPBWVDdkpdfNyXYGY32r8gdxGiGg1bUggqY20GIe6LxWzCHhqSL4MAc6A== From: Herve Codina To: Herve Codina , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: [PATCH 15/26] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Date: Tue, 25 Jul 2023 11:23:51 +0200 Message-ID: <20230725092417.43706-16-herve.codina@bootlin.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725092417.43706-1-herve.codina@bootlin.com> References: <20230725092417.43706-1-herve.codina@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772386249557307992 X-GMAIL-MSGID: 1772386249557307992 Timeslots setting is done at channel start() and stop(). There is no more need to do that during setup_chan(). Simply remove timeslot setting from setup_chan(). Signed-off-by: Herve Codina --- drivers/soc/fsl/qe/qmc.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c index 6d1cd203abd2..15872d3e4992 100644 --- a/drivers/soc/fsl/qe/qmc.c +++ b/drivers/soc/fsl/qe/qmc.c @@ -723,30 +723,6 @@ static int qmc_chan_setup_tsa_rx(struct qmc_chan *chan, bool enable) return qmc_chan_setup_tsa_32rx(chan, &info, enable); } -static int qmc_chan_setup_tsa(struct qmc_chan *chan, bool enable) -{ - struct tsa_serial_info info; - int ret; - - /* Retrieve info from the TSA related serial */ - ret = tsa_serial_get_info(chan->qmc->tsa_serial, &info); - if (ret) - return ret; - - /* - * Setup one common 64 entries table or two 32 entries (one for Tx - * and one for Tx) according to assigned TS numbers. - */ - if (chan->qmc->is_tsa_64rxtx) - return qmc_chan_setup_tsa_64rxtx(chan, &info, enable); - - ret = qmc_chan_setup_tsa_32rx(chan, &info, enable); - if (ret) - return ret; - - return qmc_chan_setup_tsa_32tx(chan, &info, enable); -} - static int qmc_chan_command(struct qmc_chan *chan, u8 qmc_opcode) { return cpm_command(chan->id << 2, (qmc_opcode << 4) | 0x0E); @@ -1323,10 +1299,6 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan) chan->qmc = qmc; - ret = qmc_chan_setup_tsa(chan, true); - if (ret) - return ret; - /* Set channel specific parameter base address */ chan->s_param = qmc->dpram + (chan->id * 64); /* 16 bd per channel (8 rx and 8 tx) */