From patchwork Tue Jul 25 05:42:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 125339 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2266961vqg; Mon, 24 Jul 2023 23:15:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlFvJUM/YeW309hA4rLj7VSxoRNDY5CCPyKY8DzGXZmvcdKrJDFueSryre5IHUKn4+JIeFlL X-Received: by 2002:a25:6a41:0:b0:bcb:9b43:5a89 with SMTP id f62-20020a256a41000000b00bcb9b435a89mr8807869ybc.61.1690265725790; Mon, 24 Jul 2023 23:15:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690265725; cv=none; d=google.com; s=arc-20160816; b=09+NYUD1w8vqae4lC0jvkqtKnV3O9p0Trr67qyUDZbTvrdHkFzRICDqGNjA994hnGt mKvj8rMbMrmApOU/ibvzfBa/ARF7bs/trT54HApa0qx1E+jK76GeA7Bld3ARUfqvxp4j EYJOaYJ2dbxtm6OvGmgW+g+GoI8tOSgxLGbkKNIYqYd/7FTNHQoldg4HxotIEFPoJZPE 7V3hdD32zdMovvbgZmEfJovTS/Yg9yi7PRiVwgNRPXEcblENtDZJqXk+tbrlA0xkMTtm /ROhR4xqjFP61gd1hIC0nU4Npxnmko2TnmAhuMZ2scq330O5R/Tk+ifvpMt0QXV9Tsa2 ob9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Jyk0NXwQflmsvPDxU0faqcC+c+qDlE92mPnWPgdf89o=; fh=wxWR7S7XHVlqVIuoke4G1/IBIqVMAhyap/qryV8BrCQ=; b=cjh/n1VgIWVh14jDaAxdt6mT9m5aPD4l9oYvEJSP4gcSiAGbsqW2FRo7CQecwZ3oW5 8CiIqmHbD5NARtv0Pn89JR0HWozNuzljWnYx9pMhXmxMuYRurocd6OS71Wx6nA2gYCW6 zWtC+cHafeifTDxPYztw2rW3sZsyL6p9M5AKmxrTpfrMZS66lSg9WSC+JzW10TknGsi0 rlDW6UGbNGpZKlZeapyUk178tCth2obF+Alu5xIK0R7M/KLs0xFfuk1ykO0yxUKfFj2R uCnYx/nS5cnIQifnjeY1u98qQsIjYSS/HZXH3/E85swdmxPgwcLLsTk1QO9XjiUnz7uR QTqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r91-20020a17090a43e400b0025690b76c95si10900304pjg.10.2023.07.24.23.15.12; Mon, 24 Jul 2023 23:15:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231381AbjGYFmm (ORCPT + 99 others); Tue, 25 Jul 2023 01:42:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbjGYFme (ORCPT ); Tue, 25 Jul 2023 01:42:34 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C825419AF; Mon, 24 Jul 2023 22:42:33 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 5593481A0; Tue, 25 Jul 2023 05:42:31 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Cc: Andy Shevchenko , Dhruva Gole , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH v5 1/3] serial: core: Controller id cannot be negative Date: Tue, 25 Jul 2023 08:42:10 +0300 Message-ID: <20230725054216.45696-2-tony@atomide.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230725054216.45696-1-tony@atomide.com> References: <20230725054216.45696-1-tony@atomide.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772372073799084315 X-GMAIL-MSGID: 1772372073799084315 The controller id cannot be negative. Let's fix the ctrl_id in preparation for adding port_id to fix the device name. Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") Reported-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Tony Lindgren --- include/linux/serial_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -459,7 +459,7 @@ struct uart_port { struct serial_rs485 *rs485); int (*iso7816_config)(struct uart_port *, struct serial_iso7816 *iso7816); - int ctrl_id; /* optional serial core controller id */ + unsigned int ctrl_id; /* optional serial core controller id */ unsigned int irq; /* irq number */ unsigned long irqflags; /* irq flags */ unsigned int uartclk; /* base uart clock */