| Message ID | 20230725054138.129497-3-quic_fenglinw@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2256016vqg;
Mon, 24 Jul 2023 22:49:11 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlHlB8hzmjIXJLNL2CtC7srQncvRtnrJbJ5fHYi0rrMoXzdZTVOIODfvrAZPHsMohhGW5OTY
X-Received: by 2002:a17:907:7606:b0:994:522f:3f4a with SMTP id
jx6-20020a170907760600b00994522f3f4amr11338590ejc.29.1690264150848;
Mon, 24 Jul 2023 22:49:10 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1690264150; cv=none;
d=google.com; s=arc-20160816;
b=StOW9WoHYbj6ygAFqh7mA1Fz6n41yVUas9blVTlafLLeJhe86MMB9tsDwzsHz09Xms
bb8E/cppERWszPe1gchKDwmbBS2YvR1gWMkSYmPJs7N9B5cF03wydQbZLw9yF66O7pGs
qmuSVEaIfb++ew/Ap7VgIpZNQM+DHbN1yV7ztn3jUDJZvcdxgocQCBpm++6S/8/y5+WF
VpLINWnBAgGlrHCHwAfY0glNBoAmifJRY87wZODtXrtfheLszdBSq1UYrjRFXwm9xjxO
5rt1UHrgOHJk2Tkr3jxIx95PN4kCPUC1Kzgn00mzJZFwtPnupYPaavC7HjfqPIQ9g3Cv
b2nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=eFtPPFULX0eridZFtz92ch9JF2r4HqnmfLUWQvgwJFk=;
fh=u7HwzU+Ta/yYxxHlFeCTp1suC6SGttoe0RPfdwIZBsM=;
b=XKfJ6sSn0P6s69aZTK2s9w8DvY652Lszzkp2C0JHT5HSqAGm3Pwp7teBwfgw5IGYz9
4sKwsKBcxUbRPKvDYkjMBKp9nJRZLMatC31K0MnvR0wzFqGGtTTZxvu28Xc00EgNV+Lv
sIq55uTaTR1UprSg5ImDHrm8mQrNyXPsRpZ3tVs9YRqlUmBCGq0rmKfJtRC8pRZ8r6pU
E9sTiat2hbpLup1KBtmjyhIo3MpRmQiKZ/njWqjtWOXvkm1CFb6mcAzBXeUgQ3ZmXoXG
zdSovxVxiAFjIyjnI0RDDe9bKP6iRbUsc3yqxn50UqOc3yHFuxkZEDapwXCB5hXIx3+d
mUtA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="cONkZ/Wx";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
v15-20020a170906564f00b00997b6bca284si7776801ejr.470.2023.07.24.22.48.47;
Mon, 24 Jul 2023 22:49:10 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="cONkZ/Wx";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231346AbjGYFnY (ORCPT <rfc822;kloczko.tomasz@gmail.com>
+ 99 others); Tue, 25 Jul 2023 01:43:24 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52746 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231766AbjGYFm5 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 25 Jul 2023 01:42:57 -0400
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com
[205.220.180.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 642B01FC9;
Mon, 24 Jul 2023 22:42:47 -0700 (PDT)
Received: from pps.filterd (m0279870.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
36P4lXnZ011836;
Tue, 25 Jul 2023 05:42:43 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=qcppdkim1;
bh=eFtPPFULX0eridZFtz92ch9JF2r4HqnmfLUWQvgwJFk=;
b=cONkZ/Wx/6a2YlRJOVR6OsIPP5KfH5Jwo4abkBHnEWJ3fbdYata/sVQXYj4+7R20aXfd
qTgebQCzEthOZDjlV2Xyjmz7zdF1Ym9LLW5wYyvR9gvusiZKOvzd9mFrL9AMraSa7C8d
nHX5hQNsfTbBfDfm69tUqbXUCniBF7srd4ze23B2AtCsdK17nfTYy615yvuiR71X+JNa
bsHw6s77sNL4cvS4xcGbbTY7VDTfn4TWc59X/cpFyXxpnkj2LhPannLlEqIbBKZfR+Mk
BCBteGJkRk1jxFtmNrhEm5p3x35GSJsU45xFWMpMMRA+jNetilHRpKZVgK3b0KZ6WEdP zg==
Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3s1qcyt575-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Tue, 25 Jul 2023 05:42:43 +0000
Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com
[10.47.97.35])
by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
36P5ggv7031251
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Tue, 25 Jul 2023 05:42:42 GMT
Received: from fenglinw2-gv.qualcomm.com (10.80.80.8) by
nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1118.30; Mon, 24 Jul 2023 22:42:38 -0700
From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<dmitry.baryshkov@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
<linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>
CC: <quic_collinsd@quicinc.com>, <quic_subbaram@quicinc.com>,
<quic_fenglinw@quicinc.com>, <quic_kamalw@quicinc.com>,
<jestar@qti.qualcomm.com>
Subject: [PATCH v3 2/3] dt-bindings: input: qcom,pm8xxx-vib: add new SPMI
vibrator module
Date: Tue, 25 Jul 2023 13:41:37 +0800
Message-ID: <20230725054138.129497-3-quic_fenglinw@quicinc.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20230725054138.129497-1-quic_fenglinw@quicinc.com>
References: <20230725054138.129497-1-quic_fenglinw@quicinc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
nalasex01c.na.qualcomm.com (10.47.97.35)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-ORIG-GUID: _TCHnzYNmfzfZRx_NvMEXvV7K1HdOP3D
X-Proofpoint-GUID: _TCHnzYNmfzfZRx_NvMEXvV7K1HdOP3D
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
definitions=2023-07-25_02,2023-07-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
lowpriorityscore=0
malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0
priorityscore=1501 mlxlogscore=999 clxscore=1015 mlxscore=0 bulkscore=0
impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2306200000 definitions=main-2307250051
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1772370422212003940
X-GMAIL-MSGID: 1772370422212003940
|
| Series |
Add support for vibrator in multiple PMICs
|
|
Commit Message
Fenglin Wu
July 25, 2023, 5:41 a.m. UTC
Add compatible string 'qcom,spmi-vib-gen2' for vibrator module inside
PMI632, PMI7250B, PM7325B, PM7550BA. Also, add 'qcom,spmi-vib-gen1'
string for the SPMI vibrator inside PM8916 to maintain the completeness
of the hardware version history for SPMI vibrators.
Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
---
.../bindings/input/qcom,pm8xxx-vib.yaml | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
Comments
On 25/07/2023 07:41, Fenglin Wu wrote: > Add compatible string 'qcom,spmi-vib-gen2' for vibrator module inside > PMI632, PMI7250B, PM7325B, PM7550BA. Also, add 'qcom,spmi-vib-gen1' > string for the SPMI vibrator inside PM8916 to maintain the completeness > of the hardware version history for SPMI vibrators. > > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- > .../bindings/input/qcom,pm8xxx-vib.yaml | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > index c8832cd0d7da..ab778714ad29 100644 > --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml > @@ -11,10 +11,20 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,pm8058-vib > - - qcom,pm8916-vib > - - qcom,pm8921-vib > + oneOf: > + - enum: > + - qcom,pm8058-vib > + - qcom,pm8916-vib > + - qcom,pm8921-vib > + - qcom,spmi-vib-gen1 > + - qcom,spmi-vib-gen2 Generic compatibles should not be alone. Drop both lines. > + - items: > + - enum: > + - qcom,pmi632-vib > + - qcom,pm7250b-vib > + - qcom,pm7325b-vib > + - qcom,pm7550b-vib > + - const: qcom,spmi-vib-gen2 Best regards, Krzysztof
On 7/25/2023 1:53 PM, Krzysztof Kozlowski wrote: > On 25/07/2023 07:41, Fenglin Wu wrote: >> Add compatible string 'qcom,spmi-vib-gen2' for vibrator module inside >> PMI632, PMI7250B, PM7325B, PM7550BA. Also, add 'qcom,spmi-vib-gen1' >> string for the SPMI vibrator inside PM8916 to maintain the completeness >> of the hardware version history for SPMI vibrators. >> >> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> >> --- >> .../bindings/input/qcom,pm8xxx-vib.yaml | 18 ++++++++++++++---- >> 1 file changed, 14 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >> index c8832cd0d7da..ab778714ad29 100644 >> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >> @@ -11,10 +11,20 @@ maintainers: >> >> properties: >> compatible: >> - enum: >> - - qcom,pm8058-vib >> - - qcom,pm8916-vib >> - - qcom,pm8921-vib >> + oneOf: >> + - enum: >> + - qcom,pm8058-vib >> + - qcom,pm8916-vib >> + - qcom,pm8921-vib >> + - qcom,spmi-vib-gen1 >> + - qcom,spmi-vib-gen2 > > Generic compatibles should not be alone. Drop both lines. Sure. I will remove 'qcom,spmi-vib-gen2'. Should I also keep 'qcom,spmi-vib-gen1' as generic compatible and move 'qcom,pm8916-vib' as its fallback as following? compatible: oneOf: - enum: - qcom,pm8058-vib - qcom,pm8921-vib - items: - enum: - qcom,pm8916-vib - const: qcom,spmi-vib-gen1 - items: - enum: - qcom,pmi632-vib - qcom,pm7250b-vib - qcom,pm7325b-vib - qcom,pm7550b-vib - const: qcom,spmi-vib-gen2 I saw 'qcom,pm8916-vib' has been used in multiple DTS files and updating it as a fallback will result updating those DTS files as well. Or please help to suggest if there is any way to keep 'qcom,pm8916-vib' and 'qcom,spmi-vib-gen1' compatible without updating existing DTS nodes. Thanks > >> + - items: >> + - enum: >> + - qcom,pmi632-vib >> + - qcom,pm7250b-vib >> + - qcom,pm7325b-vib >> + - qcom,pm7550b-vib >> + - const: qcom,spmi-vib-gen2 > > > Best regards, > Krzysztof >
On 25/07/2023 08:26, Fenglin Wu wrote: > > > On 7/25/2023 1:53 PM, Krzysztof Kozlowski wrote: >> On 25/07/2023 07:41, Fenglin Wu wrote: >>> Add compatible string 'qcom,spmi-vib-gen2' for vibrator module inside >>> PMI632, PMI7250B, PM7325B, PM7550BA. Also, add 'qcom,spmi-vib-gen1' >>> string for the SPMI vibrator inside PM8916 to maintain the completeness >>> of the hardware version history for SPMI vibrators. >>> >>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> >>> --- >>> .../bindings/input/qcom,pm8xxx-vib.yaml | 18 ++++++++++++++---- >>> 1 file changed, 14 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >>> index c8832cd0d7da..ab778714ad29 100644 >>> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >>> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >>> @@ -11,10 +11,20 @@ maintainers: >>> >>> properties: >>> compatible: >>> - enum: >>> - - qcom,pm8058-vib >>> - - qcom,pm8916-vib >>> - - qcom,pm8921-vib >>> + oneOf: >>> + - enum: >>> + - qcom,pm8058-vib >>> + - qcom,pm8916-vib >>> + - qcom,pm8921-vib >>> + - qcom,spmi-vib-gen1 >>> + - qcom,spmi-vib-gen2 >> >> Generic compatibles should not be alone. Drop both lines. > > Sure. I will remove 'qcom,spmi-vib-gen2'. > Should I also keep 'qcom,spmi-vib-gen1' as generic compatible and move > 'qcom,pm8916-vib' as its fallback as following? I would drop all of generic ones. Entirely remove qcom,spmi-vib-gen2 and qcom,spmi-vib-gen1. Use device specific compatibles names only. As fallback and as first compatible. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml index c8832cd0d7da..ab778714ad29 100644 --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml @@ -11,10 +11,20 @@ maintainers: properties: compatible: - enum: - - qcom,pm8058-vib - - qcom,pm8916-vib - - qcom,pm8921-vib + oneOf: + - enum: + - qcom,pm8058-vib + - qcom,pm8916-vib + - qcom,pm8921-vib + - qcom,spmi-vib-gen1 + - qcom,spmi-vib-gen2 + - items: + - enum: + - qcom,pmi632-vib + - qcom,pm7250b-vib + - qcom,pm7325b-vib + - qcom,pm7550b-vib + - const: qcom,spmi-vib-gen2 reg: maxItems: 1