From patchwork Tue Jul 25 03:31:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?U3RhbmxleSBDaGFuZ1vmmIzogrLlvrdd?= X-Patchwork-Id: 125314 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2222063vqg; Mon, 24 Jul 2023 21:12:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlH7P5kFjMB3wsSx3xe+e+UiFo7ShZxYCyfrI8P4HOeO0nmjjimPWYqVJEl9PB8hUj0MXjIH X-Received: by 2002:a05:6808:210d:b0:3a4:8d82:2c1f with SMTP id r13-20020a056808210d00b003a48d822c1fmr14627160oiw.39.1690258371145; Mon, 24 Jul 2023 21:12:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690258371; cv=none; d=google.com; s=arc-20160816; b=benf3lSyFo8S4WsPKIhg/nQCDXFn6l3w2MBOQQBjRYB53ymxC5iPVrNnNNa/WQ0aRt WscMVNHXLN5FpSoSJiM/zluhSVuKzghO5cqzU6y9z/guoVqHtG1AEdbvZFkAtcbgJ4ck DoLCDd/VVMWhli30+917K25jO+H3s8EyuZ1Gb7mNDvJ0pKQxBa6ACuy49mrl8l82P7hr BEdIWJTv9tBOj8rrtoVLA7cx1MRTms9JfeBaBMw9jG2+m0ZcMZo23nbbbTh6ODAHfxgF D8WflEHAoAMClB4erFyoYmJZIXI9wHlkeKNVCeNhcs/eyvC85OaeCICQDDqnGD+OFDvP ZlPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:authenticated-by; bh=ADNRdjqKQ972HQy7EbDlHOBPxGPxRvUNw1bGHmO28rA=; fh=acEROb1bRYIHVOZsygcTu9WN+D8lSRN0D2k7vqFf47w=; b=N4XLn3kP7/oQO7jrLRslo/WXYmP6/H2ZmAcKU0Nbv9FmtsN6nY2dYJQqt3nSKIZA7A hh+Mw/wdqMFyLuAqmj8joGofaSwJL4NA6G91760RYKrfO5CnGkjluSb220A+oji4w0tr J65s7yG55wYjB60c7m2fLlJ1tXs2nDwnV4OPQYJQabjqFQtmH35YF5ikASgJ8OWfwX7F obrGN8s/BAbuj8qi7mRKyhhpFZ0A8ttBvafLuF0gzPsC2jtsBGa+G97dfArRWB73Z3BA ZSEE3Me3GP7CttUo2hpVJMKYdgkKSVy9yYSfVAQeuVX1vPmN5AGLUSSWre5ZDQShd97L xnFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b192-20020a6334c9000000b005638179ced0si9624948pga.211.2023.07.24.21.12.37; Mon, 24 Jul 2023 21:12:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbjGYDe0 (ORCPT + 99 others); Mon, 24 Jul 2023 23:34:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjGYDeV (ORCPT ); Mon, 24 Jul 2023 23:34:21 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 882021720; Mon, 24 Jul 2023 20:34:09 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 36P3X8ddC016165, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 36P3X8ddC016165 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Tue, 25 Jul 2023 11:33:08 +0800 Received: from RTEXDAG02.realtek.com.tw (172.21.6.101) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 25 Jul 2023 11:33:19 +0800 Received: from RTEXH36506.realtek.com.tw (172.21.6.27) by RTEXDAG02.realtek.com.tw (172.21.6.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Tue, 25 Jul 2023 11:33:18 +0800 Received: from localhost.localdomain (172.21.252.101) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Tue, 25 Jul 2023 11:33:18 +0800 From: Stanley Chang To: Greg Kroah-Hartman CC: Stanley Chang , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alan Stern , Bagas Sanjaya , Flavio Suligoi , Roy Luo , Ray Chi , , , , Subject: [PATCH v9 1/5] usb: phy: add usb phy notify port status API Date: Tue, 25 Jul 2023 11:31:52 +0800 Message-ID: <20230725033318.8361-1-stanley_chang@realtek.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-KSE-ServerInfo: RTEXDAG02.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1770743577321200959 X-GMAIL-MSGID: 1772364362065892612 In Realtek SoC, the parameter of usb phy is designed to can dynamic tuning base on port status. Therefore, add a notify callback of phy driver when usb port status change. The Realtek phy driver is designed to dynamically adjust disconnection level and calibrate phy parameters. When the device connected bit changes and when the disconnected bit changes, do port status change notification: Check if portstatus is USB_PORT_STAT_CONNECTION and portchange is USB_PORT_STAT_C_CONNECTION. 1. The device is connected, the driver lowers the disconnection level and calibrates the phy parameters. 2. The device disconnects, the driver increases the disconnect level and calibrates the phy parameters. When controller to notify connect that device is already ready. If we adjust the disconnection level in notify_connect, the disconnect may have been triggered at this stage. So we need to change that as early as possible. The status change of connection is before port reset. Therefore, we add an api to notify phy the port status changes. In this stage, the device is not port enable, and it will not trigger disconnection. Signed-off-by: Stanley Chang --- v8 to v9 change: using is_root_hub() v7 to v8 change: Add more comments about this api. v6 to v7 change: No change v5 to v6 change: No change v4 to v5 change: No change v3 to v4 change: Fix the warning for checkpatch with strict. v2 to v3 change: Add more comments about the reason for adding this api v1 to v2 change: No change --- drivers/usb/core/hub.c | 23 +++++++++++++++++++++++ include/linux/usb/phy.h | 13 +++++++++++++ 2 files changed, 36 insertions(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index a739403a9e45..fcbad9e86328 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -614,6 +614,29 @@ static int hub_ext_port_status(struct usb_hub *hub, int port1, int type, ret = 0; } mutex_unlock(&hub->status_mutex); + + /* + * There is no need to lock status_mutex here, because status_mutex + * protects hub->status, and the phy driver only checks the port + * status without changing the status. + */ + if (!ret) { + struct usb_device *hdev = hub->hdev; + + /* + * Only roothub will be notified of port state changes, + * since the USB PHY only cares about changes at the next + * level. + */ + if (is_root_hub(hdev)) { + struct usb_hcd *hcd = bus_to_hcd(hdev->bus); + + if (hcd->usb_phy) + usb_phy_notify_port_status(hcd->usb_phy, + port1 - 1, *status, *change); + } + } + return ret; } diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h index e4de6bc1f69b..b513749582d7 100644 --- a/include/linux/usb/phy.h +++ b/include/linux/usb/phy.h @@ -144,6 +144,10 @@ struct usb_phy { */ int (*set_wakeup)(struct usb_phy *x, bool enabled); + /* notify phy port status change */ + int (*notify_port_status)(struct usb_phy *x, int port, + u16 portstatus, u16 portchange); + /* notify phy connect status change */ int (*notify_connect)(struct usb_phy *x, enum usb_device_speed speed); @@ -316,6 +320,15 @@ usb_phy_set_wakeup(struct usb_phy *x, bool enabled) return 0; } +static inline int +usb_phy_notify_port_status(struct usb_phy *x, int port, u16 portstatus, u16 portchange) +{ + if (x && x->notify_port_status) + return x->notify_port_status(x, port, portstatus, portchange); + else + return 0; +} + static inline int usb_phy_notify_connect(struct usb_phy *x, enum usb_device_speed speed) {