From patchwork Mon Jul 24 17:44:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 125139 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1968976vqg; Mon, 24 Jul 2023 11:12:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlEGp5OXTcH7lgPZCY92zonboIkhyLF972JWLgsEkPDUF9PaKhJODV3jqmB6swdH7xs8gZ3q X-Received: by 2002:a05:6402:7d2:b0:51d:f37c:e3b8 with SMTP id u18-20020a05640207d200b0051df37ce3b8mr8585962edy.13.1690222339234; Mon, 24 Jul 2023 11:12:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690222339; cv=none; d=google.com; s=arc-20160816; b=JfGn2J2dJtyT2mEWl3ebzu9Y0ICnddSt8dE5I+8RpajuePbtsK2Xf+QYZ3PYgw40cJ slOzg87+7V4c3nn6hJxDztCmgMtRZ4miMLGh+NBL+/0kXEX/VvGV0AGGG+O7rztGEJ4i UDuKlvqW/Kj2AlmLfbw4GKBnAN+x/+E0zSnsPBkaXMIScpFMQNkzw9DJF/f5lfHHOAWF PWOoLZnAhxxfymRScaMtm9eEF6ddlswPBgVXXCQu3oLsHdHWH/gDP8DQCWuWPteQaPaE Q/J7gpr8IqP8675Br1VA2pFsdl/Wm5UW3je4w2FC+M44ImLf2rrOABi62FkCNKTC23Nt yyFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=4pQHURzHcwcFZ9S0vbzPTsi43pbiloyiG3aJ+/xAmII=; fh=cDlgSYzM/IiVZ/EC06yL1+GD3+pSK8bXSWGje/Xzf2k=; b=0Arcb8ruRDYZRG/GlC6poP40vNc98Q9Dmgc2WdpJERK0thaOlmWWmi6rIhF+KgXEHg dLPmXpXXBsgUsDUgXhz3XgfSKn5DjTpn/tLVE7XZSq02yamqD5MTiu/U2rpD+UKo6SmM 7SGMGMXQBhhoIsIz+qVvDqNvhVRjjuJtdYj0CiQHr9lsCJx5/0/D8RWNIiqtAi4kXgAo 5dE118QgCSG5b2GS1lfKzVmYsQ1jd99f+h5CO299qzsH8AKjP7anHF5LPv84KUJvD8so STWv8FeKVIlnDiqzWCNNL0JOUjMClifKNZY+y2ugz8G0MUs4YqQwctFU0JMR042qUxHe tdmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=HOSlRNRE; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y14-20020aa7c24e000000b005221fc36675si3310369edo.78.2023.07.24.11.11.55; Mon, 24 Jul 2023 11:12:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=HOSlRNRE; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231882AbjGXRrP (ORCPT + 99 others); Mon, 24 Jul 2023 13:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231664AbjGXRqB (ORCPT ); Mon, 24 Jul 2023 13:46:01 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D49A726B9; Mon, 24 Jul 2023 10:44:32 -0700 (PDT) Message-ID: <20230724172844.922152119@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690220664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=4pQHURzHcwcFZ9S0vbzPTsi43pbiloyiG3aJ+/xAmII=; b=HOSlRNRENtX+6xkRO1N3OyyDeOhy2LFaKHXTp8rqFB0QwKy/QwpRCsy0Qd9DoecBO5w37O I/HkCr57Zqx1F3wkWeLKCZsiZsbntE4tXkpj9x8IfmkDUigq1rbo/08Cn7w3k4NR2KkqAH EvigQWvLJJmKSIemeRMuC1nsudNRcQOxEaCmpvBgqYUiygyLd3UKGmY09kx9KTjVfrD8ZZ MpZC7zZGJcssGdb3oZxIxVb6dUG0cUOyGrsdzJisvHe4hX0mZDgNUNIJ6iRlgb+9A+3KGt 6yA5nW/06KEfQ+HSPPDWwdpgckhqs4MXnnScRSp3kLXVh7rO6izszPdHQ5aqMw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690220664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=4pQHURzHcwcFZ9S0vbzPTsi43pbiloyiG3aJ+/xAmII=; b=H1G7mKqnvQfHFb5aBTJRYlKkWHmZVAYoVwWl8jg5lQH06BxuaJG7j3E7mBVujBTqsKf7AT C/0kC4xcSeO4U9Ag== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Tom Lendacky , Andrew Cooper , Arjan van de Ven , "James E.J. Bottomley" , Dick Kennedy , James Smart , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-hwmon@vger.kernel.org, Jean Delvare , Huang Rui , Guenter Roeck , Steve Wahl , Mike Travis , Dimitri Sivanich , Russ Anderson Subject: [patch 21/29] x86/smpboot: Teach it about topo.amd_node_id References: <20230724155329.474037902@linutronix.de> MIME-Version: 1.0 Date: Mon, 24 Jul 2023 19:44:23 +0200 (CEST) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772326579876024242 X-GMAIL-MSGID: 1772326579876024242 When switching AMD over to the new topology parser then the match functions need to look for AMD systems with the extended topology feature at the new topo.amd_node_id member which is then holding the node id information. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/smpboot.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -486,6 +486,7 @@ static bool match_smt(struct cpuinfo_x86 if (c->topo.pkg_id == o->topo.pkg_id && c->topo.die_id == o->topo.die_id && + c->topo.amd_node_id == o->topo.amd_node_id && per_cpu_llc_id(cpu1) == per_cpu_llc_id(cpu2)) { if (c->topo.core_id == o->topo.core_id) return topology_sane(c, o, "smt"); @@ -507,10 +508,13 @@ static bool match_smt(struct cpuinfo_x86 static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o) { - if (c->topo.pkg_id == o->topo.pkg_id && - c->topo.die_id == o->topo.die_id) - return true; - return false; + if (c->topo.pkg_id != o->topo.pkg_id || c->topo.die_id != o->topo.die_id) + return false; + + if (boot_cpu_has(X86_FEATURE_TOPOEXT) && topology_amd_nodes_per_pkg() > 1) + return c->topo.amd_node_id == o->topo.amd_node_id; + + return true; } static bool match_l2c(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o)