From patchwork Mon Jul 24 13:34:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 124998 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1814616vqg; Mon, 24 Jul 2023 06:53:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlGKzIlOrSZxs9CT/JOiPoljTB02BjfXXBYBu2BWvG8yNWqvZ3gGs5a7ZoJ/8RVuPX90c3Xz X-Received: by 2002:a05:6402:128f:b0:522:29ee:2ab with SMTP id w15-20020a056402128f00b0052229ee02abmr3727712edv.14.1690206832156; Mon, 24 Jul 2023 06:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690206832; cv=none; d=google.com; s=arc-20160816; b=oWrROCj5VJ/j0+4mh2uOGkQaTzV9XInLihUlWCjptfgsmjHJGk8Vy0a6bU9BPudaeD i5hP6TLAa4zgFbOiTWeuSH1IXD29bzgbv7/V/k+0cmJKvXS7NBUoP7gKvHgOIPM/i7Mo UA4zHtN6ZPYRV/G/rgacbLfd5K7nRvgYAZe724SDyF2HzYEMrxQYcLjzxRr3z7JQ2SYs whUb3/LFhCuG4dxLRurqyqt707D65Y02dzF4QByrUd1ftXBm2854+TEnSNzaQWW0QK3B tw5YOZSUcfNdfjnG5ktkwaz7EGyzBAmKIPHAgf3SPrke2Q8MBQbYROoTTVzCX59rr/Iy sjmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:mime-version:references:subject:cc:to:from :dkim-signature:dkim-signature:message-id; bh=b8Xt5cYn7tsxj5f5GzHs5GjoZDN6ZZKDqaLjg/BbaXY=; fh=mE3iieUIZLcDfOLIULj9X6/p0bMDPZGFSVRsnyRUnTc=; b=TAP94lGxwky5DxHMBjRaltaLzoNBpFu4QYx+fh+kE96ytJOXYV5z+dc9XkFYQKrV47 LDqd9nbiUPdZYXcGLSVR2EX2kgrt4o6/mQNzLwJqwG8C1r1IIEq/Ci+QTPbb9y9+OTWW zj6iFrDbImTDuL6QYUC9mQVf31QCnzoCE3fdG8Vs2trMtS/gZlcGdjiOFpS6ZAwb2z7D MDcxRr9fE5RmaJElJX0kanYjx7W7RupkUtp9hRTbXbLQLwOA123sbkCG8e99+0NV/p9G XfmI01rkRlB2LZFUyJ0zTxl9MpskbtfJa7SGUqxPWaJkI1RLfprkc+InVByeisqdTkYq v5IA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=hyVDnZMm; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=oNFcrUX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k22-20020aa7c396000000b0051e02f601aasi6490558edq.324.2023.07.24.06.53.27; Mon, 24 Jul 2023 06:53:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=hyVDnZMm; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=oNFcrUX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231389AbjGXNgR (ORCPT + 99 others); Mon, 24 Jul 2023 09:36:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbjGXNfq (ORCPT ); Mon, 24 Jul 2023 09:35:46 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 204E910D1 for ; Mon, 24 Jul 2023 06:35:10 -0700 (PDT) Message-ID: <20230724132045.915729323@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690205662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=b8Xt5cYn7tsxj5f5GzHs5GjoZDN6ZZKDqaLjg/BbaXY=; b=hyVDnZMm328zZyvf5QBemGKZs+Q2iE0T1EdrVijsFxWqAS2fUUxpP8WALjYfMR+YwppUbY qHAFXvKGC9M8pqE9cI+U/AjvUK1RwJRJbPFlI1hBkqMVOdClqwyBKhMUlZtDEFl5yKtVeS H5QFXU6FiJOW4MocZSvwsBTBvU6ft6bekujhK0qJwclAviiwJf54FzRUWRoHBLf/5jy5XX U3VjGCIrF+y2bzUP1eH7FedSCFuUdr6JJl/TJjhMkRnurmJ+DWLcc/dhgAGuQFovH9jgbD PDhMWjMfw6Nrw28K331XGg+d9wHv/jtn41npDI5DsnwqRnxvI1UlMB9yfgfVxA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690205662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=b8Xt5cYn7tsxj5f5GzHs5GjoZDN6ZZKDqaLjg/BbaXY=; b=oNFcrUX9MSZdx8ndzCs18KMcIfoCWf+qfisJhR231Lqe7MP6altfQ9GLb98G94mZYBp0ul PYJAF/u6OclYjIAw== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross , Michael Kelley , Peter Keresztes Schmidt , "Peter Zijlstra (Intel)" Subject: [patch V2 22/58] x86/apic/ipi: Code cleanup References: <20230724131206.500814398@linutronix.de> MIME-Version: 1.0 Date: Mon, 24 Jul 2023 15:34:22 +0200 (CEST) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772310319404777614 X-GMAIL-MSGID: 1772310319404777614 Remove completely useless and mindlessly copied comments and tidy up the code which causes eye bleed when looking at it. Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) --- arch/x86/kernel/apic/ipi.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) --- a/arch/x86/kernel/apic/ipi.c +++ b/arch/x86/kernel/apic/ipi.c @@ -184,18 +184,13 @@ void default_send_IPI_single_phys(int cp void default_send_IPI_mask_sequence_phys(const struct cpumask *mask, int vector) { - unsigned long query_cpu; unsigned long flags; + unsigned long cpu; - /* - * Hack. The clustered APIC addressing mode doesn't allow us to send - * to an arbitrary mask, so I do a unicast to each CPU instead. - * - mbligh - */ local_irq_save(flags); - for_each_cpu(query_cpu, mask) { + for_each_cpu(cpu, mask) { __default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid, - query_cpu), vector, APIC_DEST_PHYSICAL); + cpu), vector, APIC_DEST_PHYSICAL); } local_irq_restore(flags); } @@ -203,18 +198,15 @@ void default_send_IPI_mask_sequence_phys void default_send_IPI_mask_allbutself_phys(const struct cpumask *mask, int vector) { - unsigned int this_cpu = smp_processor_id(); - unsigned int query_cpu; + unsigned int cpu, this_cpu = smp_processor_id(); unsigned long flags; - /* See Hack comment above */ - local_irq_save(flags); - for_each_cpu(query_cpu, mask) { - if (query_cpu == this_cpu) + for_each_cpu(cpu, mask) { + if (cpu == this_cpu) continue; __default_send_IPI_dest_field(per_cpu(x86_cpu_to_apicid, - query_cpu), vector, APIC_DEST_PHYSICAL); + cpu), vector, APIC_DEST_PHYSICAL); } local_irq_restore(flags); } @@ -283,7 +275,6 @@ void default_send_IPI_mask_logical(const local_irq_restore(flags); } -/* must come after the send_IPI functions above for inlining */ static int convert_apicid_to_cpu(int apic_id) { int i;