From patchwork Mon Jul 24 05:07:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 124615 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1584893vqg; Sun, 23 Jul 2023 22:31:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlHwer11lCJk0XOs21/JfBNeVv5NPb5cI6jtXXzpMvg1E3qqhZz+Pr/2SMdBtvXYuXs5NDwv X-Received: by 2002:a17:907:7810:b0:993:f2b4:13c9 with SMTP id la16-20020a170907781000b00993f2b413c9mr9699530ejc.21.1690176701183; Sun, 23 Jul 2023 22:31:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690176701; cv=none; d=google.com; s=arc-20160816; b=q5XYKgfrRjrVJq1VVf/fan6tG64z3pRsybzhBu/gqdmc/gLeU41VVzM+PC1R0CFVtr nP+q3SGHri74QBwJWhs1ZbK7RFklt/e9cWUXObhGcBqCUAKHJKLtUUbbMwE8xXRG5Tc8 E8jJikIGFqx9u4CEEmdqyiCVDFgehGC/8nI68h3ESoo9Y1masVrSEA2qgzUgd2KX7Vri CX/KlOwTSrZFejfyjQxJTw3ukNZ6prEfLdEOj/YdgUPExiMjImtz6qsEBwyUcikkoXmw Ttkfdy7Owfa5sCEsFBFWzZw62qq/ujl8x7iiq0JkuRyEQoGpXtCBAdk4ymvRIllDtwQM TNCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1KTWZ0Gxwvp5YZdQ2I75WQgsYntKVOerFekqefYZ3Q0=; fh=wxWR7S7XHVlqVIuoke4G1/IBIqVMAhyap/qryV8BrCQ=; b=qVziF+0sAP/MTSmT6NiXZNTzKtFw0qQSh/8V4PG2z18wGvRsC/tnLvz/n3YH22ierc iretcsevk5RpomcF/vxaeXpqkFEJ926tLBkBmKIozSV3gG7mC7Rg36NWQ/roA7qPzb16 Uhm613gPT+3f3tzy0GI0v2P1HY06TChNWiHhAcoiO1vshAumOmo0xodwCMULcBCOG9mp FBfq9pVRIpVRb95kSpzd0GrOarijOOpUxKQ6ov2dmMzsbze7Ez35Pa7+suyaCrClsJ8W xHV4O69DtiZahuItpPIpYzsSu//0vP6M7Mla1nUTghv1ZC1vEqqWI8N1/Hk/KcDaE3Ns Ertw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h10-20020a170906110a00b0099a1f78de48si6058409eja.638.2023.07.23.22.31.17; Sun, 23 Jul 2023 22:31:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229711AbjGXFHg (ORCPT + 99 others); Mon, 24 Jul 2023 01:07:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbjGXFHb (ORCPT ); Mon, 24 Jul 2023 01:07:31 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 59AF3E41; Sun, 23 Jul 2023 22:07:24 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 0AE9382CF; Mon, 24 Jul 2023 05:07:21 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko Cc: Andy Shevchenko , Dhruva Gole , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH v4 1/3] serial: core: Controller id cannot be negative Date: Mon, 24 Jul 2023 08:07:03 +0300 Message-ID: <20230724050709.17544-2-tony@atomide.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230724050709.17544-1-tony@atomide.com> References: <20230724050709.17544-1-tony@atomide.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772278724628804587 X-GMAIL-MSGID: 1772278724628804587 The controller id cannot be negative. Let's fix the ctrl_id in preparation for adding port_id to fix the device name. Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") Reported-by: Andy Shevchenko Andy Shevchenko Signed-off-by: Tony Lindgren --- include/linux/serial_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -459,7 +459,7 @@ struct uart_port { struct serial_rs485 *rs485); int (*iso7816_config)(struct uart_port *, struct serial_iso7816 *iso7816); - int ctrl_id; /* optional serial core controller id */ + unsigned int ctrl_id; /* optional serial core controller id */ unsigned int irq; /* irq number */ unsigned long irqflags; /* irq flags */ unsigned int uartclk; /* base uart clock */