| Message ID | 20230722033116.17988-1-yuehaibing@huawei.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp613032vqg;
Fri, 21 Jul 2023 21:23:51 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlGcCoXJg8HamtTMNWVkbo40y7qYxo5dDdmIXqhVsYjC4ESFhRmhgczbC7/uXbwXwOxWkn2J
X-Received: by 2002:a17:907:75db:b0:992:a836:a194 with SMTP id
jl27-20020a17090775db00b00992a836a194mr3799469ejc.59.1689999830961;
Fri, 21 Jul 2023 21:23:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1689999830; cv=none;
d=google.com; s=arc-20160816;
b=OgU8SqkmSuVgMRK00zNPYRHUnqPibYM8EdBYoukWKfLlifKMeUJzeeczg0jIbugCwu
1keXjuU15EZCGvspp64mW82mS8OAvLFdMBKkTJheurt7hXGQ0fjXBIEe7aMRWn/nPl2n
KvM+7AZzaefxXdRFOAn2iYo7Sa5cmHghycrPEN4sTAAdlDWI7pyros6/ErFY5P9CeAeS
rza///PJ47j/ICB6mNOzUdqhrJcXCHBLX9JElC9zszaHUM5jbt79lyk3mgWvMlkMJY0f
WWVlqIQIC/4H4X3FX+6OU6mVx2c4sykRBUusWCdLLQzC/dJr6BGMDpYBfIYzylcoVIqW
mGTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from;
bh=YfG/RN3zW1hSSnmnhMu48RSsjzBEAXMC84vJwVKMPmA=;
fh=RiPQ2wv7JnaqjiehzYS1B26XCINgMvr07EI/Dh9spXQ=;
b=zrgdJGdu2+MZqSP8tkqcK/gb2ODMm2Tf7FXTmBsFH6kdk9xM/yRMprm5DinJOKqDMc
vZBZJd486nSQYaa4VRimID7w5kNhRl7ocM7CTzDuMOeuuvb/S8bHFzuqmaFTDEcLheNx
YMABfde/wYYbfF3eA3hwhjmuiZIv0vxpQl6VnRumMcuTwmWAAPHY/eGLRW1lGBzLlovy
XnI3fAllgYjtQ9JwmsgMKVi1fM0cYmJjjfFkos6DpAZsZwzh3yG5+kIguGQTX3eCd8dk
yZDtFCVzYgJXHYDahqwu1Z95divzP3WH3uLumbTUDF2hhLu3la7kB1lB11I8hEinKGfO
z9vA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
p1-20020a17090628c100b0099334262e18si3279956ejd.49.2023.07.21.21.23.24;
Fri, 21 Jul 2023 21:23:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230347AbjGVDbj (ORCPT <rfc822;assdfgzxcv4@gmail.com>
+ 99 others); Fri, 21 Jul 2023 23:31:39 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41760 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230403AbjGVDbf (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 21 Jul 2023 23:31:35 -0400
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F27DE3AB0;
Fri, 21 Jul 2023 20:31:33 -0700 (PDT)
Received: from canpemm500007.china.huawei.com (unknown [172.30.72.54])
by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R7Bkh0m24zVhsq;
Sat, 22 Jul 2023 11:30:04 +0800 (CST)
Received: from localhost (10.174.179.215) by canpemm500007.china.huawei.com
(7.192.104.62) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 22 Jul
2023 11:31:31 +0800
From: YueHaibing <yuehaibing@huawei.com>
To: <chuck.lever@oracle.com>, <jlayton@kernel.org>, <neilb@suse.de>,
<kolga@netapp.com>, <Dai.Ngo@oracle.com>, <tom@talpey.com>,
<trond.myklebust@hammerspace.com>, <anna@kernel.org>,
<yuehaibing@huawei.com>
CC: <linux-nfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH -next] sunrpc: Remove unused extern declarations
Date: Sat, 22 Jul 2023 11:31:16 +0800
Message-ID: <20230722033116.17988-1-yuehaibing@huawei.com>
X-Mailer: git-send-email 2.10.2.windows.1
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.174.179.215]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
canpemm500007.china.huawei.com (7.192.104.62)
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1772093262681060301
X-GMAIL-MSGID: 1772093262681060301
|
| Series |
[-next] sunrpc: Remove unused extern declarations
|
|
Commit Message
Yue Haibing
July 22, 2023, 3:31 a.m. UTC
Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.")
these declarations are unused, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
include/linux/sunrpc/svcauth.h | 2 --
1 file changed, 2 deletions(-)
Comments
On Fri, Jul 21, 2023 at 11:31:16PM -0400, YueHaibing wrote: > Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") > these declarations are unused, so can remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> LGTM, applied to nfsd-next. Thank you! > --- > include/linux/sunrpc/svcauth.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h > index 6d9cc9080aca..2402b7ca5d1a 100644 > --- a/include/linux/sunrpc/svcauth.h > +++ b/include/linux/sunrpc/svcauth.h > @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); > > extern struct auth_domain *unix_domain_find(char *name); > extern void auth_domain_put(struct auth_domain *item); > -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); > extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); > extern struct auth_domain *auth_domain_find(char *name); > extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); > -extern int auth_unix_forget_old(struct auth_domain *dom); > extern void svcauth_unix_purge(struct net *net); > extern void svcauth_unix_info_release(struct svc_xprt *xpt); > extern int svcauth_unix_set_client(struct svc_rqst *rqstp); > -- > 2.34.1 >
On Sat, 22 Jul 2023, YueHaibing wrote: > Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") > these declarations are unused, so can remove it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks. Could you remove the declaration of auth_unix_lookup too? It was removed in that commit, but the declaration is still with us. Thanks! NeilBrown > --- > include/linux/sunrpc/svcauth.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h > index 6d9cc9080aca..2402b7ca5d1a 100644 > --- a/include/linux/sunrpc/svcauth.h > +++ b/include/linux/sunrpc/svcauth.h > @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); > > extern struct auth_domain *unix_domain_find(char *name); > extern void auth_domain_put(struct auth_domain *item); > -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); > extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); > extern struct auth_domain *auth_domain_find(char *name); > extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); > -extern int auth_unix_forget_old(struct auth_domain *dom); > extern void svcauth_unix_purge(struct net *net); > extern void svcauth_unix_info_release(struct svc_xprt *xpt); > extern int svcauth_unix_set_client(struct svc_rqst *rqstp); > -- > 2.34.1 > >
On 2023/7/24 13:08, NeilBrown wrote: > On Sat, 22 Jul 2023, YueHaibing wrote: >> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") >> these declarations are unused, so can remove it. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thanks. > Could you remove the declaration of auth_unix_lookup too? > It was removed in that commit, but the declaration is still with us. Sure, will do this. > > Thanks! > NeilBrown > >> --- >> include/linux/sunrpc/svcauth.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h >> index 6d9cc9080aca..2402b7ca5d1a 100644 >> --- a/include/linux/sunrpc/svcauth.h >> +++ b/include/linux/sunrpc/svcauth.h >> @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); >> >> extern struct auth_domain *unix_domain_find(char *name); >> extern void auth_domain_put(struct auth_domain *item); >> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); >> extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); >> extern struct auth_domain *auth_domain_find(char *name); >> extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); >> -extern int auth_unix_forget_old(struct auth_domain *dom); >> extern void svcauth_unix_purge(struct net *net); >> extern void svcauth_unix_info_release(struct svc_xprt *xpt); >> extern int svcauth_unix_set_client(struct svc_rqst *rqstp); >> -- >> 2.34.1 >> >> > > . >
On Mon, Jul 24, 2023 at 02:45:07PM +0800, YueHaibing wrote: > On 2023/7/24 13:08, NeilBrown wrote: > > On Sat, 22 Jul 2023, YueHaibing wrote: > >> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") > >> these declarations are unused, so can remove it. > >> > >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > > > Thanks. > > Could you remove the declaration of auth_unix_lookup too? > > It was removed in that commit, but the declaration is still with us. Thanks, Neil. I thought there might be one or two others, but none stood out to me. > Sure, will do this. Yue, I can just fold that into the applied patch. No need to send another. > > Thanks! > > NeilBrown > > > >> --- > >> include/linux/sunrpc/svcauth.h | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h > >> index 6d9cc9080aca..2402b7ca5d1a 100644 > >> --- a/include/linux/sunrpc/svcauth.h > >> +++ b/include/linux/sunrpc/svcauth.h > >> @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); > >> > >> extern struct auth_domain *unix_domain_find(char *name); > >> extern void auth_domain_put(struct auth_domain *item); > >> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); > >> extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); > >> extern struct auth_domain *auth_domain_find(char *name); > >> extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); > >> -extern int auth_unix_forget_old(struct auth_domain *dom); > >> extern void svcauth_unix_purge(struct net *net); > >> extern void svcauth_unix_info_release(struct svc_xprt *xpt); > >> extern int svcauth_unix_set_client(struct svc_rqst *rqstp); > >> -- > >> 2.34.1 > >> > >> > > > > . > >
On 2023/7/24 21:25, Chuck Lever wrote: > On Mon, Jul 24, 2023 at 02:45:07PM +0800, YueHaibing wrote: >> On 2023/7/24 13:08, NeilBrown wrote: >>> On Sat, 22 Jul 2023, YueHaibing wrote: >>>> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") >>>> these declarations are unused, so can remove it. >>>> >>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >>> >>> Thanks. >>> Could you remove the declaration of auth_unix_lookup too? >>> It was removed in that commit, but the declaration is still with us. > > Thanks, Neil. I thought there might be one or two others, but none stood > out to me. > > >> Sure, will do this. > > Yue, I can just fold that into the applied patch. No need to send another. Ok. > > >>> Thanks! >>> NeilBrown >>> >>>> --- >>>> include/linux/sunrpc/svcauth.h | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h >>>> index 6d9cc9080aca..2402b7ca5d1a 100644 >>>> --- a/include/linux/sunrpc/svcauth.h >>>> +++ b/include/linux/sunrpc/svcauth.h >>>> @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); >>>> >>>> extern struct auth_domain *unix_domain_find(char *name); >>>> extern void auth_domain_put(struct auth_domain *item); >>>> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); >>>> extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); >>>> extern struct auth_domain *auth_domain_find(char *name); >>>> extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); >>>> -extern int auth_unix_forget_old(struct auth_domain *dom); >>>> extern void svcauth_unix_purge(struct net *net); >>>> extern void svcauth_unix_info_release(struct svc_xprt *xpt); >>>> extern int svcauth_unix_set_client(struct svc_rqst *rqstp); >>>> -- >>>> 2.34.1 >>>> >>>> >>> >>> . >>> >
diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h index 6d9cc9080aca..2402b7ca5d1a 100644 --- a/include/linux/sunrpc/svcauth.h +++ b/include/linux/sunrpc/svcauth.h @@ -157,11 +157,9 @@ extern void svc_auth_unregister(rpc_authflavor_t flavor); extern struct auth_domain *unix_domain_find(char *name); extern void auth_domain_put(struct auth_domain *item); -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom); extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new); extern struct auth_domain *auth_domain_find(char *name); extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr); -extern int auth_unix_forget_old(struct auth_domain *dom); extern void svcauth_unix_purge(struct net *net); extern void svcauth_unix_info_release(struct svc_xprt *xpt); extern int svcauth_unix_set_client(struct svc_rqst *rqstp);