From patchwork Fri Jul 21 16:18:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 123979 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp340565vqg; Fri, 21 Jul 2023 10:00:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlGHuE540PvLrZKbC4jrx74VIGmxYMU+RBWq++cW9qfJizPcgDisBfRTU6tzgPaKI7MzICi5 X-Received: by 2002:a05:6402:1646:b0:51d:7fa6:62ca with SMTP id s6-20020a056402164600b0051d7fa662camr2162570edx.14.1689958848904; Fri, 21 Jul 2023 10:00:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689958848; cv=none; d=google.com; s=arc-20160816; b=SVkZuCHZyMBmZga4Nex6yYKWgoLXJotzmTi68rPkrtTL3xutgFtjp05Jj6S5MhsWC5 PdzuON9KVSNwI/Ipm/IQoSqlzNld90KYjgiXjz/h6BvrKs0lVilxr6zgl+l7lsX61D9r sRKShI93ckzjvSAh5x1Y4zKioOb5YUcXLX74SauAQl37GNE98ubfAp79sQ2qLNXlBUoB 2zYQBph2dGnO2yH4w6lmIOHlg0bHklKZbhQU2oAde25VkMTlwUm0GWfgWjsyf0DphiZP BopKBsO4Oru7HwZ9PdZFIw2gtdKCfCjWRTixUE3yv0Mf63koIFiLj6LMVApcEGq+g/9k JF2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=3cFxvmO7sr+2mXLVwLsYIFte9IVFO4PRYte249nYxi0=; fh=epHSD/U4qlqwlkxyH4lStiicYWFU1qh809Zbn2TMxbQ=; b=A9sgB28X/QprfSj5xSPp/ybH0uuYO6mNVQ5r5Y83w40xrQa2Ob5434Z33PRTyKNMtb f9UETrqslvrKT8hVRZbNxks/N0VgROmRL+yn51C+y+wPdbzLB2JfsWkD/Dgr03oiU9Ho OvMFNUh1qEac6TmK5kZ7diE1qTMafJMQ3y9uWtdrQYuilxyAMGuUtJV83PGhKa/vDjE6 ihvuGADHPbENVFilRMrJEICz9K0Jv0Sb/35AOPdc43zESb7zpROYN+q/N1Xiwr+XVxAr t1NyqZ6ut7ruVdR3JWrDTEOcU2Zl3Fee2dZdNqQ1OyswRtPCclYB5MD8AA9wMGMOS0S5 a4yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=OdGfTgls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020aa7d984000000b0051dd300b37bsi2554365eds.76.2023.07.21.10.00.23; Fri, 21 Jul 2023 10:00:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=OdGfTgls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232700AbjGUQUe (ORCPT + 99 others); Fri, 21 Jul 2023 12:20:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232577AbjGUQUI (ORCPT ); Fri, 21 Jul 2023 12:20:08 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D71144A2; Fri, 21 Jul 2023 09:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3cFxvmO7sr+2mXLVwLsYIFte9IVFO4PRYte249nYxi0=; b=OdGfTglspj/Kc6tb8paw23WvoY 2IysbbniAYeD32v9Y6SXRDoAF0DV5uypi/ZIYs5EWf39cJxDYQqEd5o/cEJzIy2t91TBaR89/5RIb CqfmE4mvma9/i5KMuJN1HP4DOilrnl5/UCp0tywyf4Ug777smxXYFkh56KMjVXPjwnfA=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:50368 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qMsqB-0003IO-Lj; Fri, 21 Jul 2023 12:18:52 -0400 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, linux-gpio@vger.kernel.org, Hugo Villeneuve , Lech Perczak , Andy Shevchenko Date: Fri, 21 Jul 2023 12:18:33 -0400 Message-Id: <20230721161840.1393996-4-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230721161840.1393996-1-hugo@hugovil.com> References: <20230721161840.1393996-1-hugo@hugovil.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [RESEND PATCH v8 03/10] serial: sc16is7xx: remove obsolete out_thread label X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772050289975832722 X-GMAIL-MSGID: 1772050289975832722 From: Hugo Villeneuve Commit c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later in probe") moved GPIO setup code later in probe function. Doing so also required to move ports cleanup code (out_ports label) after the GPIO cleanup code. After these moves, the out_thread label becomes misplaced and makes part of the cleanup code illogical. This patch remove the now obsolete out_thread label and make GPIO setup code jump to out_ports label if it fails. Fixes: c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later in probe") Signed-off-by: Hugo Villeneuve Reviewed-by: Lech Perczak Tested-by: Lech Perczak Reviewed-by: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 306ae512b38a..32d43d00a583 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1516,7 +1516,7 @@ static int sc16is7xx_probe(struct device *dev, s->gpio.can_sleep = 1; ret = gpiochip_add_data(&s->gpio, s); if (ret) - goto out_thread; + goto out_ports; } #endif @@ -1542,8 +1542,6 @@ static int sc16is7xx_probe(struct device *dev, #ifdef CONFIG_GPIOLIB if (devtype->nr_gpio) gpiochip_remove(&s->gpio); - -out_thread: #endif out_ports: