From patchwork Fri Jul 21 16:18:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 124008 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp346655vqg; Fri, 21 Jul 2023 10:08:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlFAecysj1x3tsUcFmcpmeHtk7dSGMQqtKIWw4lANx1LGM6yYjwk4COwlMV8vaM4Y9ZjnMa0 X-Received: by 2002:a05:6a20:394f:b0:134:1ef9:8c17 with SMTP id r15-20020a056a20394f00b001341ef98c17mr3234193pzg.20.1689959299386; Fri, 21 Jul 2023 10:08:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689959299; cv=none; d=google.com; s=arc-20160816; b=k7fDCnx0MPsu3df+5MhlSKjNqXL0Xe+ZSsJ9fkIrpOomou84klnPhKc33uZ9SD1hDS sJE/xmSmyRjwZj067ofjXOXYYsL0Q/XMqLeOz2dM0lUPzkmaZ1d3m3xAxUC8ZlEg2ONN FU16wRr3WPUCOvBEz5sEiDNbQnEo6tPjTD7IEsiDI7mSFgnf34azML6KE7Osxl3ujnd3 vp2UYgGrn0Lvk1/vTQt5wbdhV7WQOWoLchS6TagUsuUzSYYkQkTSSFQGFAcgCF8+eKOq PSpD5zYZZAHCLEriMV0MjNQymc/9oNgHC6RA+1fYkRItxIWT6o3gh4mmgPAf3Q6eZ8Cc 5UUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=P6gLA3cgegvRbC7LXs18deF6K32T+CIZJfA5vParMVw=; fh=YcnO5F9tILQN1YTlpEJZBUiDonMxpEYqyincPQzfQj8=; b=MjHh3xq8PF+e3vqRX4/yxLiH4m6OG8IxYkoBPTPOa5Wu7i3vsPAvRE80MTsPLtPnd3 a5ESeK64/J7WGyK6hAMIkWZbCAFCnGdV9HKt4h7pwrk3AI2OMNgB5VYRodF8ALh7LYa8 8UYnG4EcjHKSJlXWSRdh34oBrMxEtofZ7BhvRM9CJmAwZv1kyJzE5x814kJcQhXG8nQG 6k8bwJ0aRFi7gXmXaaI+FHz9t4ASy94xonGCVNB5BQteXe79suTP5qBkRvTjx7KyeXoL xp6x3ODQ2jOwd3oGTgO1j0UVLOtJ+nsiCKY/iBmvF2uS4giXv9Qmjnh2VDHF/l1SrilS RieA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=rS2xLOpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a056a00239000b0066a45a450e4si3587501pfc.30.2023.07.21.10.08.06; Fri, 21 Jul 2023 10:08:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=rS2xLOpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232603AbjGUQUb (ORCPT + 99 others); Fri, 21 Jul 2023 12:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232552AbjGUQUH (ORCPT ); Fri, 21 Jul 2023 12:20:07 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07183449C; Fri, 21 Jul 2023 09:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P6gLA3cgegvRbC7LXs18deF6K32T+CIZJfA5vParMVw=; b=rS2xLOpvHRtMvBXolceVC+kXBr R3DX8hv5PtN8Vd98c5IMKpS+Sf4M5spftYCzc5yRlt03rkEi3d5zg1y3iEgmbCDFLl4rht6orgG2+ vNrEkSe2+HEbu6EBDurmvuNwopndUy3qSaNt8XI7dqS6OfLXkeggwFBjzd5RLVHdZLzY=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:50368 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qMsqA-0003IO-Fi; Fri, 21 Jul 2023 12:18:50 -0400 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, linux-gpio@vger.kernel.org, Hugo Villeneuve , stable@vger.kernel.org, Lech Perczak Date: Fri, 21 Jul 2023 12:18:32 -0400 Message-Id: <20230721161840.1393996-3-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230721161840.1393996-1-hugo@hugovil.com> References: <20230721161840.1393996-1-hugo@hugovil.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [RESEND PATCH v8 02/10] serial: sc16is7xx: mark IOCONTROL register as volatile X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772050762428872316 X-GMAIL-MSGID: 1772050762428872316 From: Hugo Villeneuve Bit SRESET (3) is cleared when a reset operation is completed. Having the IOCONTROL register as non-volatile will always read SRESET as 1, which is incorrect. Also, if IOCONTROL register is not a volatile register, the upcoming patch "serial: sc16is7xx: fix regression with GPIO configuration" doesn't work when setting some shared GPIO lines as modem control lines. Therefore mark IOCONTROL register as a volatile register. Cc: # 6.1.x Signed-off-by: Hugo Villeneuve Reviewed-by: Lech Perczak Tested-by: Lech Perczak --- drivers/tty/serial/sc16is7xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 8ae2afc76a9b..306ae512b38a 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -488,6 +488,7 @@ static bool sc16is7xx_regmap_volatile(struct device *dev, unsigned int reg) case SC16IS7XX_TXLVL_REG: case SC16IS7XX_RXLVL_REG: case SC16IS7XX_IOSTATE_REG: + case SC16IS7XX_IOCONTROL_REG: return true; default: break;