From patchwork Fri Jul 21 16:18:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 123970 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp338603vqg; Fri, 21 Jul 2023 09:57:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlFGVMu2LYiKgkvYZajNQEQPi5csISxobm24GM6nwOpNny7jPkk4msaFXsKLihpKbZLQ1qNr X-Received: by 2002:a05:6402:4303:b0:521:946d:8280 with SMTP id m3-20020a056402430300b00521946d8280mr9524847edc.9.1689958640678; Fri, 21 Jul 2023 09:57:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689958640; cv=none; d=google.com; s=arc-20160816; b=bvwvlqhUj9yRmZFNwWcw/QS0+HS2BHsiF6VChM6Z01mLzDptCYy22QZcJ7WDL3DYRs fo8VY34q7WnFD0bZBsOJCx1MGLBt1BUooavN3ItktpuMjRbVeU5KZ6VWh2K7ZuTFu+CX xmpXVoG/k2nHoEuY4kaJd7XYSudsMRqiHdCX1a1xKAlrWUYkhaCOKrB1vkK/Q04Ngk/E 8rtetN0djL+hAKHZo+hzqb+q3DHdBpZvzRRUiv2lxsylK5ztl4Ugr7K54pnRyiKC2awC 3WX/lsSwyfUg7pOcXckS477/qeGI+FTnDZ9XpIUENXToxYaVKf6ejXms9CHK+fmICUjl zBmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from:dkim-signature; bh=9yfW8mHRhmt1BZssK5Nqf/xXTWUgDfzvBAsuQ90MFC8=; fh=8lgP9Q7yUti3QJsgyDqXJNhUNHaf4UcodBK5t7Tk2ug=; b=DpcaqCw/SdoRgQZuS7S50o1uCF5hduYd75gdPhqpIeb5likLzS+QqCRgqTFKYRI8pf MYdztBDV8nOf2MGX7ZxihJ0XT3vCl0++HlMAHOeGXxtqZf94yCIXLyVypq2LN8Px0wHi AnBMP9bcgrR0y95crWyAH0jxcOnKhzy6IRECc7UksTf0kPAzFY11fhz/c2IFeKwnKu5M PNgQMuWHrQBj5+iPehyBVbJriFGftDAQNN96SJ8UsyYMi/bnFhwAXFvyrCNSq4EaeT2/ APxUSao3tu6yCHtihIClYvf9NAbI0/wjYOHkGrixlukSxVFWPQoZVBZVj95eo2nps7aS o/iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=ALbbEmSJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o22-20020aa7d3d6000000b0051df118addasi2681064edr.230.2023.07.21.09.56.50; Fri, 21 Jul 2023 09:57:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=ALbbEmSJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbjGUQVV (ORCPT + 99 others); Fri, 21 Jul 2023 12:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232661AbjGUQU1 (ORCPT ); Fri, 21 Jul 2023 12:20:27 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 865AA46A9; Fri, 21 Jul 2023 09:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9yfW8mHRhmt1BZssK5Nqf/xXTWUgDfzvBAsuQ90MFC8=; b=ALbbEmSJ1RENtwHraobo8ese4C 1fESJIbYgHFz+SPqgyaAi9y+yO43fDDr+jjfCuUtpOowutm411OXUXtMDUizT2xK2qWr9Sr4bdn4l 7m+zYDRXY8NYt+jdojaoyjyoFPHxgP7082EmrlBdHokMRSAoiAUXwql0cZmFP9Rl7uTU=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:50368 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qMsqO-0003IO-Pl; Fri, 21 Jul 2023 12:19:05 -0400 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, linux-gpio@vger.kernel.org, Hugo Villeneuve , Lech Perczak Date: Fri, 21 Jul 2023 12:18:40 -0400 Message-Id: <20230721161840.1393996-11-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230721161840.1393996-1-hugo@hugovil.com> References: <20230721161840.1393996-1-hugo@hugovil.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [RESEND PATCH v8 10/10] serial: sc16is7xx: improve comments about variants X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772050071642202380 X-GMAIL-MSGID: 1772050071642202380 From: Hugo Villeneuve Replace 740/750/760 with generic terms like 74x/75x/76x to account for variants like 741, 752 and 762. Signed-off-by: Hugo Villeneuve Reviewed-by: Lech Perczak --- drivers/tty/serial/sc16is7xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 718e982e1efe..d6851360ef7d 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -223,7 +223,7 @@ * trigger levels. Trigger levels from 4 characters to 60 characters are * available with a granularity of four. * - * When the trigger level setting in TLR is zero, the SC16IS740/750/760 uses the + * When the trigger level setting in TLR is zero, the SC16IS74x/75x/76x uses the * trigger level setting defined in FCR. If TLR has non-zero trigger level value * the trigger level defined in FCR is discarded. This applies to both transmit * FIFO and receive FIFO trigger level setting. @@ -234,7 +234,7 @@ #define SC16IS7XX_TLR_TX_TRIGGER(words) ((((words) / 4) & 0x0f) << 0) #define SC16IS7XX_TLR_RX_TRIGGER(words) ((((words) / 4) & 0x0f) << 4) -/* IOControl register bits (Only 750/760) */ +/* IOControl register bits (Only 75x/76x) */ #define SC16IS7XX_IOCONTROL_LATCH_BIT (1 << 0) /* Enable input latching */ #define SC16IS7XX_IOCONTROL_MODEM_A_BIT (1 << 1) /* Enable GPIO[7:4] as modem A pins */ #define SC16IS7XX_IOCONTROL_MODEM_B_BIT (1 << 2) /* Enable GPIO[3:0] as modem B pins */ @@ -249,9 +249,9 @@ #define SC16IS7XX_EFCR_RTS_INVERT_BIT (1 << 5) /* RTS output inversion */ #define SC16IS7XX_EFCR_IRDA_MODE_BIT (1 << 7) /* IrDA mode * 0 = rate upto 115.2 kbit/s - * - Only 750/760 + * - Only 75x/76x * 1 = rate upto 1.152 Mbit/s - * - Only 760 + * - Only 76x */ /* EFR register bits */