[v2,03/11] ALSA: hda: cs35l41: Check mailbox status of pause command after firmware load
Message ID | 20230721151816.2080453-4-sbinding@opensource.cirrus.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp296906vqg; Fri, 21 Jul 2023 08:50:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlFASOZ+mOfJDZmBD9axilyFKUHDwLBmMLCuyJ4tEbwRzdnmk++ytl/vA3hO0K5Jq4VP/kVt X-Received: by 2002:a05:6a00:2347:b0:682:713e:e520 with SMTP id j7-20020a056a00234700b00682713ee520mr478793pfj.8.1689954620636; Fri, 21 Jul 2023 08:50:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689954620; cv=none; d=google.com; s=arc-20160816; b=zG0xHrUc9kmDcM5uJP+oD3EcKLmSfhdr2rZ98Z9HtjOiEgUtm0RU4YCRpo5ddcA6k0 eU4+nR066zS/Krw5+nJQ1nfHRxyoejquQbNr3L+9WxUeDY2ejb30uPFEpgC0C1nvhjap vrFO6sY1S9MqnqeQ/8VCDg6AZ8ySNx2yrFT9pDZMv3vqEMct0Eiw5nK/SVzml7KO0J+r x6gNw20syAIzWCr2lqNuHjhHecDMMFtbvRt0XISC4Wyxqg0NgXprwbsa1qrcg8i+XK9l 4oZ+LZCV+7lVhd68nN8ng64w9K95NK1/ZiQjYPrtVQVb6utU85o8LZf6bYitWNUD89dB lEOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EiuPuPFrlkojOXOF0eP6Mp1vYF/Par8Q01lLhTZsruo=; fh=SlosecZATRUXmC/bbEWM8TNuSSdsEnMKt8FFeHbK2kw=; b=Q2EADxLXMHs8FcOY9YOPoXYYBhrhdBVZwryNeeVWhwd9UrtD+RXEQHG/2PZfWcnRhm hCIHDIX6DFkit71QaSTz0H2jLBIeoM/lBPbwzxG6ggr0gC7HIVUak0y3vabj64O4tWg5 nLy6jYvIBJPUKsE3HIC7wuMMQ1EzcIkh9SJ7ByBGZQ0T1/eNtASpMseAmA48B34OsfUU bUc1Pi20IvZ8VogJGlSdxlcotLJzWY71ZhMGIljBswza5BzCf3E6733ytN3o08dvCsX6 ZGyyt9OfS7p8qCYtGAx5qdE01LEnSQq0CiqvvxQb0kQDktfGniVRHc0tMJ2tfMGr+MUK PXDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=fWnzOQS7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z38-20020a056a001da600b00682bec0b685si3125292pfw.237.2023.07.21.08.50.06; Fri, 21 Jul 2023 08:50:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=fWnzOQS7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231934AbjGUPTi (ORCPT <rfc822;assdfgzxcv4@gmail.com> + 99 others); Fri, 21 Jul 2023 11:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231764AbjGUPTW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Jul 2023 11:19:22 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAA67359C for <linux-kernel@vger.kernel.org>; Fri, 21 Jul 2023 08:18:53 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 36LDppwj011284; Fri, 21 Jul 2023 10:18:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PODMain02222019; bh=EiuPuPFrlkojOXOF0eP6Mp1vYF/Par8Q01lLhTZsruo=; b= fWnzOQS76zdRLqDVzKeeqebvdTriSsrX63tBzTtcdbKOtiKpHtnOOeX2dNwjnkNa KBhD6cUUkMjJu150MO8JkTI5JjG2ukakwAbRzUz3m0xaLtS/teqrdijtG40Bh1sh eQKFvERS70s/LjGd2wnsn9+MyI9WlFlMlfZBqiK1MbPXX1TTQSWXT+cBiXTx+ieE lKg9492yoYFBKZkKkGdTRTiUx+G01dVfQ97eDBefBeqHxZS5/WpMnsi3sJ7/LFSE eeZU9zFTXKJm3UL8upXQLAFK/zSWm558omvgG3o4MTBIBVAXfaQHY3boGWCn91ZT tvot5fORHz6cNLlTLA9mgg== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3rus62y8g5-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Jul 2023 10:18:30 -0500 (CDT) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 21 Jul 2023 16:18:26 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.30 via Frontend Transport; Fri, 21 Jul 2023 16:18:26 +0100 Received: from sbinding-cirrus-dsktp2.ad.cirrus.com (unknown [198.90.238.219]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 2023315B6; Fri, 21 Jul 2023 15:18:26 +0000 (UTC) From: Stefan Binding <sbinding@opensource.cirrus.com> To: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com> CC: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>, Stefan Binding <sbinding@opensource.cirrus.com> Subject: [PATCH v2 03/11] ALSA: hda: cs35l41: Check mailbox status of pause command after firmware load Date: Fri, 21 Jul 2023 16:18:08 +0100 Message-ID: <20230721151816.2080453-4-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230721151816.2080453-1-sbinding@opensource.cirrus.com> References: <20230721151816.2080453-1-sbinding@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: fYwUMO83TH-O7nPgvuzXqLhLToPbJpoU X-Proofpoint-ORIG-GUID: fYwUMO83TH-O7nPgvuzXqLhLToPbJpoU X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772045856102197360 X-GMAIL-MSGID: 1772045856102197360 |
Series |
Fix support for System Suspend for CS35L41 HDA
|
|
Commit Message
Stefan Binding
July 21, 2023, 3:18 p.m. UTC
Currently, we do not check the return status of the pause command,
immediately after we load firmware. If the pause has failed,
the firmware is not running.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
sound/pci/hda/cs35l41_hda.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index f9c97270db6f6..29f1dce45f1dc 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -781,7 +781,12 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41) goto clean_dsp; } - cs35l41_set_cspl_mbox_cmd(cs35l41->dev, cs35l41->regmap, CSPL_MBOX_CMD_PAUSE); + ret = cs35l41_set_cspl_mbox_cmd(cs35l41->dev, cs35l41->regmap, CSPL_MBOX_CMD_PAUSE); + if (ret) { + dev_err(cs35l41->dev, "Error waiting for DSP to pause: %u\n", ret); + goto clean_dsp; + } + cs35l41->firmware_running = true; return 0;