diff mbox series

[v2,2/2] dt-bindings: ti-serdes-mux: Deprecate header with constants

Message ID 20230721125732.122421-3-j-choudhary@ti.com
State New
Headers
Series Deprecate ti-serdes header file |

Commit Message

Jayesh Choudhary July 21, 2023, 12:57 p.m. UTC 
  The constants to define the idle state of SERDES MUX were defined in
bindings header. They are used only in DTS and driver uses the dt property
to set the idle state making it unsuitable for bindings.
The constants are moved to header next to DTS ("arch/arm64/boot/dts/ti/")
and all the references to bindings header are removed.
So add a warning to mark this bindings header as deprecated.

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Roger Quadros <rogerq@kernel.org>
---
 include/dt-bindings/mux/ti-serdes.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Peter Rosin July 22, 2023, 10:18 a.m. UTC | #1 
Hi!

2023-07-21 at 14:57, Jayesh Choudhary wrote:
> The constants to define the idle state of SERDES MUX were defined in
> bindings header. They are used only in DTS and driver uses the dt property
> to set the idle state making it unsuitable for bindings.
> The constants are moved to header next to DTS ("arch/arm64/boot/dts/ti/")
> and all the references to bindings header are removed.
> So add a warning to mark this bindings header as deprecated.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Acked-by: Roger Quadros <rogerq@kernel.org>

Best to keep this patch together with 1/2, so I'm assuming they will
take the same path to Linus, and that an ack from me will suffice.
Thanks again!

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

> ---
>  include/dt-bindings/mux/ti-serdes.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/dt-bindings/mux/ti-serdes.h b/include/dt-bindings/mux/ti-serdes.h
> index 669ca2d6abce..b0b1091aad6d 100644
> --- a/include/dt-bindings/mux/ti-serdes.h
> +++ b/include/dt-bindings/mux/ti-serdes.h
> @@ -6,6 +6,14 @@
>  #ifndef _DT_BINDINGS_MUX_TI_SERDES
>  #define _DT_BINDINGS_MUX_TI_SERDES
>  
> +/*
> + * These bindings are deprecated, because they do not match the actual
> + * concept of bindings but rather contain pure constants values used only
> + * in DTS board files.
> + * Instead include the header in the DTS source directory.
> + */
> +#warning "These bindings are deprecated. Instead, use the header in the DTS source directory."
> +
>  /* J721E */
>  
>  #define J721E_SERDES0_LANE0_QSGMII_LANE1	0x0
Nishanth Menon July 24, 2023, 4:41 p.m. UTC | #2 
On 12:18-20230722, Peter Rosin wrote:
> Hi!
> 
> 2023-07-21 at 14:57, Jayesh Choudhary wrote:
> > The constants to define the idle state of SERDES MUX were defined in
> > bindings header. They are used only in DTS and driver uses the dt property
> > to set the idle state making it unsuitable for bindings.
> > The constants are moved to header next to DTS ("arch/arm64/boot/dts/ti/")
> > and all the references to bindings header are removed.
> > So add a warning to mark this bindings header as deprecated.
> > 
> > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Acked-by: Roger Quadros <rogerq@kernel.org>
> 
> Best to keep this patch together with 1/2, so I'm assuming they will
> take the same path to Linus, and that an ack from me will suffice.
> Thanks again!
> 
> Acked-by: Peter Rosin <peda@axentia.se>

Thank you. I can take it via TI SoC dts tree unless there is any objection.
diff mbox series

Patch

diff --git a/include/dt-bindings/mux/ti-serdes.h b/include/dt-bindings/mux/ti-serdes.h
index 669ca2d6abce..b0b1091aad6d 100644
--- a/include/dt-bindings/mux/ti-serdes.h
+++ b/include/dt-bindings/mux/ti-serdes.h
@@ -6,6 +6,14 @@ 
 #ifndef _DT_BINDINGS_MUX_TI_SERDES
 #define _DT_BINDINGS_MUX_TI_SERDES
 
+/*
+ * These bindings are deprecated, because they do not match the actual
+ * concept of bindings but rather contain pure constants values used only
+ * in DTS board files.
+ * Instead include the header in the DTS source directory.
+ */
+#warning "These bindings are deprecated. Instead, use the header in the DTS source directory."
+
 /* J721E */
 
 #define J721E_SERDES0_LANE0_QSGMII_LANE1	0x0